Page MenuHomePhabricator
Create Task
Maniphest T387448

Logo update script tries to make some logos huge, puts things in non-alphabetic order
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
This is the diff the script makes for wmf-config/logos.php:

P73767 Bad patch created by logo script
1diff --git a/wmf-config/logos.php b/wmf-config/logos.php
2index 9cae90295..81df00df6 100644
3--- a/wmf-config/logos.php
4+++ b/wmf-config/logos.php
5@@ -680,9 +680,9 @@ return [
6 'fawikinews' => '/static/images/project-logos/fawikinews.png',
7 'fiwikinews' => '/static/images/project-logos/fiwikinews.png',
8 'frwikinews' => '/static/images/project-logos/frwikinews.png',
9- 'guwwikinews' => '/static/images/project-logos/guwwikinews.png', // T335162
10 'hewikinews' => '/static/images/project-logos/hewikinews.png',
11 'huwikinews' => '/static/images/project-logos/huwikinews.png',
12+ 'guwwikinews' => '/static/images/project-logos/guwwikinews.png', // T335162
13 'itwikinews' => '/static/images/project-logos/itwikinews.png',
14 'jawikinews' => '/static/images/project-logos/jawikinews.png',
15 'kowikinews' => '/static/images/project-logos/kowikinews.png',
16@@ -2327,16 +2327,16 @@ return [
17 'width' => 120,
18 'height' => 25,
19 ],
20+ 'annwiki' => [ // T377535
21+ 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-ann.svg',
22+ 'width' => 124,
23+ 'height' => 18,
24+ ],
25 'anwiki' => [
26 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-an.svg',
27 'width' => 121,
28 'height' => 24,
29 ],
30- 'annwiki' => [
31- 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-ann.svg',
32- 'width' => 120,
33- 'height' => 17,
34- ],
35 'arcwiki' => [
36 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-arc.svg',
37 'width' => 119,
38@@ -2792,6 +2792,11 @@ return [
39 'width' => 120,
40 'height' => 18,
41 ],
42+ 'kcgwiki' => [
43+ 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-kcg.svg',
44+ 'width' => 119,
45+ 'height' => 18,
46+ ],
47 'kgewiki' => [ // T377075
48 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-kge.svg',
49 'width' => 110,
50@@ -3139,8 +3144,8 @@ return [
51 ],
52 'rskwiki' => [ // T377536
53 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-rsk.svg',
54- 'width' => 110,
55- 'height' => 18,
56+ 'width' => 127,
57+ 'height' => 21,
58 ],
59 'ruewiki' => [
60 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-rue.svg',
61@@ -3269,8 +3274,8 @@ return [
62 ],
63 'tddwiki' => [ // T377537
64 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-tdd.svg',
65- 'width' => 120,
66- 'height' => 17,
67+ 'width' => 119,
68+ 'height' => 9,
69 ],
70 'tetwiki' => [
71 'src' => '/static/images/mobile/copyright/wikipedia-wordmark-fr.svg',
72@@ -4149,8 +4154,8 @@ return [
73 ],
74 'gorwikiquote' => [ // T377542
75 'src' => '/static/images/mobile/copyright/wikiquote-wordmark-gor.svg',
76- 'width' => 121,
77- 'height' => 50,
78+ 'width' => 122,
79+ 'height' => 51,
80 ],
81 'guwikiquote' => [
82 'src' => '/static/images/mobile/copyright/wikiquote-wordmark-gu.svg',
83@@ -4708,8 +4713,8 @@ return [
84 ],
85 'shnwikinews' => [ // T377543
86 'src' => '/static/images/mobile/copyright/wikinews-wordmark-shn.svg',
87- 'width' => 146,
88- 'height' => 44,
89+ 'width' => 486,
90+ 'height' => 149,
91 ],
92 'sqwikinews' => [
93 'src' => '/static/images/mobile/copyright/wikinews-wordmark-sq.svg',
94@@ -5274,10 +5279,10 @@ return [
95 'width' => 121,
96 'height' => 28,
97 ],
98- 'cowikimedia' => [
99+ 'cowikimedia' => [ // T386872
100 'src' => '/static/images/mobile/copyright/wikimedia-wordmark-co.svg',
101- 'width' => 121,
102- 'height' => 28,
103+ 'width' => 140,
104+ 'height' => 32,
105 ],
106 'dkwikimedia' => [
107 'src' => '/static/images/mobile/copyright/wikimedia-wordmark-dk.svg',
108@@ -5761,16 +5766,16 @@ return [
109 'width' => 114,
110 'height' => 13,
111 ],
112+ 'annwiki' => [ // T377535
113+ 'src' => '/static/images/mobile/copyright/wikipedia-tagline-ann.svg',
114+ 'width' => 103,
115+ 'height' => 12,
116+ ],
117 'anwiki' => [
118 'src' => '/static/images/mobile/copyright/wikipedia-tagline-an.svg',
119 'width' => 120,
120 'height' => 14,
121 ],
122- 'annwiki' => [
123- 'src' => '/static/images/mobile/copyright/wikipedia-tagline-ann.svg',
124- 'width' => 102,
125- 'height' => 11,
126- ],
127 'arcwiki' => [
128 'src' => '/static/images/mobile/copyright/wikipedia-tagline-arc.svg',
129 'width' => 110,
130@@ -6333,8 +6338,8 @@ return [
131 ],
132 'ibawiki' => [ // T377538
133 'src' => '/static/images/mobile/copyright/wikipedia-tagline-iba.svg',
134- 'width' => 120,
135- 'height' => 12,
136+ 'width' => 807,
137+ 'height' => 85,
138 ],
139 'idwiki' => [ // T258552
140 'src' => '/static/images/mobile/copyright/wikipedia-tagline-id.svg',
141@@ -6693,7 +6698,7 @@ return [
142 ],
143 'moswiki' => [ // T377539
144 'src' => '/static/images/mobile/copyright/wikipedia-tagline-mos.svg',
145- 'width' => 120,
146+ 'width' => 119,
147 'height' => 11,
148 ],
149 'mrjwiki' => [
150@@ -6978,8 +6983,8 @@ return [
151 ],
152 'rskwiki' => [ // T377536
153 'src' => '/static/images/mobile/copyright/wikipedia-tagline-rsk.svg',
154- 'width' => 110,
155- 'height' => 9,
156+ 'width' => 119,
157+ 'height' => 10,
158 ],
159 'ruewiki' => [
160 'src' => '/static/images/mobile/copyright/wikipedia-tagline-rue.svg',
161@@ -7178,8 +7183,8 @@ return [
162 ],
163 'tddwiki' => [ // T377537
164 'src' => '/static/images/mobile/copyright/wikipedia-tagline-tdd.svg',
165- 'width' => 110,
166- 'height' => 9,
167+ 'width' => 120,
168+ 'height' => 8,
169 ],
170 'tetwiki' => [
171 'src' => '/static/images/mobile/copyright/wikipedia-tagline-tet.svg',

As you can see, it moves the a listing for guwwikinews to below huwikinews for no apparent reason (g comes before h in the alphabet), and it changes a lot of sizes for logos I didn't want to touch. Most notably, it makes the logo for ibawiki HUGE, the same with the logo for shwikinews.

What should have happened instead?:

  • It probably shouldn't touch sizes for logos I'm not changing, and it should definitely not make them that big.

The same apparently happened to @Zabe before: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1112720

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Rebuild logo filesPpperyoperations/mediawiki-configmaster+40 -371
Logos: Fix order of guwwikinews in yaml filePpperyoperations/mediawiki-configmaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

jhsoby created this task.Feb 27 2025, 1:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2025, 1:14 PM
Pppery subscribed.Feb 27 2025, 11:57 PM

It regenerates the PHP file from scratch with every update, which is why this is happening.

Pppery added a subscriber: Hamishcn.Feb 28 2025, 12:11 AM

The guwwikinews reordering happens because the logo for guwwikinews is in the wikipedia section of the YAML file for some reason.

The other changes are because it sets the size given in logos.php to the viewBox size of the SVG, and the Commons SVG files have viewboxes that are the wrong size.

@Hamishcn seems to be responsible for the original wrong-sized wordmarks, and apparently manually edited logos.php instead of running the script properly. Now only a Commons admin can fix this.

It would have been nice if we had had T341412 so this couldn't happen.

Anoop subscribed.Mar 1 2025, 4:06 AM
Pppery claimed this task.Mar 12 2025, 9:24 PM
gerritbot added a comment.Mar 12 2025, 9:28 PM

Change #1127156 had a related patch set uploaded (by Pppery; author: Pppery):

[operations/mediawiki-config@master] Logos: Fix order of guwwikinews in yaml file

https://gerrit.wikimedia.org/r/1127156

gerritbot added a project: Patch-For-Review.Mar 12 2025, 9:28 PM
gerritbot added a comment.Mar 12 2025, 10:00 PM

Change #1127160 had a related patch set uploaded (by Pppery; author: Pppery):

[operations/mediawiki-config@master] Rebuild logo files

https://gerrit.wikimedia.org/r/1127160

gerritbot added a comment.Mar 13 2025, 8:25 PM

Change #1127156 merged by jenkins-bot:

[operations/mediawiki-config@master] Logos: Fix order of guwwikinews in yaml file

https://gerrit.wikimedia.org/r/1127156

gerritbot added a comment.Mar 13 2025, 8:25 PM

Change #1127160 merged by jenkins-bot:

[operations/mediawiki-config@master] Rebuild logo files

https://gerrit.wikimedia.org/r/1127160

Stashbot added a comment.Mar 13 2025, 8:25 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-13T20:25:34Z] <jhuneidi@deploy2002> Started scap sync-world: Backport for [[gerrit:1127160|Rebuild logo files (T387448)]], [[gerrit:1127156|Logos: Fix order of guwwikinews in yaml file (T387448)]], [[gerrit:1127110|logos: have CI fail on uncommited logos.php changes (T341412)]]

Stashbot mentioned this in T341412: CI on mediawiki-config should assert that the logos.php is generated by logos/manage.py.Mar 13 2025, 8:25 PM
Stashbot added a comment.Mar 13 2025, 8:28 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-13T20:28:28Z] <jhuneidi@deploy2002> hashar, pppery, jhuneidi: Backport for [[gerrit:1127160|Rebuild logo files (T387448)]], [[gerrit:1127156|Logos: Fix order of guwwikinews in yaml file (T387448)]], [[gerrit:1127110|logos: have CI fail on uncommited logos.php changes (T341412)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2025, 8:30 PM
Pppery closed this task as Resolved.Mar 13 2025, 8:38 PM
Stashbot added a comment.Mar 13 2025, 8:44 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-13T20:44:53Z] <jhuneidi@deploy2002> Finished scap sync-world: Backport for [[gerrit:1127160|Rebuild logo files (T387448)]], [[gerrit:1127156|Logos: Fix order of guwwikinews in yaml file (T387448)]], [[gerrit:1127110|logos: have CI fail on uncommited logos.php changes (T341412)]] (duration: 19m 18s)

Anoop awarded a token.Mar 16 2025, 2:10 PM

works now correctly https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1128032

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits