'Unhandled Exception ("Error")' displayed when attempting to filter the Phabricator activity feed by IDs/PHIDs
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	A_smart_kitten
	Feb 27 2025, 3:57 PM

Description

Steps to replicate the issue

Navigate to the Phabricator activity feed (https://phabricator.wikimedia.org/feed/query/all/), and click the "Edit Query" button in the top-right.
Enter a task ID (e.g., 387468) into the "IDs" field, and click "Search".
- The error message 'Unhandled Exception ("Error")' 'Call to undefined method PhabricatorFeedQuery::withIDs()' is displayed. (https://phabricator.wikimedia.org/feed/query/xSPzWqrFGThe/)
Enter a PHID (e.g., PHID-TASK-w2krfmkx24tbxse3hgnn) into the "PHIDs" field, and click "Search".
- The error message 'Unhandled Exception ("Error")' ''Call to undefined method PhabricatorFeedQuery::withPHIDs()' is displayed. (https://phabricator.wikimedia.org/feed/query/oVMbkRth9i6G/)

What should have happened instead?
The searches should have completed successfully, and displayed the activity feed for the provided IDs/PHIDs.

Related Objects

Mentioned In: T415453: Delete some now invalid PhabricatorFeedQuery saved queries in the Phab DB
Mentioned Here: T351289: Remove custom "Expert Mode"

Event Timeline

A_smart_kitten created this task.Feb 27 2025, 3:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2025, 3:57 PM

Uh, thanks. I'm puzzled where these two fields come from. I do not see them in upstream, I do not see them in my local instance of Wikimedia Phabricator.
Same for https://phabricator.wikimedia.org/feed/transactions/ . I don't see anything obvious in our downstream diff

It's hidden under expert mode T351289: Remove custom "Expert Mode"

Whoa, thanks for finding that!

Fixed in https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/commit/e610188169c6d96c4e5de8f6cf98a2d288d03006, to be deployed next time.

Hmm, after removing we now get errors in our error log when someone tries to access a saved feed queries which have such IDs and PHIDs saved as parameters (SELECT * from phabricator_search.search_savedquery WHERE engineClassName = "PhabricatorFeedSearchEngine" AND parameters LIKE "%\"ids\":[\"%"; and SELECT * from phabricator_search.search_savedquery WHERE engineClassName = "PhabricatorFeedSearchEngine" AND parameters LIKE "%\"phids\":[\"%";) but I think I am fine with these consequences.

Aklapper mentioned this in T415453: Delete some now invalid PhabricatorFeedQuery saved queries in the Phab DB.Sat, Jan 24, 11:52 PM

'Unhandled Exception ("Error")' displayed when attempting to filter the Phabricator activity feed by IDs/PHIDsClosed, ResolvedPublicBUG REPORTActions

Description

Related Objects

Event Timeline

'Unhandled Exception ("Error")' displayed when attempting to filter the Phabricator activity feed by IDs/PHIDs
Closed, ResolvedPublicBUG REPORT
Actions