Page MenuHomePhabricator

Make icon and title clickable
Open, Needs TriagePublic

Description

The home icon / text [VIdeoCutTool] should be clickable, and should redirect to /

Screenshot 2025-02-27 at 22.20.53.png (2,504×1,022 px, 2 MB)

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
videocuttool: Made the logo and icon and title clickabe. ...cloudvps-repos/videocuttool/VideoCutTool!47aditya0545clickable-iconmaster
videocuttool: Made the logo and icon and title clickabe. ...cloudvps-repos/videocuttool/VideoCutTool!46aditya0545clickable-iconmaster
videocuttool: Made the logo and icon and title clickabe. ...cloudvps-repos/videocuttool/VideoCutTool!32aditya0545clickable-iconmaster
Customize query in GitLab

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

I have understand the problem and I am going to do changes in this file
VideoCutTool/src/components/Header.jsx

am i going right ?

@Adityakumar0545: Please find out by testing your changes before and after. :)

hey @Adityakumar0545 yes you're going in the right direction.
may i add a couple of check points for exit criteria here

  • functionality: redirect to /
  • check on both web and msite (mobile view)
  • add a unit test mimicking the same functionality (you can refer to home.test.jsx for reference) [ probably something around fireEvent.click(); should work ]

@Reputation22 Thanks, I will do same

@RoadToWiki is My community tags, I want to add all the works in my community tags.

@Adityakumar0545: Please find out by testing your changes before and after. :)

Sure

Hi @Adityakumar0545

Have reviewed the PRs, please check on the comments

Thanks ;-)

Punith.nyk added a subscriber: Adityakumar0545.

Since there was no response from the assignee, removing for now so that others can take it up.

Hi @Reputation22,
Thank you for your feedback on my previous PR. I’ve made the suggested changes and updated this PR accordingly. Could you please review it? If there’s still anything that needs improvement, I’d really appreciate your guidance, as I’m very eager to contribute and learn from this project.

https://gitlab.wikimedia.org/cloudvps-repos/videocuttool/VideoCutTool/-/merge_requests/46

hey @Adityakumar0545 have reviewed the PR and have left some comments. please check and address
thanks

hey @Adityakumar0545 sorry for the late response, have reviewed your MR and left some comments
please check and resolve them

also feel free to discuss your open pointers/doubts regarding the ticket here (if any)

Rishabh23 subscribed.

Hi @Reputation22 @Aklapper ,
I created the MR for this issue. I wasn't able to test it after login due to IP block issue (#T424174).

Please let me know your thoughts on this.

https://gitlab.wikimedia.org/cloudvps-repos/videocuttool/VideoCutTool/-/merge_requests/63