Page MenuHomePhabricator
Create Task
Maniphest T387521

Section titles failing to resolve redirected templates
Closed, ResolvedPublic
Actions

Description

As noted in T368095#9913092 and T387374#10587246

A template can be redirected. A section title should point to the resolved template name, not the original, otherwise section edit links will be to the wrong template page.

A test was added for this in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1053387

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Bump wikimedia/parsoid to 0.24.0-a12C. Scott Ananianmediawiki/vendorwmf/1.47.0-wmf.8+414 -121
Bump wikimedia/parsoid to 0.24.0-a12C. Scott Ananianmediawiki/vendormaster+414 -121
[parser] Return HeadingPFragments while preprocessingC. Scott Ananianmediawiki/corewmf/1.47.0-wmf.7+50 -7
[parser] Return HeadingPFragments while preprocessingC. Scott Ananianmediawiki/corewmf/1.47.0-wmf.8+50 -7
[parser] Return HeadingPFragments while preprocessingArlolramediawiki/coremaster+50 -7
Add a HeadingPFragment type to be returned by the preprocessorArlolramediawiki/services/parsoidmaster+64 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

ABreault-WMF created this task.Feb 27 2025, 8:29 PM
Restricted Application added a project: Parsoid. · View Herald TranscriptFeb 27 2025, 8:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ABreault-WMF mentioned this in T387374: Compound templates prevent section edit links where legacy adds them.Feb 27 2025, 8:30 PM
SLopes-WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Mar 6 2025, 3:23 PM
SLopes-WMF moved this task from Backlog to Q1 FY26-27 on the Content-Platform-Team (Work In Progress) board.Mar 6 2025, 3:34 PM
MSantos moved this task from Uncategorized to Wiktionary on the Parsoid-Read-Views board.Mar 13 2025, 12:38 PM
MSantos edited projects, added: Parsoid-Read-Views (Wiktionary); removed: Parsoid-Read-Views.
ABreault-WMF added a parent task: T391624: Parsoid section edit link issues.Apr 10 2025, 7:43 PM
MSantos removed a project: Content-Platform-Team (Work In Progress).May 13 2025, 10:04 AM
MSantos edited projects, added: Parsoid-Read-Views (Small Size Wikipedias); removed: Parsoid-Read-Views (Wiktionary).Nov 13 2025, 3:28 PM
ihurbain subscribed.May 5 2026, 11:15 AM

At a (vaguely educated) guess, it's plausible that the fact that we do have links on https://en.wikipedia.org/w/index.php?title=Template:YouTuber-bio-stub&oldid=1252778015&useparsoid=1 (and we don't on legacy) is related.

Honjitsu-Seiten subscribed.May 5 2026, 11:44 AM
A_smart_kitten subscribed.May 5 2026, 11:59 AM
SomeRandomDeveloper subscribed.May 6 2026, 5:14 PM
ABreault-WMF claimed this task.Jun 19 2026, 10:40 PM
ABreault-WMF added a project: Content-Platform-Team (Work In Progress).
ABreault-WMF moved this task from Q1 FY26-27 to In Progress on the Content-Platform-Team (Work In Progress) board.
gerritbot added a comment.Jun 20 2026, 1:47 AM

Change #1304193 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Return HeadingPFragments

https://gerrit.wikimedia.org/r/1304193

gerritbot added a project: Patch-For-Review.Jun 20 2026, 1:47 AM
gerritbot added a comment.Jun 22 2026, 6:56 PM

Change #1304192 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Add a HeadingPFragment type to be returned by the preprocessor

https://gerrit.wikimedia.org/r/1304192

gerritbot added a comment.Jun 23 2026, 1:09 AM

Change #1304193 merged by jenkins-bot:

[mediawiki/core@master] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1304193

gerritbot added a comment.Jun 23 2026, 1:10 AM

Change #1304192 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add a HeadingPFragment type to be returned by the preprocessor

https://gerrit.wikimedia.org/r/1304192

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2026, 1:31 AM
gerritbot added a comment.Jun 23 2026, 5:26 AM

Change #1305015 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[mediawiki/core@wmf/1.47.0-wmf.8] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305015

gerritbot added a project: Patch-For-Review.Jun 23 2026, 5:26 AM
gerritbot added a comment.Jun 23 2026, 5:33 AM

Change #1305018 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[mediawiki/core@wmf/1.47.0-wmf.7] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305018

gerritbot added a comment.Jun 23 2026, 1:27 PM

Change #1305015 merged by jenkins-bot:

[mediawiki/core@wmf/1.47.0-wmf.8] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305015

Stashbot mentioned this in T387520: Support section edit links to nested templates.Jun 23 2026, 1:29 PM
Stashbot mentioned this in T391624: Parsoid section edit link issues.

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:29:20Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305015|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305026|[parser] Return ExtTagPFragments while preprocessing (T429624)]]

Stashbot mentioned this in T429624: Link to edit TemplateData is broken with Parsoid Read Views.Jun 23 2026, 1:29 PM
Stashbot mentioned this in T384490: Include directives on a line with headings prevent the legacy parser from generating section edit links.
Stashbot added a comment.Jun 23 2026, 1:31 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:31:31Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305015|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305026|[parser] Return ExtTagPFragments while preprocessing (T429624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 23 2026, 1:41 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:41:53Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305015|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305026|[parser] Return ExtTagPFragments while preprocessing (T429624)]] (duration: 12m 31s)

gerritbot added a comment.Jun 23 2026, 1:42 PM

Change #1305018 merged by jenkins-bot:

[mediawiki/core@wmf/1.47.0-wmf.7] [parser] Return HeadingPFragments while preprocessing

https://gerrit.wikimedia.org/r/1305018

Stashbot added a comment.Jun 23 2026, 1:44 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:44:02Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305017|[parser] Add configuration to return experimental PFragment types]], [[gerrit:rGOJU130501848b37|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305025|[parser] Return ExtTagPFragments while preprocessing (T429624)]]

Stashbot added a comment.Jun 23 2026, 1:46 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:46:11Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305017|[parser] Add configuration to return experimental PFragment types]], [[gerrit:rGOJU130501848b37|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305025|[parser] Return ExtTagPFragments while preprocessing (T429624)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be v

Stashbot added a comment.Jun 23 2026, 1:52 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-23T13:52:30Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305017|[parser] Add configuration to return experimental PFragment types]], [[gerrit:rGOJU130501848b37|[parser] Return HeadingPFragments while preprocessing (T391624 T387520 T387521 T384490 T387374)]], [[gerrit:1305025|[parser] Return ExtTagPFragments while preprocessing (T429624)]] (duration: 08m 29s)

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2026, 2:33 PM
gerritbot added a comment.Jun 25 2026, 2:50 PM

Change #1305690 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305690

gerritbot added a project: Patch-For-Review.Jun 25 2026, 2:50 PM
gerritbot added a comment.Jun 25 2026, 3:44 PM

Change #1305690 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305690

gerritbot added a comment.Jun 25 2026, 4:22 PM

Change #1305719 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.8] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305719

gerritbot added a comment.Jun 25 2026, 4:35 PM

Change #1305719 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.8] Bump wikimedia/parsoid to 0.24.0-a12

https://gerrit.wikimedia.org/r/1305719

Stashbot mentioned this in T429822: CTT tasks week of 2026-06-19.Jun 25 2026, 4:36 PM
Stashbot mentioned this in T420336: mw-parsoid improvements.

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:36:37Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]]

Stashbot mentioned this in T353697: Parsoid/legacy parser {{Pre}} template rendering difference.Jun 25 2026, 4:36 PM
Stashbot mentioned this in T429688: mw-empty-elt wrapping does not take DOMFragments into account.
Stashbot mentioned this in T393295: Measurement plan + Analysis for the "Get Started" experiment (WE1.2.17, FY24/25).

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:38:41Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 25 2026, 4:46 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-25T16:46:32Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1305719|Bump wikimedia/parsoid to 0.24.0-a12 (T353697 T384490 T387374 T387520 T387521 T391624 T393295 T420336 T429624 T429688 T429822)]], [[gerrit:1305720|Bump wikimedia/parsoid to 0.24.0-a12 (T429822)]] (duration: 09m 54s)

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2026, 5:32 PM
ABreault-WMF added a comment.EditedJun 26 2026, 8:52 PM
In T387521#11889115, @ihurbain wrote:

At a (vaguely educated) guess, it's plausible that the fact that we do have links on https://en.wikipedia.org/w/index.php?title=Template:YouTuber-bio-stub&oldid=1252778015&useparsoid=1 (and we don't on legacy) is related.

Not a bad guess, but I think it's more because the headings are ultimately generated from Module:Article_stub_box and so there's no template source to associate them with. I filed this as T430367

ABreault-WMF mentioned this in T430367: Parsoid adds section edit links to post-expansion where the preprocessor omitted them.Jun 26 2026, 9:08 PM
ABreault-WMF closed this task as Resolved.Jun 26 2026, 9:12 PM

On huwiktionary, Sablon:Further_reading has the source #ÁTIRÁNYÍTÁS [[Sablon:infos]], which is a redirect

https://hu.wiktionary.org/w/index.php?title=Szerkeszt%C5%91:ABreault_(WMF)/sandbox&oldid=3523772 contains {{Further_reading}} and both

https://hu.wiktionary.org/w/index.php?title=Szerkeszt%C5%91:ABreault_(WMF)/sandbox&oldid=3523772&useparsoid=0
https://hu.wiktionary.org/w/index.php?title=Szerkeszt%C5%91:ABreault_(WMF)/sandbox&oldid=3523772&useparsoid=1

have section edit links to https://hu.wiktionary.org/w/index.php?title=Sablon:infos&action=edit&section=T-1 demonstrating the redirect was resolved

ABreault-WMF moved this task from In Progress to To Verify on the Content-Platform-Team (Work In Progress) board.Jun 26 2026, 9:13 PM
MSantos added a project: OKR-Work.Jul 9 2026, 11:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits