[{reqId}] {exception_url} TypeError: MediaWiki\Permissions\UltimateAuthority::__construct(): Argument #1 ($actor) must be of type MediaWiki\User\UserIdentity, bool given, called in /srv/mediawiki/php-1.44.0-wmf.18/extensions/CentralAuth/includes/Hooks/Hhttps://gerrit.wikimedia.org/g/mediawiki/core/+/4c8ddb06bb48b55886d3610c07db487fddbf023e/includes/user/UserGroupManager.php#727
https://gerrit.wikimedia.org/g/mediawiki/core/+/4c8ddb06bb48b55886d3610c07db487fddbf023e/includes/user/Hook/UserGroupsChangedHook.php#26
@param User|false $performer User who performed the change, false if via autopromotion
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralAuth/+blame/refs/heads/wmf/1.44.0-wmf.18/includes/Hooks/Handlers/UserGroupsHookHandler.php#87
new UltimateAuthority( $performer )
Not sure if autopromotion should be ignored in this scope or if a different ultimate authority needs to be crafted (the user themself?).
(Similar problem with $reason.)
Not 100% sure, but this only seems to be appearing on PHP 8.1... T387605: TypeError: Argument 1 passed to MediaWiki\Permissions\UltimateAuthority::__construct() must implement interface MediaWiki\User\UserIdentity, bool given, called in /srv/mediawiki/php-1.44.0-wmf.18/extensions/CentralAuth/includes is similar, but not the same on PHP 7.4
Not sure if autopromotion should be ignored in this scope or if a different ultimate authority needs to be crafted (the user themself?).
The intent of the code is to consistently enforce that being in a local group associates with a global group, so it shouldn't be ignored. But what it should be logged as is unclear.
Also the code should probably short-circuit and not call the manager at all if no groups need to be added, which would fix this in production since the only use of this feature is CheckUser/Oversight -> global-temporary-account-viewer where autopromotion doesn't make sense.
722 // update groups in external authentication database 723 // TODO: deprecate passing full User object to hook 724 $this->hookRunner->onUserGroupsChanged( 725 $userObj, 726 $toPromote, [], 727 false, 728 false, 729 $oldUGMs, 730 $newUGMs 731 );
It seems core has explicitly been passing false as the performer for a long time... rMWd00dfbd756fb: Move User::addAutopromoteOnceGroups to UserGroupManager
rECAU22122188e6b9: Update automatic global group membership on local group change introduced this handler that doesn't like the parameter. Part of T376315: Control access to global-temporary-account-viewer group on WMF wikis automatically
This was only merged recently, included in wmf/1.44.0-wmf.18
The short term fix for this is to return if the performer is not set, as this feature isn't yet being used. A more long term fix would be to use some kind of maintenance script user.
Change #1123771 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CentralAuth@master] UserGroupsHookHandler: Return early if performer is false
Change #1123772 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CentralAuth@wmf/1.44.0-wmf.18] UserGroupsHookHandler: Return early if performer is false
Created patches for the short-term fix. I've seen 446 of these errors in logstash, though it looks like it would prevent the edits by anyone who is just about to be autopromoted so it is problematic (as it essentially is blocking some users from making any edits). I'm not going to deploy the fix right now given that I don't think it appears to meet the criteria for an emergency deployment, but would not oppose anyone else doing that or asking for it to happen.
Fix is the same as Notifications (Echo) has for a hook subscriber for the same hook - rECHO073ade0a7721: Use UserGroupsChanged hook instead of deprecated UserRights hook
Change #1123772 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@wmf/1.44.0-wmf.18] UserGroupsHookHandler: Return early if performer is false
I went to check if the docs for this hook already document that $performer may be false in the case of autopromote.. and they are! so nothing to fix there either
* @param User|false $performer User who performed the change, false if via autopromotion
Mentioned in SAL (#wikimedia-operations) [2025-03-02T00:21:49Z] <reedy@deploy2002> Started scap sync-world: Backport for [[gerrit:1123772|UserGroupsHookHandler: Return early if performer is false (T387523)]]
Mentioned in SAL (#wikimedia-operations) [2025-03-02T00:25:48Z] <reedy@deploy2002> reedy, dreamyjazz: Backport for [[gerrit:1123772|UserGroupsHookHandler: Return early if performer is false (T387523)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Change #1123771 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] UserGroupsHookHandler: Return early if performer is false
Mentioned in SAL (#wikimedia-operations) [2025-03-02T00:32:23Z] <reedy@deploy2002> Finished scap sync-world: Backport for [[gerrit:1123772|UserGroupsHookHandler: Return early if performer is false (T387523)]] (duration: 10m 33s)