IP reveal guidance dialog: Do not show IPInfo checkbox if user does not have appropriate IPInfo rights
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

What is the problem?

Currently, on the second page of the IP reveal guidance dialog you are shown the "Enable IP Information" checkbox to allow the preference, even if you don't have the rights to IPInfo. Trying to save the preference via the dialog will have no effect.

API response is:

{
    "warnings": {
        "options": {
            "warnings": "Validation error for \"ipinfo-use-agreement\": not a valid preference."
        }
    },
    "options": "success"
}

Steps to reproduce problem

On an environment with CheckUser and IP Info installed and $wgCheckUserEnableTempAccountsOnboardingDialog = true;
Login as a user with checkuser-temporary-account-viewer but not any of the IPInfo rights
Go to Special:RecentChanges, Special:Watchlist or the revision history for a page
A dialog should appear, click the next button to see the IPInfo preference checkbox

Environment

Wiki(s): local docker CheckUser 2.5 (ef2879f) 07:44, 28 February 2025.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	IP reveal onboarding: Hide IPInfo preference if user lacks right	mediawiki/extensions/CheckUser	master	+63 -9

Customize query in gerrit

Related Objects

Mentioned Here: T375086: Bring IP Info access permissions to parity with the IP Reveal feature
rECHUef2879f71c38: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Feb 28 2025, 8:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2025, 8:54 AM

The idea was to only show the dialog once we have made IP Info permissions equal to IP reveal, as part of T375086: Bring IP Info access permissions to parity with the IP Reveal feature. Therefore, the idea is that a user would always have both rights when seeing the dialog. However, that won't necessarily be the case for third-party wikis and I wonder if we should hide the step entirely if the user does not have IP Info access?

Actually, looking again at the content of the step, it does not appear to imply the user has the ability to use the tool. The only part of the step that does this is the preference. Therefore, I think we can fix this by removing the preference if the user cannot set it per the task description.

Dreamy_Jazz claimed this task.Feb 28 2025, 11:52 AM

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)).

Change #1123632 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] IP reveal onboarding: Hide IPInfo preference if user lacks right

https://gerrit.wikimedia.org/r/1123632

gerritbot added a project: Patch-For-Review.Feb 28 2025, 12:33 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.Feb 28 2025, 12:34 PM

Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Feb 28 2025, 5:52 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Team (Engineering); removed Trust and Safety Product Team.

Change #1123632 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IP reveal onboarding: Hide IPInfo preference if user lacks right

https://gerrit.wikimedia.org/r/1123632

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.Feb 28 2025, 6:42 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.19; 2025-03-04).Feb 28 2025, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2025, 7:30 PM

Dreamy_Jazz moved this task from Sprint Hurdy-Gurdy (Feb 10 - Feb 28) to Sprint Lemon Meringue (March 3 - 21) on the Trust and Safety Product Sprint board.Mar 3 2025, 3:44 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Lemon Meringue (March 3 - 21)); removed Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)).

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Lemon Meringue (March 3 - 21)) board.

kostajh moved this task from Engineering to Engineering on the Trust and Safety Product Team board.Mar 10 2025, 12:44 PM

kostajh edited projects, added Trust and Safety Product Team; removed Trust and Safety Product Team (Engineering).

QA is completed, I have verified the new code has been implemented and is functioning as expected (When user doesn't have the IP Info Rights, they will not be presented with the Enable IP Information checkbox during the Temporary Accounts Onboarding Dialog).

kostajh closed this task as Resolved.Mar 15 2025, 10:46 AM

IP reveal guidance dialog: Do not show IPInfo checkbox if user does not have appropriate IPInfo rightsClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions