Page MenuHomePhabricator
Create Task
Maniphest T387560

[VE WikifunctionsCall]: Add tests to VE integration
Closed, ResolvedPublic
Actions

Description

Description

Unit testing:

  • ext.wikilambda.app:
    • ext.wikilambda.app/mixins/api.js (with foreign api)
    • ext.wikilambda.app/store/stores/library.js (getDescription and lookupFunctions)
    • ext.wikilambda.app/store/stores/router.js (getWikilambdaConfig)
    • ext.wikilambda.app/store/stores/visualeditor.js
    • ext.wikilambda.app/components/visualeditor/FunctionCallSetup.vue
    • ext.wikilambda.app/components/visualeditor/FunctionSelect.vue
    • ext.wikilambda.app/components/visualeditor/FunctionInputSetup.vue
    • Remove ignore paths from jest.config.js
  • ext.wikilambda.visualeditor
    • Increase coverage threshold in jest.config.js

Integration testing:

  • ext.wikilambda.visualeditor

Selenium testing:

  • Visual Editor: add function call
  • Visual Editor: edit function call

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add missing VisualEditor test for ExpandableDescription componentmediawiki/extensions/WikiLambdamaster+71 -0
VisualEditor: Add unit tests to VisualEditor integrationmediawiki/extensions/WikiLambdamaster+777 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Feb 28 2025, 12:23 PM
gengh added a parent task: T373118: Implement initial integration of WF call nodes with VisualEditor.
gengh moved this task from To Triage to 25Q3 (Jan–Mar) on the Abstract Wikipedia team board.Mar 4 2025, 4:44 PM
gengh edited projects, added Abstract Wikipedia team (25Q3 (Jan–Mar)); removed Abstract Wikipedia team.
gengh moved this task from Incoming to Ready, Quarterly Work on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
gengh added a project: Wikifunctions integration.
Jdforrester-WMF triaged this task as Medium priority.Mar 10 2025, 6:17 PM
Jdforrester-WMF renamed this task from [VE WikifunctionsCall]: Add tests to VE integraton to [VE WikifunctionsCall]: Add tests to VE integration.Mar 11 2025, 2:02 PM
gerritbot added a comment.Mar 20 2025, 2:49 PM

Change #1129848 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] VisualEditor: Add unit tests to VisualEditor integration

https://gerrit.wikimedia.org/r/1129848

gerritbot added a project: Patch-For-Review.Mar 20 2025, 2:49 PM
DSmit-WMF updated the task description. (Show Details)Mar 20 2025, 4:57 PM
DSmit-WMF updated the task description. (Show Details)Mar 24 2025, 8:42 AM
gengh changed the task status from Open to In Progress.Mar 25 2025, 3:33 PM
gengh moved this task from Ready, Quarterly Work to In Engineering on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
DSantamaria assigned this task to DSmit-WMF.Mar 25 2025, 4:13 PM
DSmit-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Mar 26 2025, 1:55 PM
gerritbot added a comment.Mar 28 2025, 6:42 PM

Change #1129848 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] VisualEditor: Add unit tests to VisualEditor integration

https://gerrit.wikimedia.org/r/1129848

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 28 2025, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 28 2025, 7:31 PM
DSmit-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Mar 31 2025, 2:31 PM
DSmit-WMF moved this task from Ready to deploy to Ready, Quarterly Work on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
gerritbot added a comment.Apr 3 2025, 7:29 AM

Change #1133805 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Add missing VisualEditor test for ExpandableDescription component

https://gerrit.wikimedia.org/r/1133805

gerritbot added a project: Patch-For-Review.Apr 3 2025, 7:29 AM
gerritbot added a comment.Apr 4 2025, 5:39 PM

Change #1133805 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add missing VisualEditor test for ExpandableDescription component

https://gerrit.wikimedia.org/r/1133805

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.24; 2025-04-08); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Apr 4 2025, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 4 2025, 6:31 PM
Jdforrester-WMF closed this task as Resolved.Apr 8 2025, 8:13 PM
Jdforrester-WMF moved this task from Ready, Quarterly Work to Needs Sign-off on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
Jdforrester-WMF subscribed.

I think this is sufficiently done. Adding brower testing later is a nice-to-have, but doesn't block release.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits