Page MenuHomePhabricator

Migrate LoggingHelper.php methods to statslib
Closed, ResolvedPublic

Description

As part of T359246, this task is specifically for LoggingHelper.php within MediaWiki.wikibase.quality.constraints.

Follow the migration process as outlined below.

  • Secure/Conduct a code review.
  • Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
  • Verify that the changes have been successfully implemented.
  • Update the dashboard by replacing the old Graphite metric with the new Prometheus metric.

Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

Event Timeline

Change #1123671 had a related patch set uploaded (by Andrew McAllister (WMDE); author: Andrew McAllister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] T387562 T387563 Migrate LoggingHelper and CheckConstraints Bug: T387562 T387563

https://gerrit.wikimedia.org/r/1123671

Change #1123671 had a related patch set uploaded (by Andrew McAllister (WMDE); author: Andrew McAllister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] T387562 T387563 Migrate LoggingHelper and CheckConstraints

https://gerrit.wikimedia.org/r/1123671

Moving to In Progress to fix the merge conflicts.

Back to In Review as merge conflicts are fixed and tests are again passing.

Change #1123671 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] T387562 T387563 Migrate LoggingHelper and CheckConstraints

https://gerrit.wikimedia.org/r/1123671