Page MenuHomePhabricator
Create Task
Maniphest T387590

Messages boxes on special pages using Codex without associated style pack will be unstyled
Closed, ResolvedPublicBUG REPORT
Actions

Description

NOTE: I'm planning this change at end of March, so please review this issue and fix this before then!! Thanks in advance!

Steps to replicate the issue (include links if applicable):

What happens?:

Message boxes are not styled

What should have happened instead?:

Styles for message boxes need to be added explicitly

For example this call to Html::errorBox should also include a call to OutputPage::addModuleStyles('mediawiki.codex.messagebox.styles') or ideally via CodexModule.

https://gerrit.wikimedia.org/g/mediawiki/extensions/CampaignEvents/+/33d6f39fb0a05ec96b06334126ae06f97faca922/src/Special/ChangeRegistrationSpecialPageBase.php#142

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add Codex MessageBox styles to all special pagesmediawiki/extensions/CampaignEventsmaster+29 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson-WMF created this task.Feb 28 2025, 7:43 PM
Jdlrobson-WMF updated the task description. (Show Details)
gerritbot added a comment.Feb 28 2025, 7:45 PM

Change #1123708 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/CampaignEvents@master] Add Codex MessageBox styles to all special pages

https://gerrit.wikimedia.org/r/1123708

gerritbot added a project: Patch-For-Review.Feb 28 2025, 7:45 PM
gerritbot added a comment.Mar 3 2025, 7:27 PM

Change #1123708 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add Codex MessageBox styles to all special pages

https://gerrit.wikimedia.org/r/1123708

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2025, 7:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.19; 2025-03-04).Mar 3 2025, 8:00 PM
Daimona assigned this task to Jdlrobson-WMF.Mar 3 2025, 8:45 PM
Daimona added a project: Connection-Team (Connection-Current-Sprint).
Daimona moved this task from Upcoming / refining 💡 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.
Daimona added subscribers: vaughnwalters, Daimona.Mar 3 2025, 8:49 PM

@vaughnwalters I'm moving this to QA in case you'd like to have a quick look. I think I've already verified all the relevant pages manually though, so I'll leave it up to you whether you think a second pair of eyes is needed.

vaughnwalters closed this task as Resolved.Mar 7 2025, 11:46 PM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.
In T387590#10598191, @Daimona wrote:

@vaughnwalters I'm moving this to QA in case you'd like to have a quick look. I think I've already verified all the relevant pages manually though, so I'll leave it up to you whether you think a second pair of eyes is needed.

I looked at Special:EventDetails, Special:DeleteEventRegistration or Special:EditEventRegistration on Timeless, Monobook, and legacy Vector and it looks good to me as well. Marking as done / resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits