Page MenuHomePhabricator
Create Task
Maniphest T387638

PHP Notice: Trying to access array offset on value of type null (via API RevisionDelete)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to access array offset on value of type null
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiRevisionDelete.php(122)
#0/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiRevisionDelete.php(122)MWExceptionHandler::handleError(int, string, string, int, array)
#1/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(2012)MediaWiki\Api\ApiRevisionDelete->execute()
#2/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#3/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#4/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#5/srv/mediawiki/php-1.44.0-wmf.18/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#6/srv/mediawiki/php-1.44.0-wmf.18/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#7/srv/mediawiki/w/api.php(3)require(string)
#8{main}
Impact
Notes

Details

Request URL
https://en.wikipedia.org/w/api.php
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
RevDelList: Ensure setVisibility always includes itemStatuses in value if applicableReedymediawiki/coreREL1_43+5 -4
RevDelList: Ensure setVisibility always includes itemStatuses in value if applicableReedymediawiki/coreREL1_42+5 -4
RevDelList: Ensure setVisibility always includes itemStatuses in value if applicableReedymediawiki/coreREL1_39+5 -4
RevDelList: Ensure setVisibility always includes itemStatuses in value if applicableReedymediawiki/coremaster+5 -4
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Mar 1 2025, 10:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2025, 10:29 PM
Reedy added a comment.Mar 1 2025, 10:39 PM
Error
normalized_message
[{reqId}] {exception_url}   Error: Unsupported operand types
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiRevisionDelete.php(129)
#0/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(2012)MediaWiki\Api\ApiRevisionDelete->execute()
#1/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#2/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#3/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#4/srv/mediawiki/php-1.44.0-wmf.18/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#5/srv/mediawiki/php-1.44.0-wmf.18/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#6/srv/mediawiki/w/api.php(3)require(string)
#7{main}
Impact
Notes
Reedy added a comment.Mar 1 2025, 10:40 PM
Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined offset: 20250221082032
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiRevisionDelete.php(129)
#0/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiRevisionDelete.php(129)MWExceptionHandler::handleError(int, string, string, int, array)
#1/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(2012)MediaWiki\Api\ApiRevisionDelete->execute()
#2/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#3/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#4/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#5/srv/mediawiki/php-1.44.0-wmf.18/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#6/srv/mediawiki/php-1.44.0-wmf.18/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#7/srv/mediawiki/w/api.php(3)require(string)
#8{main}
Impact
Notes
Reedy added a comment.Mar 1 2025, 10:40 PM
Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: Invalid argument supplied for foreach()
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiRevisionDelete.php(122)
#0/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiRevisionDelete.php(122)MWExceptionHandler::handleError(int, string, string, int, array)
#1/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(2012)MediaWiki\Api\ApiRevisionDelete->execute()
#2/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#3/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#4/srv/mediawiki/php-1.44.0-wmf.18/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#5/srv/mediawiki/php-1.44.0-wmf.18/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#6/srv/mediawiki/php-1.44.0-wmf.18/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#7/srv/mediawiki/w/api.php(3)require(string)
#8{main}
Impact
Notes
Reedy merged a task: T387641: PHP Notice: Undefined offset: 20250221082032.Mar 1 2025, 10:40 PM
Pppery added a project: MediaWiki-Revision-deletion.Mar 1 2025, 10:56 PM
Pppery renamed this task from PHP Notice: Trying to access array offset on value of type null to PHP Notice: Trying to access array offset on value of type null (via API RevisionDelete).Mar 1 2025, 11:42 PM
Reedy added a comment.Mar 1 2025, 11:44 PM

Not blaming rMWe6f4dc96fe79: revisiondelete: Replace dynamic property Status::$itemStatuses, but the code last touched in that

Reedy added projects: MW-1.42-release, MW-1.43-release.EditedMar 1 2025, 11:54 PM

So if a return early happens...

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+blame/refs/heads/wmf/1.44.0-wmf.18/includes/revisiondelete/RevDelList.php#151

	151			$status->merge( $this->acquireItemLocks() );
	152			if ( !$status->isGood() ) {
	153				return $status;
	154			}

itemStatuses hasn't been set - https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+blame/refs/heads/wmf/1.44.0-wmf.18/includes/revisiondelete/RevDelList.php#170

Brad Jorsch	9832b28	2013-06-26 16:59:40 -0400	[diff] [blame]	170			if ( $perItemStatus ) {
Umherirrender	e6f4dc9	2023-01-07 21:38:34 +0100	[diff] [blame]	171				$status->value['itemStatuses'] = [];
Brad Jorsch	9832b28	2013-06-26 16:59:40 -0400	[diff] [blame]	172			}

Should the caller expect that it is defined if we pass 'perItemStatus' => true, - https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+blame/refs/heads/wmf/1.44.0-wmf.18/includes/api/ApiRevisionDelete.php#113 that is defined in the (return) value? Or should they be checking that it is set/something similar to the !$status->isGood() that caused the early return? Though in the latter case, something else may happen later to cause the status to not be good anyway...

gerritbot added a comment.Mar 2 2025, 12:02 AM

Change #1123774 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] RevDelList: Ensure setVisibility always includes itemStatuses in value if applicable

https://gerrit.wikimedia.org/r/1123774

gerritbot added a project: Patch-For-Review.Mar 2 2025, 12:02 AM
Reedy moved this task from Untriaged to Mar 2025 on the Wikimedia-production-error board.Mar 2 2025, 10:20 PM
gerritbot added a comment.Mar 8 2025, 1:23 AM

Change #1123774 merged by jenkins-bot:

[mediawiki/core@master] RevDelList: Ensure setVisibility always includes itemStatuses in value if applicable

https://gerrit.wikimedia.org/r/1123774

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2025, 1:30 AM
gerritbot added a comment.Mar 8 2025, 1:53 AM

Change #1125572 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_43] RevDelList: Ensure setVisibility always includes itemStatuses in value if applicable

https://gerrit.wikimedia.org/r/1125572

gerritbot added a project: Patch-For-Review.Mar 8 2025, 1:53 AM

Change #1125573 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_42] RevDelList: Ensure setVisibility always includes itemStatuses in value if applicable

https://gerrit.wikimedia.org/r/1125573

gerritbot added a comment.Mar 8 2025, 1:54 AM

Change #1125574 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] RevDelList: Ensure setVisibility always includes itemStatuses in value if applicable

https://gerrit.wikimedia.org/r/1125574

Reedy closed this task as Resolved.Mar 8 2025, 1:54 AM
Reedy claimed this task.
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 8 2025, 2:00 AM
gerritbot added a comment.Mar 8 2025, 7:09 PM

Change #1125574 merged by jenkins-bot:

[mediawiki/core@REL1_39] RevDelList: Ensure setVisibility always includes itemStatuses in value if applicable

https://gerrit.wikimedia.org/r/1125574

gerritbot added a comment.Mar 8 2025, 7:14 PM

Change #1125573 merged by jenkins-bot:

[mediawiki/core@REL1_42] RevDelList: Ensure setVisibility always includes itemStatuses in value if applicable

https://gerrit.wikimedia.org/r/1125573

gerritbot added a comment.Mar 8 2025, 7:15 PM

Change #1125572 merged by jenkins-bot:

[mediawiki/core@REL1_43] RevDelList: Ensure setVisibility always includes itemStatuses in value if applicable

https://gerrit.wikimedia.org/r/1125572

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2025, 7:30 PM
ReleaseTaggerBot added projects: MW-1.39-notes, MW-1.42-notes, MW-1.43-notes.Mar 8 2025, 8:00 PM
Krinkle moved this task from Mar 2025 to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits