Page MenuHomePhabricator

Remove address fields for ACH in checkout flow
Closed, ResolvedPublic

Description

From Trustly: we noticed some areas to improve conversion and adoption for ACH. Where the user fills out their billing address before even launching the Trustly flow — we can actually auto-populate that at the end and go right into the bank log-in screen, so there is no need to manually input this information. Removing this step would have a big impact on conversion.

Event Timeline

Confirmed with trustly that if donor info is available in the users bank account profile, they can provide that with webhook, waiting for "Brant Partington" to provide more details about the webhook, could do this similar as we did for venmo not getting donor info right, and fetch it afterward. So remove address zipcode and firstname lastname from our payment form for trustly https://wikimedia.slack.com/archives/D08FW616XGD/p1741044448966599

Change #1124180 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Remove address fields for ACH in checkout flow

https://gerrit.wikimedia.org/r/1124180

Confirmed from Phillip we will not handle the api from Trustly, but get the payer detail from auth response as we did in paypal. While they do not have this api integrated on gravy end (brant said it cost extra money, so still in discussion with marc and Christine), we will unblock after they have this info in response ready.

Change #1124180 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Remove address fields for ACH in checkout flow

https://gerrit.wikimedia.org/r/1124180

Change #1144575 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] Remove address fields on for Gravy ACH(Trustly) form

https://gerrit.wikimedia.org/r/1144575

Change #1144575 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Remove address fields on for Gravy ACH(Trustly) form

https://gerrit.wikimedia.org/r/1144575

Change #1147830 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Do not check first and last name for validation

https://gerrit.wikimedia.org/r/1147830

Change #1147830 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Do not check first and last name for validation

https://gerrit.wikimedia.org/r/1147830

I tested the ACH flow since this merge and ACH /Trustly is no longer working on Donate wiki @AnnWF . Also, I see it is still requiring the email field. Can this also be removed{F60250084}

Change #1147847 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] do not check email for ach too

https://gerrit.wikimedia.org/r/1147847

Yes we can do that since trustly also return email address back

Change #1147847 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] do not check email for ach too

https://gerrit.wikimedia.org/r/1147847

@AnnWF Wenjun, thanks for removing the email. Looks good. Unfortunately, when I seek to log in to my bank account I get this error:

image.png (367×1 px, 44 KB)

Yeah I will need to put both email and name back first, local sandbox works well with no email name address, but prod is complaining about no email and no firstname last name. Will do a follow up today, but revert the removal first to check address only at prod.

Change #1147865 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Add back name and email for prod error

https://gerrit.wikimedia.org/r/1147865

Change #1147886 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/SmashPig@master] Separate out ach validation for gravy

https://gerrit.wikimedia.org/r/1147886

Change #1147897 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] revert name and email for ach

https://gerrit.wikimedia.org/r/1147897

Change #1147897 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] revert name and email for ach

https://gerrit.wikimedia.org/r/1147897

Change #1147886 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Separate out ach validation for gravy

https://gerrit.wikimedia.org/r/1147886

@AnnWF Hi Wenjun, I just retried and the fields are gone but I cannot proceed with the transaction. Same error:

image.png (390×1 px, 45 KB)

Hi @EMartin your ip is been blocked, could you ask @Jgreen or Dallas (might ooo) to get your ip out of jail? Thanks!

@AnnWF I have been able to test alas and see this is working.