Page MenuHomePhabricator
Create Task
Maniphest T387838

Latest revisions should never be tagged as reverted
Closed, ResolvedPublicBUG REPORT
Actions

Description

Example: https://cs.wikipedia.org/w/index.php?diff=24717367&uselang=en.

As of now, it is the latest (top) revision of the page, yet it is tagged with "Reverted". By definition, revision followed by no newer revision cannot be reverted.

Possible cause: someone clicked "rollback", but no revision was made because we do not save "dummy" revisions for rollbacks.

Could it be a regression from T386938?

Original report: https://cs.wikipedia.org/wiki/Wikipedie:Pod_l%C3%ADpou_(technika)#c-David_V.-20250304091300-Zna%C4%8Dka_%E2%80%9Erevertov%C3%A1no%E2%80%9C

Related:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Do not enqueue RevertedTagUpdateJob for null editsmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Mar 4 2025, 9:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2025, 9:40 AM
Pppery edited projects, added MediaWiki-Patrolling, MediaWiki-Change-tagging; removed MediaWiki-General.Mar 8 2025, 6:11 PM
gerritbot added a comment.Mar 9 2025, 5:07 PM

Change #1125640 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/core@master] Do not enqueue RevertedTagUpdateJob for null edits

https://gerrit.wikimedia.org/r/1125640

gerritbot added a project: Patch-For-Review.Mar 9 2025, 5:07 PM
matmarex subscribed.Mar 11 2025, 9:19 PM

I found a way to reproduce this:

  1. As user A, make an edit to an existing page
  2. As user A, undo your own edit
  3. As user B, try to rollback user A's edits

This will result in no edit by user B being saved, since there's no change, and tag both of user A's edits as reverted.

The patch fixes this scenario.

gerritbot added a comment.Mar 11 2025, 9:44 PM

Change #1125640 merged by jenkins-bot:

[mediawiki/core@master] Do not enqueue RevertedTagUpdateJob for null edits

https://gerrit.wikimedia.org/r/1125640

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 11 2025, 10:00 PM
matmarex closed this task as Resolved.Mar 11 2025, 10:02 PM
matmarex assigned this task to matej_suchanek.

The fix will be deployed to Wikimedia wikis next week, on the usual schedule. Thanks @matej_suchanek!

matmarex added a comment.Mar 11 2025, 10:02 PM

(btw this was also reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Mw-Reverted_tag_on_newest_revision today)

matej_suchanek updated the task description. (Show Details)Mar 11 2025, 10:05 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 10:30 PM
Myrealnamm subscribed.Mar 15 2025, 9:08 PM

Though now closed, just FYI another issue that may be related but may be fixed in the deployment, we'll see:

https://en.wikipedia.org/w/index.php?title=Wikipedia:Articles_for_deletion/Suicidal-Idol&diff=prev&oldid=1280676318

The next two "edits" after the edit by CFA were page protections, one not an actual edit, and the other one adds the pp-protected padlock, but edit by CFA is marked as "reverted".

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits