Page MenuHomePhabricator
Create Task
Maniphest T387889

Use lexeme-search limiting to optimize Z6830/Find lexemes for a Wikidata item
Closed, ResolvedPublic
Actions

Description

Description

When the work on T271776 has been completed, use the inlanguage keyword to optimize Z6830/Find lexemes for a Wikidata item (T383631). It will completely eliminate a fetch call to Wikidata action API wbgetentities (which in some cases retrieves > 200 lexemes), for each call to Z6830. This will be a coding change in fetchObject.js.

When T387235 has been completed, this optimization should also be applied there.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • Execution time for calls to Z6830 is expected to be cut in half, or better.

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Update orchestrator from 2025-03-05-140247 to 2025-03-11-234105operations/deployment-chartsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

DMartin-WMF created this task.Mar 4 2025, 4:39 PM
DMartin-WMF removed projects: WikiLambda, function-schemata, function-evaluator.Mar 4 2025, 4:43 PM
Jdforrester-WMF triaged this task as Medium priority.Mar 5 2025, 5:38 PM
Jdforrester-WMF added a subtask: T271776: Allow limiting lexeme searches by language.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q3 (Jan–Mar)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Essential work on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
DMartin-WMF claimed this task.Mar 6 2025, 10:50 PM
DMartin-WMF moved this task from Essential work to In Engineering on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
CodeReviewBot added a project: Patch-For-Review.Mar 10 2025, 2:12 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/306

Draft: Use inlanguage parameter to optimize Z6830/Find lexemes for a Wikidata item

DSantamaria changed the task status from Open to In Progress.Mar 10 2025, 6:28 AM
DMartin-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Mar 11 2025, 4:55 AM
CodeReviewBot added a comment.Mar 11 2025, 6:04 AM

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/306

Use inlanguage parameter to optimize Z6830/Find lexemes for a Wikidata item

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 6:30 AM
Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Mar 11 2025, 1:53 PM
gerritbot added a comment.Mar 12 2025, 1:18 PM

Change #1126996 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-05-140247 to 2025-03-11-234105

https://gerrit.wikimedia.org/r/1126996

gerritbot added a project: Patch-For-Review.Mar 12 2025, 1:18 PM
gerritbot added a comment.Mar 12 2025, 2:22 PM

Change #1126996 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-05-140247 to 2025-03-11-234105

https://gerrit.wikimedia.org/r/1126996

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Mar 12 2025, 2:30 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 12 2025, 2:33 PM
DMartin-WMF added a comment.Mar 12 2025, 5:25 PM

As expected, this optimization has yielded a significant speed-up. Previously calls to Z6830 were averaging around one second; now they are averaging around 200 ms. (This is from observing a handful of curl calls to the orchestrator API, from production deployment server.)

DMartin-WMF closed this task as Resolved.Mar 12 2025, 5:33 PM
dcausse closed subtask T271776: Allow limiting lexeme searches by language as Resolved.Aug 28 2025, 2:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits