I've updated the task description to include the choices we made offline this week.

Most notably, we decided that – to start – on desktop people who 1) do not engage with Peacock Check Mid-Edit and 2) elect Revise in the Peacock Check card that will be presented to them Pre-Save will be taken into the full VE surface to edit the text they'd written.

We made this choice with the following in mind:

1. Creating a new, more-focused editing mode, involves non-trivial technical complexity
2. Bringing people "back" to the editable surface could cause people to become confused overwhelmed

We felt comfortable risking "#2":

1. Thinking it's important for us to try out the lightest weight approach to start and
2. Knowing if/when we come to find this lightweight approach insufficient, we'll arrive back to the unmet UX goals with added conviction in the need to take on the technical complexity that could come with introducing a new mode within Edit Check

Update: 10 March
Per what @Esanders and I discussed offline today...

• Mobile and desktop will share the same "Revisit (Pre-Save)" UX for now
  • Meaning, upon landing back into Mid-Edit from Pre-Save, the Mid-Edit experience will remain as it is currently. Read: text will be highlighted, on desktop, Peacock Card will be expanded, and other Checks have the potential of appearing if any are left unaddressed. We're going to defer the work of potentially excluding Checks that only show pre-save (e.g. Reference Check) for now...

I've updated the task description in T387901#10621481 to reflect the above.

Feedback: demo: 2e4d6c7a2d

• Deactivate the "convert" checks that activate immediately upon arriving into the editor
• Ensure that when you add peacock language to a paragraph that prompts the "puffery" dialog to appear, the paragraph is highlighted
  • At present, only the vertical bar appears
• Ensure the "revise" button is functional in mid-edit
  • At present, tapping the "revise" button in the mid-edit moment appears to have no effect
• Ensure this experience works well on mobile
  • E.g. integrates with the work @DLynch has been doing on the mobile "gutter"
• Integrate the focusing/defocusing work @Zoë implemented

E.g. integrates with the work @DavidL has been doing on the mobile "gutter"

not me, but probably DLynch ?

In T387901#10638427, @DavidL wrote:

E.g. integrates with the work @DavidL has been doing on the mobile "gutter"

not me, but probably DLynch ?

Shoot, yes! I'm sorry about that, @DavidL...

Update

Last week, @Esanders and I shared the first iteration of the PoC during design review.

While the feedback designers offered helpfully touched on all facets of the experience, the broader message we gleaned from this session was the following

There are enough rough edges within the experience to make it difficult for us to assess the viability of this approach to the Peacock Check experience.

With the above in mind, we're going to prioritize the adjustments listed below.

With these adjustments implemented, we'll then take another step back and invite staff and volunteers to review the experience.

Adjustments

Awareness + Understanding (Mid-Edit): people are aware of what they have done/are doing that needs their attention and why…

• REVISE title of Check card to read "Review tone" instead of "Puffery"
• 🚧 [not now] LIMT highlight to specific word(s)/phrase(s) that need attention
  • NOTE: T389434 needs to be resolved to determine the feasibility of doing this!!
• 🚧 REVISE Check card copy to read as follows...
  • @ppelberg to specify copy that could cause people to think, "Oh, if I care about this edit being published, I should listen!" (and also include a way for people to "Learn more")

Action (Mid-Edit): people are equipped with the tool(s)/affordance(s) to neutralize the tone of what they've written or explicitly decide not to and express why

• REVISE check dialog button copy from Revise → Edit and Dismiss → Keep
• REVISE what happens when you tap "Revise" mid-edit
  • Approach #1: Place cursor at the beginning of highlighted range, remove highlight, and replace with a border around the entire range (similar to what we do when focus is placed within nodes like links)
    • NOTE: @Esanders indicated that before we pursue this approach, we'd first need to think through how this would apply to other Checks
  • Approach #2: @Esanders can you think of an alternative to "#1" that could be effective at helping people A) quickly locate the cursor within the document and B) understanding the range of text that they're being asked to edit?
• ADJUST sidebar so that the appearance of a Mid-Edit Check does not cause the page to reflow
  • Approach #1 Preserve enough space for Edit Checks cards – as currently designed – to appear without causing reflow
  • Approach #2: Offer a gutter-sidebar experience similar to what is shown on mobile and preserve enough space for an Edit Check to appear within it without the page needing to be reflowed/resized in anyway
    • We're going to start with this approach
  • Approach #3 Make Edit Check Cards/Hints dynamic and capable of adapting to the amount of white space available (might still cause reflow)
    • We might consider pursuing this approach as an extension to "Approach #2"
  • Approach #4: Do not show any sidebar at all (or only show a gutter-sidebar like on mobile), and instead cause check to appear through some other interaction (e.g., on hover, the sidebar pulls out over the edit surface)

Revisit (Pre-Save): people are reminded to engage with Peacock Checks they did not address in the Mid-Edit moment.

• ENSURE that upon progressing to Pre-Save moment, sentence(s) with unaddressed Peacock Check issues are shown at the top of the viewport with the Check right alongside it
• ENSURE article scrolls as you navigate between Checks

Address Check (Pre-Save → Mid-Edit): people electing to address a skipped Check can do so with focus and ease

• REVISE Check card copy to acknowledge the unique moment (skip and then decide to address)
  • @ppelberg to propose copy that equips people with the guidance they will need to successfully "neutralize" the tone of what they've written
• REVISE what happens when you tap Edit
  • See above

In T387901#10654944, @ppelberg wrote:

• ADJUST sidebar so that the appearance of a Mid-Edit Check does not cause the page to reflow
  • Approach #2: Offer a gutter-sidebar experience similar to what is shown on mobile and preserve enough space for an Edit Check to appear within it without the page needing to be reflowed/resized in anyway

WIP from @DLynch: https://patchdemo.wmcloud.org/wikis/85aaed0085/w/index.php?title=Douglas_Adams&veaction=edit