Page MenuHomePhabricator

Ensure release script does not produce un-tracked files in repo
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Background

With update of Style Dictionary to v4.n.n. in the build scripts, we've also updated 'rimraf' (a cross-platform implementation of rm -rf recursively forceful file removal) from v3 to v6.
While our build script remained with same output as before, we ended up with undeleted token files with 'prepare-release.sh' shell script.
The git bisect was showing the cause being in the 'rimraf' package update.

Goal

Ensure the prepare release shell script provides output as expected without the theme files being in the root folder of codex-design-tokens package after execution

Acceptance Criteria

  • No 'packages/codex-design-tokens/theme-*.*' files after the prepare release shell script is executed

Related Objects

Event Timeline

Volker_E set the point value for this task to 1.Mar 4 2025, 7:23 PM

Change #1124508 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] build: Add `--glob` flag to 'rimraf' command

https://gerrit.wikimedia.org/r/1124508

egardner renamed this task from build: Ensure build script to build: Ensure release script does not produce un-tracked files in repo.Mar 4 2025, 7:40 PM
egardner renamed this task from build: Ensure release script does not produce un-tracked files in repo to bug: Ensure release script does not produce un-tracked files in repo.
egardner renamed this task from bug: Ensure release script does not produce un-tracked files in repo to Ensure release script does not produce un-tracked files in repo.
egardner triaged this task as High priority.
egardner changed the subtype of this task from "Task" to "Bug Report".

Change #1124508 merged by jenkins-bot:

[design/codex@main] build: Add `--glob` flag to 'rimraf' command

https://gerrit.wikimedia.org/r/1124508

Change #1124526 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.20.2 to v1.20.3

https://gerrit.wikimedia.org/r/1124526

Change #1124526 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.20.2 to v1.20.3

https://gerrit.wikimedia.org/r/1124526

Test wiki on Patch demo by LWatson-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/1f500859d0/w/