Page MenuHomePhabricator
Create Task
Maniphest T387917

Migrate mw-script to PHP 8.1
Closed, ResolvedPublic
Actions

Description

Timeline:

  • Decouple mwscript-k8s MediaWiki image selection from mw-web.
  • Support PHP version selection in mwscript-k8s
  • Announce upcoming change to default to PHP 8.1 (2025-03-26)
  • Update https://wikitech.wikimedia.org/wiki/Maintenance_scripts to highlight the PHP default version change and fallback
  • Change default PHP version to 8.1 with fallback option to 7.4 (2025-04-02)

Implementation notes:

Currently, the mwscript-k8s tool determines which mediawiki image to use by simply following the one used by mw-web/main.

While that works, there's one caveat in the context of the 8.1 migration: If we take no action, when mw-web/main is converted to 8.1 in the near future, all mwscript-k8s use cases will implicitly be migrated as well. That's less than ideal.

I was chatting with @RLazarus the other day, and we discussed a more structured migration, where there will in the future be a (advertised) day where mwscript-k8s invocations switch to 8.1 by default, but with an escape hatch for users that experience issues with their scripts: a command-line flag to revert to a 7.4-based image. There would then be a later date when the flag is removed.

Achieving this would require decoupling the tool from mw-web/main. One idea for doing that would be to imbue scap with a notion of non-deploy helmfile releases - i.e., scap is only responsible for maintaining the files in /etc/helmfile-defaults/mediawiki/release, but does not attempt to "actuate" (e.g., helmfile apply) a deployment.

We could then configure 7.4- and 8.1- associated non-deploy releases in the mw-script namespace, whose release-values files would instead be consumed by the tool.

This could be broadly useful for other "asynchronous deployment" use cases that want to follow (by some other mechanism) the latest deployed images, and intersects a bit with some of the discussion in T375497 around when new image versions are "published" to /etc/helmfile-defaults/mediawiki/release.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
deployment_server: Default to PHP 8.1 in mwscript-k8soperations/puppetproduction+18 -4
deployment_server: Support PHP version selection in mwscript-k8soperations/puppetproduction+22 -7
deployment_server: Use mw-script release values fileoperations/puppetproduction+8 -8
hieradata: add mw-script non-deploy releases to mw_releasesoperations/puppetproduction+10 -0
Profile::Mediawiki_deployment: add 'deploy' field to release configoperations/puppetproduction+11 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT396296 Upgrade symfony/* to PHP 8.1 versions
 ResolvedReedyT373753 Drop symfony/polyfill-php 73-81 from mediawiki-vendor
 StalledNoneT255792 Quibble runs core:unit tests twice!
 OpenNoneT232915 Red-green in PHPUnit code coverage are hard to read
 OpenNoneT376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
 OpenNoneT379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
 ResolvedReedyT378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
 ResolvedKrinkleT358666 Drop PHP 8.1 support from MediaWiki
 ResolvedKrinkleT360995 Migrate Wikimedia production from PHP 8.1 to PHP 8.3
 ResolvedJdforrester-WMFT353362 Make PHP 8.3 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
 ResolvedJdforrester-WMFT352085 Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
 ResolvedJdforrester-WMFT360560 Make PHP 8.2 voting on development branch of Wikibase
 ResolvedLucas_Werkmeister_WMDET324202 Remove use of utf8_encode and utf8_decode in Wikibase
 ResolvedNoneT353161 [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated
 ResolvedJdforrester-WMFT360709 Make PHP 8.2 voting on development (master) branch of Math extension
 ResolvedDaimonaT381728 Use PHP 8.3 in MediaWiki-Docker
 ResolvedJdforrester-WMFT398491 Move CI images to WMF PHP 8.3 packages
 DeclinedNoneT401255 Switch PHP 8.3 image of MediaWiki-Docker from Sury to WMF
 ResolvedScott_FrenchT401254 Upgrade mw-debug/next to PHP 8.3
 ResolvedScott_FrenchT401252 Configure title-case consistency mapping for PHP 8.1 -> 8.3 transition
 ResolvedScott_FrenchT399884 Configure production MediaWiki image builds for PHP 8.3
 ResolvedcscottT401855 ☂ PHP 8.3 issues found during WMF rollout
 ResolvedScott_FrenchT402424 PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /srv/monitoring/lib.php on line 99
 DuplicatePRODUCTION ERRORNoneT403514 Expectation (readQueryRows <= 10000) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: 12860)
 ResolvedPRODUCTION ERRORMichaelT407403 Error: Invalid serialization data for DatePeriod object
 ResolvedPRODUCTION ERRORMichaelT408852 PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated
 ResolvedMichaelT401005 Investigate Production Errors from ComputedUserImpactLookup::getPageViewData
 DuplicatePRODUCTION ERRORNoneT409248 PHP Warning: Trying to access array offset on null
 ResolvedTgrT402597 Exploratory testing on PHP 8.3 for MediaWiki Platform Team components
 ResolvedNoneT402804 Exploratory testing on PHP 8.3 for MediaWiki authentication stack
 ResolvedDAlangi_WMFT403484 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Login
 ResolvedTgrT403485 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Central session
 ResolvedDAlangi_WMFT403486 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Signup
 ResolvedTgrT403487 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: OAuth
 ResolvedTgrT403488 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: 2FA
 ResolvedAtienoT402809 Exploratory testing on PHP 8.3 for MediaWiki Interfaces Team components
 OpenNoneT402810 Exploratory testing on PHP 8.3 for Content Transform Team components
 ResolvedbrouberolT403110 Prepare dumps-on-k8s (mediawiki-dumps-legacy) for migration to PHP 8.3
 ResolvedScott_FrenchT403655 Configure mw-next-routing for the PHP 8.3 migration
 ResolvedScott_FrenchT403657 Configure the WikimediaEvents extension for the PHP 8.3 migration
 ResolvedScott_FrenchT403284 Migrate production Shellbox services to PHP 8.3
 ResolvedScott_FrenchT403283 Prepare PHP 8.3 service images for Shellbox
 ResolvedScott_FrenchT398246 Prepare PHP 8.3 production images
 ResolvedScott_FrenchT398245 Prepare WMF PHP 8.3 packages for bullseye
 ResolvedKrinkleT400109 Ensure MediaWiki-Core-Profiler works with php-xhprof 2.x (PHP 8.3)
 ResolvedKrinkleT401152 Switch wmf-config/Profiler from Tideways to XHProf
 ResolvedScott_FrenchT403772 Migrate parsoidtest1001 to PHP 8.3
 ResolvedKrinkleT405031 lcobucci/clock needs upgrading for PHP 8.3
 ResolvedTgrT363639 web-auth/webauthn-lib must be upgraded to 4+ for PHP 8.2+ support
 ResolvedScott_FrenchT405955 MediaWiki on PHP 8.3 production workload migration
 ResolvedjnucheT411277 Patchdemo wiki creation fails due to PHP 8.1 not supported by MW
 ResolvedJdforrester-WMFT411372 wikilambda-catalyst-end-to-end broken due to new version of composer after PHP 8.1 -> 8.3 migration
 ResolvedBUG REPORTbd808T411235 Beta cluster scap using php8.1 container; php8.2 is now required
 ResolvedReedyT380185 Prepare for newer geoip2/geoip2 library
 ResolvedReedyT338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
 Resolvedseanleong-WMDET379930 Use WeakMap instead of an array in RestrictedEntityLookupFactory
 StalledNoneT334726 Use return type `never` in Wikibase
 OpenNoneT328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
 ResolvedLucas_Werkmeister_WMDET328741 Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10"
 ResolvedDaimonaT342110 Upgrade to PHPUnit 9.6
 ResolvedDaimonaT342259 Move MediaWikiIntegrationTestCase setup and teardown away from run()
 ResolvedDaimonaT342301 Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking
 OpenNoneT332865 PHPUnit data providers should be simple static functions that return plain data
 ResolvedUmherirrenderT337130 Make PHPUnit dataProvider LexemeFieldTestBase::getTestData static (WikibaseLexemeCirrusSearch extension)
 OpenNoneT337135 Make PHPUnit dataProvider on UstringLibraryTest and LuaEngineUnitTestBase static
 ResolvedUmherirrenderT337144 Make PHPUnit dataProvider static in AbuseFilter tests
 ResolvedUmherirrenderT337155 Make PHPUnit dataProvider static in ReadingLists tests
 Resolved• mszaboT337156 Make PHPUnit dataProvider static in IPInfo tests
 ResolvedtstarlingT337157 Make PHPUnit dataProvider static in LoginNotify tests
 ResolvedUmherirrenderT337158 Make PHPUnit dataProvider static in Flow tests
 ResolvedDreamy_JazzT337159 Make PHPUnit dataProvider static in CheckUser tests
 ResolvedDreamy_JazzT346044 Remove CheckUserUnionQueryBuilder
 ResolvedPhysikerweltT337160 Make PHPUnit dataProvider static in Math tests
 ResolvedTgrT337161 Make PHPUnit dataProvider static in OAuth tests
 ResolvedUmherirrenderT337162 Make PHPUnit dataProvider static in ProofreadPage tests
 ResolvedUmherirrenderT337163 Make PHPUnit dataProvider static in CirrusSearch tests
 ResolvedNoneT337164 Make PHPUnit dataProvider static in FileImporter tests
 ResolvedUmherirrenderT337165 Make PHPUnit dataProvider static in GrowthExperiments tests
 ResolvedNoneT337166 Make PHPUnit dataProvider static in CampaignEvents tests
 ResolvedNoneT371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
 ResolvedkarapayneWMDET337154 Make PHPUnit dataProvider static in Wikibase tests
 ResolvedAudreyPenven_WMDET380604 Make provideLuaData static
 ResolvedAudreyPenven_WMDET380605 Make EntityMetaTagsCreatorTestCase's provideTestGetMetaTags dataProvider static
 ResolvedLucas_Werkmeister_WMDET337153 Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
 ResolvedLucas_Werkmeister_WMDET337151 Make PHPUnit dataProvider static in WikibaseLexeme tests
 ResolvedUmherirrenderT337152 Make PHPUnit dataProvider static in WikibaseMediaInfo tests
 ResolvedthiemowmdeT337150 Make PHPUnit dataProvider static in Wikidata.org tests
 ResolvedLucas_Werkmeister_WMDET337148 Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
 ResolvedUmherirrenderT393065 Make PHPUnit dataProvider on ExtensionJsonTestBase static
 ResolvedUmherirrenderT393079 Make PHPUnit dataProvider static in CommunityConfiguration tests
 ResolvedUmherirrenderT393080 Make PHPUnit dataProvider static in AutoModerator tests
 ResolvedUmherirrenderT393081 Make PHPUnit dataProvider on AbstractChangesListSpecialPageTestCase static
 ResolvedUmherirrenderT393082 Make PHPUnit dataProvider on OutputTransformStageTestBase static
 ResolvedUmherirrenderT393084 Make PHPUnit dataProvider on TypeDefTestCaseTrait static
 Resolved• mszaboT393115 Make PHPUnit dataProvider on PasswordTestCase static
 ResolvedxSavitarT393122 Make PHPUnit dataProvider on BundleSizeTestBase static
 ResolvedUmherirrenderT393132 Make PHPUnit dataProvider on RevisionRecordTests static
 ResolvedUmherirrenderT393207 Make PHPUnit dataProvider on ExtensionServicesTestBase static
 ResolvedUmherirrenderT393219 Make PHPUnit dataProvider on RestStructureTest static
 OpenNoneT410731 Make production extensions PHPUnit tests data providers real providers (and use static methods)
 OpenNoneT345481 Migrate Parser and extension tests away from deprecated PHPUnit TestSuite subclassing
 OpenNoneT358394 Stop using PHPUnit's TestSuite in Scribunto
 OpenDannyS712T363064 MediaWiki.Commenting.MissingCovers.MissingCovers does not support PHPUnit 10.x attributes
 ResolvedUmherirrenderT363641 IPUtils: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
 Resolved• larissagauliaT363650 Minify: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
 ResolvedUmherirrenderT362858 equivset: Expecting E_ERROR and E_USER_ERROR is deprecated
 ResolvedJdforrester-WMFT395743 Use of package ockcyp/covers-validator in libaries is not compatible with PHPUnit 10
 ResolvedJdforrester-WMFT319055 Upgrade to psr/container 2.x
 ResolvedJdforrester-WMFT328921 Drop PHP 7.4 and PHP 8.0 support from MediaWiki
 ResolvedKrinkleT319432 Migrate WMF production from PHP 7.4 to PHP 8.1
 ResolvedScott_FrenchT383845 MediaWiki on PHP 8.1 production traffic ramp-up
 ResolvedScott_FrenchT387917 Migrate mw-script to PHP 8.1

Event Timeline

jijiki created this task.Mar 4 2025, 8:13 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 4 2025, 8:13 PM
jijiki updated the task description. (Show Details)Mar 4 2025, 8:13 PM
Scott_French updated the task description. (Show Details)Mar 7 2025, 2:43 AM
Scott_French added a subscriber: RLazarus.
Clement_Goubert subscribed.EditedMar 7 2025, 12:21 PM

This would be heplful for the staging deployments of mw-debug.

CodeReviewBot added a project: Patch-For-Review.Mar 7 2025, 3:56 PM

swfrench opened https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/676

kubernetes: support non-deploy helmfile releases

gerritbot added a comment.Mar 7 2025, 4:37 PM

Change #1125473 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] Profile::Mediawiki_deployment: add 'deploy' field to release config

https://gerrit.wikimedia.org/r/1125473

gerritbot added a comment.Mar 7 2025, 4:37 PM

Change #1125474 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] hieradata: add mw-script non-deploy releases to mw_releases

https://gerrit.wikimedia.org/r/1125474

gerritbot added a comment.Mar 7 2025, 4:37 PM

Change #1125475 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] deployment_server: Use mw-script release values file

https://gerrit.wikimedia.org/r/1125475

Scott_French added a comment.Mar 7 2025, 4:44 PM

Thanks, @Clement_Goubert - it's good to see that there's at least one other foreseeable concrete use case for this.

I've posted a MR for what one approach to this functionality might look like in scap (which I'm happy to revise) and a handful of puppet patches demonstrating what its use would look like (minus a patch for the "revert to 7.4" flag).

Scott_French mentioned this in T383845: MediaWiki on PHP 8.1 production traffic ramp-up.Mar 7 2025, 7:10 PM
jijiki moved this task from Incoming 🐫 to this.quarter 🍕 on the serviceops board.Mar 10 2025, 11:37 AM
CodeReviewBot added a comment.Mar 10 2025, 4:39 PM

dancy merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/676

kubernetes: support non-deploy helmfile releases

Scott_French changed the task status from Open to In Progress.Mar 10 2025, 8:50 PM
Scott_French triaged this task as Medium priority.

Many thanks to Ahmon, the scap changes to support non-deploy helmfile releases are live.

The three pending puppet patches to decouple from mw-web are ready to go, but I'll hold off on merging until tomorrow, out of an abundance of caution in the (unlikely) event the scap release is reverted.

gerritbot added a comment.Mar 11 2025, 3:55 PM

Change #1125473 merged by Scott French:

[operations/puppet@production] Profile::Mediawiki_deployment: add 'deploy' field to release config

https://gerrit.wikimedia.org/r/1125473

gerritbot added a comment.Mar 11 2025, 4:06 PM

Change #1125474 merged by Scott French:

[operations/puppet@production] hieradata: add mw-script non-deploy releases to mw_releases

https://gerrit.wikimedia.org/r/1125474

Stashbot added a comment.Mar 11 2025, 4:16 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-11T16:16:07Z] <swfrench@deploy2002> Started scap sync-world: No-op deploy to pick up mediawiki-deployments.yaml changes - T387917

Stashbot added a comment.Mar 11 2025, 4:18 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-11T16:18:16Z] <swfrench@deploy2002> Finished scap sync-world: No-op deploy to pick up mediawiki-deployments.yaml changes - T387917 (duration: 02m 42s)

gerritbot added a comment.Mar 11 2025, 4:19 PM

Change #1125475 merged by Scott French:

[operations/puppet@production] deployment_server: Use mw-script release values file

https://gerrit.wikimedia.org/r/1125475

Scott_French added a comment.Mar 11 2025, 4:31 PM

Alright, I've run puppet-agent on the deployment host and verified mwscript-k8s works as expected following the switch in release values file.

Switching mw-web/main to PHP 8.1 is unblocked.

Next step: introduce the "default to 8.1, optional fallback to 7.4" functionality described in the task description.

gerritbot added a comment.Mar 12 2025, 2:19 AM

Change #1126697 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] deployment_server: Support PHP version selection in mwscript-k8s

https://gerrit.wikimedia.org/r/1126697

gerritbot added a comment.Mar 17 2025, 2:31 PM

Change #1126697 merged by Scott French:

[operations/puppet@production] deployment_server: Support PHP version selection in mwscript-k8s

https://gerrit.wikimedia.org/r/1126697

Scott_French added a comment.Mar 25 2025, 5:19 PM

Alright, I think the next step would be to announce the upcoming switch to default to PHP 8.1. This should provide a target date (TBD) and guidance on how to test scripts on 8.1 ahead of time (via --php_version 8.1).

@RLazarus - It would be good to get your thoughts here on: (1) an appropriate venue for the announcement (IIRC, you've sent mwscript-k8s related announcements to wikitech-l?) and (2) given uptake you've seen of the tool, how much lead time you'd recommend before the default switch.

RLazarus added a comment.Mar 26 2025, 1:26 AM

Yes, I used wikitech-l to announce mwscript-k8s, and will use it again to announce when it becomes the only way. It's a good venue for this too.

You could also check to see who's run mwscript-k8s recently, and bcc them directly. Within the job cleanup TTL, that's easy:

kube_env mw-script eqiad; kubectl get job -ojson | jq '[.items[].metadata.labels.username] | unique'

but to go back further you'd need to ask Logstash. I think we have this in there somewhere for past jobs in both DCs, but I don't know offhand what query to pull it out with. This would be nice to do if it's easy; don't sweat it if it's inconvenient.

Also consider adding a message to the wrapper script itself, at the same time as you flip the default, to give a heads-up to anyone who didn't hear otherwise. (Suppress it if --mediawiki_image or --php_version is passed, and plan to remove it after the switch.) Doesn't need to be an interactive confirmation or anything, just a notification as an added troubleshooting hint if something unexpected happens.

In terms of lead time, I don't think you need much, especially since the escape hatch is right there. A week is probably plenty. (Most people who run one-off scripts do it on an erratic schedule, so it's hard to know what kind of interval to leave anyway.)

gerritbot added a comment.Mar 26 2025, 3:41 PM

Change #1131351 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] deployment_server: Default to PHP 8.1 in mwscript-k8s

https://gerrit.wikimedia.org/r/1131351

Scott_French added a comment.Mar 26 2025, 3:48 PM

Thanks, @RLazarus - that's really helpful. Also great idea adding a message to the script with instructions on how to revert back.

I'll draft something for wikitech-l and target a 1w timeline before the default switch. I need to give some thought to when we'll remove the ability to fall back to 7.4 ... I think it should suffice at the moment to explain that this will happen at some point (and have the tool emit a message indicating this when 7.4 is explicitly selected).

Scott_French updated the task description. (Show Details)Mar 26 2025, 8:50 PM
Scott_French added a comment.Mar 26 2025, 8:53 PM

Alright, I've sent an announcement about the upcoming change to wikitech-l, explaining both the fallback option and the opportunity to test ahead of time (both via --php_version). We're targeting next Wednesday, 2nd of April, for the default change.

Scott_French updated the task description. (Show Details)Mar 26 2025, 8:55 PM
MSantos added a comment.Mar 31 2025, 2:50 PM

This is great! I have a few questions:

Will that be a standard moving forward every time we migrate to a new version? Is this work enough to create the desired structure when we upgrade to more versions in the future?

Scott_French added a comment.Mar 31 2025, 9:18 PM
In T387917#10694185, @MSantos wrote:

This is great! I have a few questions:

Will that be a standard moving forward every time we migrate to a new version? Is this work enough to create the desired structure when we upgrade to more versions in the future?

Yes, indeed - similar to the procedure we've laid out for migrating traffic-serving use cases, this should be readily reusable for future migrations once appropriately documented.

Scott_French added a comment.Apr 1 2025, 7:05 PM

I've added a Note to https://wikitech.wikimedia.org/wiki/Maintenance_scripts in advance of tomorrow's switch.

Scott_French updated the task description. (Show Details)Apr 1 2025, 7:05 PM
gerritbot added a comment.Apr 2 2025, 2:53 PM

Change #1131351 merged by Scott French:

[operations/puppet@production] deployment_server: Default to PHP 8.1 in mwscript-k8s

https://gerrit.wikimedia.org/r/1131351

Scott_French updated the task description. (Show Details)Apr 2 2025, 3:03 PM
Reedy subscribed.Apr 2 2025, 3:13 PM
Scott_French mentioned this in T391057: Turn down MediaWiki image builds for PHP 7.4.Apr 3 2025, 11:20 PM
Scott_French added a comment.Apr 3 2025, 11:30 PM

Since there are no further actions explicitly tracked here, and indeed I've manually tested the new 8.1-default and 7.4-fallback, I'm going to close this out.

Removing the 7.4-fallback, which in turn unblocks no-longer building the 7.4 version of the MediaWiki app image, is tracked as part of T391057: Turn down MediaWiki image builds for PHP 7.4.

Scott_French closed this task as Resolved.Apr 3 2025, 11:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits