Page MenuHomePhabricator
Create Task
Maniphest T387991

Clean up, merge, and share code between Cite legacy and Cite Parsoid
Closed, ResolvedPublic
Actions

Description

Continuing what was started in T386452 this task aims to …

  • Get rid of as much unnecessary and duplicate code as possible, in both parsers.
  • Bring the two parser implementations closer together so reappearing concepts can be recognized easier by someone looking at the code.
  • Make the two actually share code. A notable example is what's currently called the "Validator" in the legacy parser.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move extra error checking out of ReferenceListFormattermediawiki/extensions/Citemaster+28 -56
Extract two more methods in the large References classmediawiki/extensions/Citemaster+43 -28
Store actual parent reference object in sub-referencemediawiki/extensions/Citemaster+26 -5
Turn rollback stack into an actual call stack of callablesmediawiki/extensions/Citemaster+26 -64
Add AnchorFormatter::getNoteTextIdentifier methodmediawiki/extensions/Citemaster+9 -6
No expensive anchor normalization where not neededmediawiki/extensions/Citemaster+7 -6
Parsoid: No URL percent-encoding in non-href attributesmediawiki/extensions/Citemaster+11 -13
Start using the shared AnchorFormatter in Parsoidmediawiki/extensions/Citemaster+142 -77
Remove non-standard id attribute from incomplete followmediawiki/extensions/Citemaster+6 -10
Move all (back)link generator logic into AnchorFormattermediawiki/extensions/Citemaster+66 -74
De-couple Validator from the old parsermediawiki/extensions/Citemaster+45 -41
Drop one more special case how errors can be reportedmediawiki/extensions/Citemaster+28 -15
Move first argument validation step into the validatormediawiki/extensions/Citemaster+47 -60
Drop not needed "assign" action from ReferenceStackmediawiki/extensions/Citemaster+6 -11
Store direct reference to ReferenceStackItem in rollback stackmediawiki/extensions/Citemaster+30 -40
Extract another private method in RefTagHandlermediawiki/extensions/Citemaster+21 -22
Never accept "0" as the name of a referencemediawiki/extensions/Citemaster+40 -33
Rename ambiguous "index" and make it behave the samemediawiki/extensions/Citemaster+17 -13
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Mar 5 2025, 1:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2025, 1:48 PM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2025-03-05 board.Mar 5 2025, 1:48 PM
gerritbot added a comment.Mar 5 2025, 1:51 PM

Change #1124794 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Rename ambiguous "index" and make it behave the same

https://gerrit.wikimedia.org/r/1124794

gerritbot added a project: Patch-For-Review.Mar 5 2025, 1:51 PM
gerritbot added a comment.Mar 6 2025, 9:37 AM

Change #1121323 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Never accept "0" as the name of a reference

https://gerrit.wikimedia.org/r/1121323

gerritbot added a comment.Mar 6 2025, 10:16 AM

Change #1124794 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Rename ambiguous "index" and make it behave the same

https://gerrit.wikimedia.org/r/1124794

gerritbot added a comment.Mar 6 2025, 10:55 AM

Change #1125121 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] [POC] Don't pre-generate but dynamically generate link ids

https://gerrit.wikimedia.org/r/1125121

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 6 2025, 11:00 AM
gerritbot added a comment.Mar 6 2025, 12:55 PM

Change #1121323 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Never accept "0" as the name of a reference

https://gerrit.wikimedia.org/r/1121323

gerritbot added a comment.Mar 6 2025, 2:15 PM

Change #1121586 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Drop not needed "assign" action from ReferenceStack

https://gerrit.wikimedia.org/r/1121586

gerritbot added a comment.Mar 6 2025, 2:17 PM

Change #1123691 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Drop now obsolete parameter in internal rollback stack

https://gerrit.wikimedia.org/r/1123691

SLopes-WMF removed a project: Parsoid.Mar 6 2025, 3:16 PM
gerritbot added a comment.Mar 7 2025, 9:58 AM

Change #1125385 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Store proper, usable parent reference in sub-reference

https://gerrit.wikimedia.org/r/1125385

gerritbot added a comment.Mar 10 2025, 10:03 AM

Change #1125977 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Extract another private method in RefTagHandler

https://gerrit.wikimedia.org/r/1125977

gerritbot added a comment.Mar 11 2025, 12:26 PM

Change #1126540 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] [WIP] De-couple Validator from the old parser

https://gerrit.wikimedia.org/r/1126540

gerritbot added a comment.Mar 11 2025, 12:38 PM

Change #1126544 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Turn rollback stack into an actual call stack of callables

https://gerrit.wikimedia.org/r/1126544

gerritbot added a comment.Mar 12 2025, 8:41 AM

Change #1126923 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Store direct reference to ReferenceStackItem in rollback stack

https://gerrit.wikimedia.org/r/1126923

gerritbot added a comment.Mar 12 2025, 5:07 PM

Change #1125977 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Extract another private method in RefTagHandler

https://gerrit.wikimedia.org/r/1125977

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.21; 2025-03-18); removed MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 12 2025, 6:00 PM
gerritbot added a comment.Mar 13 2025, 7:08 AM

Change #1126923 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Store direct reference to ReferenceStackItem in rollback stack

https://gerrit.wikimedia.org/r/1126923

gerritbot added a comment.Mar 13 2025, 8:41 AM

Change #1123275 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] [WIP] Turn many more Validator fatals into warnings

https://gerrit.wikimedia.org/r/1123275

thiemowmde added a subtask: T387002: Try to reduce duplicate code in reference validation.Mar 13 2025, 8:43 AM
gerritbot added a comment.Mar 13 2025, 10:16 AM

Change #1121586 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Drop not needed "assign" action from ReferenceStack

https://gerrit.wikimedia.org/r/1121586

thiemowmde moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2025-03-05 board.Mar 14 2025, 9:17 AM
gerritbot added a comment.Mar 14 2025, 2:27 PM

Change #1127908 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move first argument validation step into the validator

https://gerrit.wikimedia.org/r/1127908

gerritbot added a comment.Mar 17 2025, 2:22 PM

Change #1128426 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Drop one more special case how errors can be reported

https://gerrit.wikimedia.org/r/1128426

gerritbot added a comment.Mar 18 2025, 9:49 AM

Change #1128810 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move all (back)link generator logic into AnchorFormatter

https://gerrit.wikimedia.org/r/1128810

thiemowmde added a project: WMDE-TechWish-Sprint-2025-03-19.Mar 19 2025, 8:50 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2025-03-19 board.
gerritbot added a comment.Mar 19 2025, 3:09 PM

Change #1127908 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move first argument validation step into the validator

https://gerrit.wikimedia.org/r/1127908

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.22; 2025-03-25); removed MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 19 2025, 4:00 PM
gerritbot added a comment.Mar 19 2025, 5:37 PM

Change #1128426 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Drop one more special case how errors can be reported

https://gerrit.wikimedia.org/r/1128426

gerritbot added a comment.Mar 19 2025, 7:29 PM

Change #1126540 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] De-couple Validator from the old parser

https://gerrit.wikimedia.org/r/1126540

gerritbot added a comment.Mar 21 2025, 12:01 PM

Change #1128810 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move all (back)link generator logic into AnchorFormatter

https://gerrit.wikimedia.org/r/1128810

gerritbot added a comment.Mar 25 2025, 11:20 AM

Change #1130986 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove non-standard id attribute from incomplete follow

https://gerrit.wikimedia.org/r/1130986

gerritbot added a comment.Mar 27 2025, 10:14 AM

Change #1130986 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove non-standard id attribute from incomplete follow

https://gerrit.wikimedia.org/r/1130986

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 27 2025, 11:00 AM
gerritbot added a comment.Mar 27 2025, 4:13 PM

Change #1131771 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Extract two more methods in the large References class

https://gerrit.wikimedia.org/r/1131771

gerritbot added a comment.Mar 28 2025, 7:43 AM

Change #1131771 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Extract two more methods in the large References class

https://gerrit.wikimedia.org/r/1131771

awight closed subtask T387002: Try to reduce duplicate code in reference validation as Resolved.Apr 2 2025, 9:02 AM
thiemowmde added a subtask: T390960: Continue to clean up extractRefFromNode in References.php.Apr 4 2025, 10:35 AM
thiemowmde added a parent task: T383787: [Epic] Refactor PHP Code in Cite Extension.
gerritbot added a comment.Apr 4 2025, 2:49 PM

Change #1134244 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Parsoid: No URL percent-encoding in non-href attributes

https://gerrit.wikimedia.org/r/1134244

gerritbot added a comment.Apr 7 2025, 9:13 AM

Change #1125121 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Start using the shared AnchorFormatter in Parsoid

https://gerrit.wikimedia.org/r/1125121

gerritbot added a comment.Apr 7 2025, 9:44 AM

Change #1134244 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Parsoid: No URL percent-encoding in non-href attributes

https://gerrit.wikimedia.org/r/1134244

gerritbot added a comment.Apr 9 2025, 9:22 AM

Change #1135386 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] No expensive anchor normalization where not needed

https://gerrit.wikimedia.org/r/1135386

gerritbot added a comment.Apr 9 2025, 11:39 AM

Change #1135386 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] No expensive anchor normalization where not needed

https://gerrit.wikimedia.org/r/1135386

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.25; 2025-04-15); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Apr 9 2025, 12:00 PM
gerritbot added a comment.Apr 10 2025, 9:23 AM

Change #1135679 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Add AnchorFormatter::getNoteTextIdentifier method

https://gerrit.wikimedia.org/r/1135679

gerritbot added a comment.Apr 10 2025, 10:54 AM

Change #1135679 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add AnchorFormatter::getNoteTextIdentifier method

https://gerrit.wikimedia.org/r/1135679

gerritbot added a comment.Apr 17 2025, 9:26 AM

Change #1126544 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Turn rollback stack into an actual call stack of callables

Reason:

Not compatible with I4a7118c.

https://gerrit.wikimedia.org/r/1126544

gerritbot added a comment.Apr 28 2025, 9:01 AM

Change #1125385 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Store actual parent reference object in sub-reference

Reason:

Already done as part of I4a7118c.

https://gerrit.wikimedia.org/r/1125385

gerritbot added a comment.Apr 28 2025, 10:11 AM

Change #1135752 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move extra error checking out of ReferenceListFormatter

https://gerrit.wikimedia.org/r/1135752

WMDE-Fisch closed subtask T390960: Continue to clean up extractRefFromNode in References.php as Resolved.Apr 30 2025, 7:35 AM
thiemowmde added a subtask: T393022: Move and merge remaining error cases into the shared Validator.Apr 30 2025, 3:35 PM
thiemowmde closed subtask T393022: Move and merge remaining error cases into the shared Validator as Resolved.May 28 2025, 7:38 AM
thiemowmde closed this task as Resolved.Jun 25 2025, 10:07 AM
gerritbot added a comment.Aug 6 2025, 7:15 AM

Change #1135752 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move extra error checking out of ReferenceListFormatter

https://gerrit.wikimedia.org/r/1135752

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.14; 2025-08-12).Aug 6 2025, 8:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits