Page MenuHomePhabricator
Create Task
Maniphest T387995

Handle Enotif Talk notifications via MediaWiki Notifications
Closed, ResolvedPublic
Actions

Description

MediaWiki allows triggering Email notifications when someone edits user's talk page.
Migrate this system into the newly created Notifications component, making sure there is no behaviour/logic change.

In contrast to T387988, this Notification is triggered on wikis, therefore it's behaviour should be validated after deployment.

Acceptance Criteria:

  • There is no behaviour change to existing Talk page email Notifications
  • RecentNotitifcationChangeHandler handles te Talk page notifications
  • RecentNotificationChangeHandler uses service from T387987 to trigger Emails

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
enotif: Handle Talk notifications via new Notifications systemPmiazgamediawiki/coremaster+39 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

pmiazga created this task.Mar 5 2025, 2:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2025, 2:11 PM
pmiazga edited projects, added: MediaWiki-Core-Platform-Team; removed: MediaWiki-Core-Platform-Team (Roadmap).Mar 17 2025, 2:40 PM
pmiazga moved this task from Inbox, needs triage to Needs refinement on the MediaWiki-Core-Platform-Team board.
pmiazga mentioned this in T383994: Migrate at least two notifications that use Echo to the new interface.Mar 21 2025, 12:24 PM
pmiazga edited parent tasks, added: T389624: Post "enotif" migration followup: Notifications hook deprecations and migration Path; removed: T383996: Migrate Enotif to the new notifications interface.Mar 27 2025, 2:41 PM
pmiazga edited parent tasks, added: T383996: Migrate Enotif to the new notifications interface; removed: T389624: Post "enotif" migration followup: Notifications hook deprecations and migration Path.Mar 27 2025, 3:17 PM
pmiazga removed a subtask: T388002: Rename EmailNotification to better express class component responsibility.
pmiazga changed the task status from Open to In Progress.Mar 27 2025, 3:19 PM
pmiazga claimed this task.
pmiazga moved this task from Needs refinement to In progress (DO NOT USE) on the MediaWiki-Core-Platform-Team board.Mar 28 2025, 5:47 PM
gerritbot added a comment.Mar 28 2025, 5:51 PM

Change #1132006 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/core@master] enotif: Handle Talk notifications via new Notifications system

https://gerrit.wikimedia.org/r/1132006

gerritbot added a project: Patch-For-Review.Mar 28 2025, 5:51 PM
pmiazga moved this task from Backlog to In progress on the MediaWiki-Core-Notifications board.Mar 31 2025, 2:16 PM
• matmarex removed a subtask: T388001: Migrate ENotif Watchlist Notifications.Apr 1 2025, 8:27 PM
• matmarex subscribed.Apr 1 2025, 8:38 PM

Test plan:

  • With Echo installed, as user A, edit user B's talk page. Verify that you got an email, and that it's the same before and after this change.
  • With Echo not installed, as user A, edit user B's talk page. Verify that you got an email, and that it's the same before and after this change.
gerritbot added a comment.Apr 1 2025, 11:22 PM

Change #1132006 merged by jenkins-bot:

[mediawiki/core@master] enotif: Handle Talk notifications via new Notifications system

https://gerrit.wikimedia.org/r/1132006

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2025, 11:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 2 2025, 12:00 AM
• matmarex closed this task as Resolved.Apr 2 2025, 12:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits