Page MenuHomePhabricator
Create Task
Maniphest T388003

Deprecate `SendWatchlistEmailNotification` hook
Closed, ResolvedPublic
Actions

Description

As ENotif uses the MediaWiki Notification system, we should deprecate this hook and let the Notification system handle.

Notes:

This hook is used by:

  • Echo extension to stop sending an email and triggers the Echo notification instead. This use case should be fully handled by Echo becoming a Notification Provider
  • BlueSpice is using SendWatchlistEmailNotification to remove watchlist notifications for entities. This should be solved by T387996

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Deprecate the SendWatchlistEmailNotification Hookmediawiki/coremaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

pmiazga created this task.Mar 5 2025, 2:36 PM
pmiazga added a comment.Mar 21 2025, 2:42 PM

Blocked on T387996 - In order to deprecate hook we need to provide a replacement.

pmiazga edited parent tasks, added: T389624: Post "enotif" migration followup: Notifications hook deprecations and migration Path; removed: T383996: Migrate Enotif to the new notifications interface.Mar 27 2025, 2:42 PM
pmiazga moved this task from Backlog to Planned on the MediaWiki-Core-Notifications board.May 9 2025, 1:16 PM
Mooeypoo mentioned this in T389624: Post "enotif" migration followup: Notifications hook deprecations and migration Path.Jun 26 2025, 2:37 PM
matmarex added a subtask: T392293: Migrate Echo Hooks that stop ENotif notifications.Jul 16 2025, 10:29 PM
matmarex closed subtask T392293: Migrate Echo Hooks that stop ENotif notifications as Resolved.Jul 17 2025, 8:01 PM
gerritbot added a comment.Jul 18 2025, 2:25 PM

Change #1170568 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/core@master] Deprecate the SendWatchlistEmailNotification Hook

https://gerrit.wikimedia.org/r/1170568

gerritbot added a project: Patch-For-Review.Jul 18 2025, 2:25 PM
pmiazga added a comment.Jul 18 2025, 2:26 PM

Let's merge the Hook deprecation code (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1170568), and we can call this work done as BlueSpice is not a part of the WMF stack.

matmarex assigned this task to pmiazga.Jul 19 2025, 2:02 AM
matmarex moved this task from Planned to In progress on the MediaWiki-Core-Notifications board.
matmarex moved this task from Roadmap to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.Jul 19 2025, 2:05 AM
matmarex edited projects, added MediaWiki-Platform-Team; removed MediaWiki-Platform-Team (Roadmap).
gerritbot added a comment.Jul 19 2025, 2:18 AM

Change #1170568 merged by jenkins-bot:

[mediawiki/core@master] Deprecate the SendWatchlistEmailNotification Hook

https://gerrit.wikimedia.org/r/1170568

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2025, 2:30 AM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.11; 2025-07-22).Jul 19 2025, 3:01 AM
pmiazga closed this task as Resolved.Jul 21 2025, 11:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits