Maniphest T388004

Deprecate `AbortTalkPageEmailNotification` hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	pmiazga
	Mar 5 2025, 2:39 PM

Project Tags

Referenced Files

None

Subscribers

Description

As ENotif uses the MediaWiki Notification system, we should deprecate this hook and let the Notification system handle.

Notes:
This hook is used by Echo extension to decide whether to handle the notification via Echo, or keep using the MediaWiki provider to send email instead.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Deprecate the AbortTalkPageEmailNotificationHook	mediawiki/core	master	+7 -1
	enotif: deprecate AbortTalkPageEmailNotification hook	mediawiki/core	master	+4 -0
	enotif: deprecate AbortTalkPageEmailNotification hook	mediawiki/core	REL1_44	+4 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		matmarex	T389624 Post "enotif" migration followup: Notifications hook deprecations and migration Path
		Resolved		pmiazga	T388004 Deprecate `AbortTalkPageEmailNotification` hook

Event Timeline

pmiazga created this task.Mar 5 2025, 2:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2025, 2:39 PM

Blocked on T387996 - In order to deprecate hook we need to provide a replacement.

pmiazga edited parent tasks, added: T389624: Post "enotif" migration followup: Notifications hook deprecations and migration Path; removed: T383996: Migrate Enotif to the new notifications interface.Mar 27 2025, 2:43 PM

Change #1137465 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/core@master] Deprecate the AbortTalkPageEmailNotificationHook

https://gerrit.wikimedia.org/r/1137465

gerritbot added a project: Patch-For-Review.Apr 18 2025, 5:16 PM

pmiazga moved this task from Backlog to Planned on the MediaWiki-Core-Notifications board.May 9 2025, 1:16 PM

pmiazga claimed this task.May 9 2025, 1:35 PM

pmiazga moved this task from Planned to In progress on the MediaWiki-Core-Notifications board.

Change #1143833 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/core@master] enotif: deprecate AbortTalkPageEmailNotification hook

https://gerrit.wikimedia.org/r/1143833

pmiazga moved this task from In progress to Epics on the MediaWiki-Core-Notifications board.May 12 2025, 4:51 PM

pmiazga moved this task from Epics to In progress on the MediaWiki-Core-Notifications board.

Change #1143833 merged by jenkins-bot:

[mediawiki/core@master] enotif: deprecate AbortTalkPageEmailNotification hook

https://gerrit.wikimedia.org/r/1143833

Change #1144698 had a related patch set uploaded (by Bartosz Dziewoński; author: Pmiazga):

[mediawiki/core@REL1_44] enotif: deprecate AbortTalkPageEmailNotification hook

https://gerrit.wikimedia.org/r/1144698

Change #1144698 merged by jenkins-bot:

[mediawiki/core@REL1_44] enotif: deprecate AbortTalkPageEmailNotification hook

https://gerrit.wikimedia.org/r/1144698

ReleaseTaggerBot added projects: MW-1.44-notes, MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 13 2025, 2:00 AM

Change #1137465 abandoned by Bartosz Dziewoński:

[mediawiki/core@master] Deprecate the AbortTalkPageEmailNotificationHook

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1143833

https://gerrit.wikimedia.org/r/1137465

matmarex closed this task as Resolved.May 13 2025, 2:05 AM

matmarex removed a project: Patch-For-Review.

matmarex subscribed.

Mooeypoo mentioned this in T389624: Post "enotif" migration followup: Notifications hook deprecations and migration Path.Jun 26 2025, 2:37 PM