Validate that favorite templates are valid page IDs in the correct namespace when loading from user preferences
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	TheresNoTime
	Mar 6 2025, 12:16 PM

Description

When loading the templatedata-favorite-templates array from the user's preferences, ensure that they are:

A valid page ID (i.e. the page exists)
That the page is in a TemplateDataEditorNamespaces namespace

Any pages which fail validation should be removed from the favorites array.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ext.templateData.templateDiscovery: Validate on save, add caching	mediawiki/extensions/TemplateData	master	+352 -70
	ext.templateData.templateDiscovery: Validate favorites on load	mediawiki/extensions/TemplateData	master	+42 -1

Customize query in gerrit

Related Objects

Mentioned Here: T377729: Use SaveUserOptions hook to validate template favourites

Event Timeline

TheresNoTime created this task.Mar 6 2025, 12:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2025, 12:16 PM

TheresNoTime renamed this task from Use LoadUserOptions hook to validate favourite templates to Use LoadUserOptions hook to check that favourite templates are valid page IDs in the correct namespace.Mar 6 2025, 12:16 PM

TheresNoTime moved this task from New & TBD Tickets to Allow users to favorite a template on the Template-Discovery-And-Recall board.

TheresNoTime edited projects, added Template-Discovery-And-Recall (Allow users to favorite a template); removed Template-Discovery-And-Recall.

Samwilson moved this task from Ready for Dev to In Development on the Community-Tech (Fox Squad) board.Mar 7 2025, 2:51 AM

Change #1125470 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/TemplateData@master] [WIP] ext.templateData.templateDiscovery: Validate on save, add caching

https://gerrit.wikimedia.org/r/1125470

gerritbot added a project: Patch-For-Review.Mar 7 2025, 4:24 PM

TheresNoTime moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Mar 12 2025, 10:03 AM

Change #1128419 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/TemplateData@master] ext.templateData.templateDiscovery: Validate favorites on load

https://gerrit.wikimedia.org/r/1128419

TheresNoTime renamed this task from Use LoadUserOptions hook to check that favourite templates are valid page IDs in the correct namespace to Validate that favorite templates are valid page IDs in the correct namespace when loading from user preferences.Mar 17 2025, 2:11 PM

TheresNoTime updated the task description. (Show Details)

Change #1128419 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] ext.templateData.templateDiscovery: Validate favorites on load

https://gerrit.wikimedia.org/r/1128419

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 18 2025, 3:14 PM

KSiebert set the point value for this task to 8.Mar 20 2025, 10:21 AM

Is there more to do here? The caching is going to happen in a separate task now isn't it?

TheresNoTime moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Mar 25 2025, 11:58 AM

TheresNoTime removed a project: Patch-For-Review.

KSiebert changed the task status from Open to Stalled.Mar 27 2025, 10:38 AM

Change #1125470 abandoned by Samtar:

[mediawiki/extensions/TemplateData@master] ext.templateData.templateDiscovery: Validate on save, add caching

Reason:

Patch split out