We should just read from afl_ip_hex to make T397941: Update code to read from afl_ip_hex easier to do in the future.

Change #1171567 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] ipreveal: Frontend changes supporting IPReveal in Special:AbuseLog

https://gerrit.wikimedia.org/r/1171567

I don't know if this change is the problem but since, on fr wikipedia, we have problem to test filters. Sometimes very long (1 minute and over), sometimes so long that the request end with an error, sometimes the test doesn't work : even a simple test as <added_lines irlike "something"> shows a false result when add line "something".

In T388124#11037278, @Supertoff wrote:

I don't know if this change is the problem but since, on fr wikipedia, we have problem to test filters. Sometimes very long (1 minute and over), sometimes so long that the request end with an error, sometimes the test doesn't work : even a simple test as <added_lines irlike "something"> shows a false result when add line "something".

@Supertoff this change is unlikely to have messed up the test page, because it hasn't been merged yet. Just to make sure, you're talking about using Special:AbuseFilter/test page, right?

In T388124#11038168, @mszwarc wrote:

In T388124#11037278, @Supertoff wrote:

I don't know if this change is the problem but since, on fr wikipedia, we have problem to test filters. Sometimes very long (1 minute and over), sometimes so long that the request end with an error, sometimes the test doesn't work : even a simple test as <added_lines irlike "something"> shows a false result when add line "something".

@Supertoff this change is unlikely to have messed up the test page, because it hasn't been merged yet. Just to make sure, you're talking about using Special:AbuseFilter/test page, right?

Yes, you are right.

The latest significant commits to the AbuseFilter extension seem to solely be about protected variables, afl_ip, afl_ip_hex, etc. That's why, as an educated guess, I assumed the regression might have been introduced during the work related to the items from this ticket.

Without access to any error reporting, since it's server-side, it's difficult to do better than educated guessing.

I've reported the issue with /test page in T400673. I was able to reproduce the issue yesterday on plwiki, today it works fine for me. In a local environment I wasn't able to reproduce it in the same version of AbuseFilter as is currently installed on WMF wikis.

The frontend patch was updated based on the feedback provided so far, moving this back to code review.

The patch associated with the frontend subtask for this ticket is being merged right now, so I'm closing that ticket and moving this one QA.

Change #1171567 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ipreveal: Frontend changes supporting IPReveal in Special:AbuseLog

https://gerrit.wikimedia.org/r/1171567

@hector.arroyo When I click Show IP on Special:AbuseLog, in Local Storage on my browser I see an entry for mw-checkuser-temp-<username> but not for _EXPIRY_mw-checkuser-temp-<username>. The latter entry I do see when I click Show IP on Special:RecentChanges (for example). I guess this is something that needs to be set if we want to expire autoreveal correctly?

Change #1180820 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] ipreveal: Don't provide AF log IDs if AbuseFilter is not loaded

https://gerrit.wikimedia.org/r/1180820

I've submitted an additional patch to fix requests to the batch endpoint in case AbuseFilter is not loaded in the wiki making use of IP Reveal, since the new abuseLogIds request parameter won't be recognized as a valid property from the JSON request payload in that case: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1180820

(Moving to 'Needs Review' so that we can track reviewing that patch)

Change #1180820 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] ipreveal: Don't provide AF log IDs if AbuseFilter is not loaded

https://gerrit.wikimedia.org/r/1180820

Checking https://test.wikipedia.org/wiki/Special:Version, the CheckUser version there is 2.5 (e322528) 10:21, 25 August 2025, which means the latest fix should be deployed there.

Additionally,

• Looking up for form ul li[data-afl-log-id] in modules=ext.checkUser.tempAccounts confirms the frontend code from CheckUser #1171567 is deployed there.
• Looking up for wgCheckUserAbuseFilterExtensionLoaded in modules=ext.checkUser.tempAccounts confirms the frontend code from CheckUser #1180820 is deployed there.
• Entries in https://test.wikipedia.org/wiki/Special:AbuseLog include a data-afl-log-id attribute, so the required changes from AbuseFilter #1171229 are also deployed there.

So I think QA may be done there. However, I don't have CheckUser permissions on that environment, so I can't verify myself if the fix is working properly there.

In T388124#11078046, @dom_walden wrote:

@hector.arroyo When I click Show IP on Special:AbuseLog, in Local Storage on my browser I see an entry for mw-checkuser-temp-<username> but not for _EXPIRY_mw-checkuser-temp-<username>. The latter entry I do see when I click Show IP on Special:RecentChanges (for example). I guess this is something that needs to be set if we want to expire autoreveal correctly?

I can no longer reproduce this on https://test.wikipedia.org CheckUser 2.5 (e322528) 10:21, 25 August 2025. I think I am finished here.

@hector.arroyo @dom_walden @Dreamy_Jazz according to dewiki TAIV they can see the "show IP" button in abuse filter logs (previously only visible for admins) but it doesn't show an IP for them – is that intended?

In T388124#11134323, @Johannnes89 wrote:

@hector.arroyo @dom_walden @Dreamy_Jazz according to dewiki TAIV they can see the "show IP" button in abuse filter logs (previously only visible for admins) but it doesn't show an IP for them – is that intended?

Thanks for reporting this and apologies for not seeing this sooner. This isn't intentional and I think it has also been reported at T405522: Temporary account IP reveal: Users who lack abusefilter-log-detail right get non-functional IP reveal on Special:AbuseLog.

In T388124#11211969, @Dreamy_Jazz wrote:

In T388124#11134323, @Johannnes89 wrote:

@hector.arroyo @dom_walden @Dreamy_Jazz according to dewiki TAIV they can see the "show IP" button in abuse filter logs (previously only visible for admins) but it doesn't show an IP for them – is that intended?

Thanks for reporting this and apologies for not seeing this sooner. This isn't intentional and I think it has also been reported at T405522: Temporary account IP reveal: Users who lack abusefilter-log-detail right get non-functional IP reveal on Special:AbuseLog.

Thanks, T405522 is indeed the same issue. I didn't realise it until reading the task but a non-admin TAIV just confirmed that he can access the IP in abuse logs like https://de.wikipedia.org/w/index.php?title=Spezial:Missbrauchsfilter-Logbuch&wpSearchUser=%7E2025-26551-48 because it's a public filter which just requires abusefilter-log-detail (which all autoconfirmed users on dewiki have) while the error message appears when trying to access IPs in abuse logs like https://de.wikipedia.org/w/index.php?title=Spezial:Missbrauchsfilter-Logbuch&wpSearchUser=~2025-64368-1 which requires abusefilter-log-private. I'll continue in the linked task.