Page MenuHomePhabricator

Not able to select parent category using keyboard controls in upload wizard
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Enter a category name in the category field
  • Using the keyboard down arrow select one of the relevant parent category
  • Press enter to navigate to its sub categories
  • Using the keyboard down arrow select the parent category
  • Press enter on keyboard to add parent category to the field

What happens?:

  • sometimes the parent category does not get added to the field when using keyboard
  • sometimes it gets added if you select it again using keyboard
  • sometimes it works right away

What should have happened instead?:

  • the parent category should always get added to the field when using keyboard

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Upload wizard in production

Other information (browser name/version, screenshots, etc.):
On Desktop. Happens on google chrome, safari. Have not tested on other browsers yet.

Event Timeline

Change #1126029 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Fix inconsistent ability to select parent category

https://gerrit.wikimedia.org/r/1126029

FYI the unwanted behavior (inability to select "parent category") doesn't manifest until a user navigates upwards again; i.e. goes back to the parent category, and then tries to select that one.
Should be fixed with above patch.

Change #1126029 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Fix inconsistent ability to select parent category

https://gerrit.wikimedia.org/r/1126029

Etonkovidova subscribed.

Checked on commons wmf.20. The following scenario works as expected.

Using the keyboard down arrow select one of the relevant parent category
Press enter to navigate to its sub categories
Using the keyboard down arrow select the parent category
Press enter on keyboard to add parent category to the field

Using the arrow up button and then selecting a parent category works too (the issue mentioned in https://phabricator.wikimedia.org/T388152#10618338.