Fix talk page message behavior when ORES extension is enabled
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Kgraessle
	Mar 7 2025, 3:26 PM

Description

Steps to replicate the issue (include links if applicable):

Have AutoModerator enabled
Have bot flag enabled or disabled
Have ORES extension enabled

What happens?:
When the bot flag is enabled, no messages are sent.
When the bot flag is disabled, duplicate messages are sent.

What should have happened instead?:
One message sent ber rollback.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
1.44.0-wmf.16

Other information (browser name/version, screenshots, etc.):
See patch here for more info: T387095: SPIKE: AutoModerator sends repetitive notifications on user's talkpage on Chinese Wikipedia [8hrs]

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	AutoModerator sends repetitive notifications on user's talkpage on Chinese Wikipedia - Refactored the talk page message sending logic to an onRollbackComplete hook - This was done because when ORES was enabled and the bot flag was disabled, we were sending multiple messages - The other bug this fixes is that when ORES was enabled and the bot flag was enabled, we were not sending any messags	mediawiki/extensions/AutoModerator	master	+328 -352

Customize query in gerrit

Related Objects

Mentioned In: rEAMO2217819edd77: AutoModerator sends repetitive notifications on user's talkpage on Chinese…
Mentioned Here: T387095: SPIKE: AutoModerator sends repetitive notifications on user's talkpage on Chinese Wikipedia [8hrs]

Event Timeline

Kgraessle created this task.Mar 7 2025, 3:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2025, 3:26 PM

Kgraessle claimed this task.Mar 7 2025, 3:27 PM

Kgraessle triaged this task as High priority.

Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Kgraessle added a project: Automoderator.Mar 7 2025, 3:31 PM

Change #1125254 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/AutoModerator@master] AutoModerator sends repetitive notifications on user's talkpage on Chinese Wikipedia - Refactored the talk page message sending logic to an onRollbackComplete hook - This was done because when ORES was enabled and the bot flag was disabled, we were sending multiple messages - The other bug this fixes is that when ORES was enabled and the bot flag was enabled, we were not sending any messags

https://gerrit.wikimedia.org/r/1125254

gerritbot added a project: Patch-For-Review.Mar 7 2025, 10:09 PM

Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Mar 7 2025, 10:16 PM

Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Mar 11 2025, 3:14 AM

Change #1125254 merged by jenkins-bot:

https://gerrit.wikimedia.org/r/1125254

Kgraessle mentioned this in rEAMO2217819edd77: AutoModerator sends repetitive notifications on user's talkpage on Chinese….Mar 11 2025, 3:25 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 3:30 AM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 11 2025, 4:00 AM

We'll be able to QA this tomorrow after the train has rolled out to group 1 wikis.

This should be fixed in production. I see that the latest AutoModerator revert only sent one talk page message. See here.

jsn.sherman closed this task as Resolved.Mar 20 2025, 7:53 PM

Fix talk page message behavior when ORES extension is enabled Closed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Fix talk page message behavior when ORES extension is enabled
Closed, ResolvedPublicBUG REPORT
Actions