Page MenuHomePhabricator
Create Task
Maniphest T388255

PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.19/includes/user/BotPassword.php(348)
#0[internal function]MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.44.0-wmf.19/includes/user/BotPassword.php(348)strlen(null)
#2/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiLogin.php(165)MediaWiki\User\BotPassword::canonicalizeLoginData(string, null)
#3/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiMain.php(2005)MediaWiki\Api\ApiLogin->execute()
#4/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#5/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#6/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#7/srv/mediawiki/php-1.44.0-wmf.19/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#8/srv/mediawiki/php-1.44.0-wmf.19/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#9/srv/mediawiki/w/api.php(3)require(string)
#10{main}
Impact
Notes
Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.19/includes/user/BotPassword.php(353)
#0[internal function]MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.44.0-wmf.19/includes/user/BotPassword.php(353)strlen(null)
#2/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiLogin.php(165)MediaWiki\User\BotPassword::canonicalizeLoginData(string, null)
#3/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiMain.php(2005)MediaWiki\Api\ApiLogin->execute()
#4/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#5/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#6/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#7/srv/mediawiki/php-1.44.0-wmf.19/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#8/srv/mediawiki/php-1.44.0-wmf.19/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#9/srv/mediawiki/w/api.php(3)require(string)
#10{main}
Impact
Notes

Details

Request URL
https://ja.wikivoyage.org/w/api.php
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
BotPasswordTest: Add a few more test cases provideCanonicalizeLoginDatamediawiki/coreREL1_42+4 -0
ApiLogin: Don't break BotPasswords if password or user is blank, just errormediawiki/coreREL1_42+1 -1
BotPasswordTest: Add a few more test cases provideCanonicalizeLoginDatamediawiki/coreREL1_43+4 -0
ApiLogin: Don't break BotPasswords if password or user is blank, just errormediawiki/coreREL1_39+1 -1
BotPasswordTest: Add a few more test cases provideCanonicalizeLoginDatamediawiki/coreREL1_39+4 -0
ApiLogin: Don't break BotPasswords if password or user is blank, just errormediawiki/corewmf/1.44.0-wmf.20+1 -1
ApiLogin: Don't break BotPasswords if password or user is blank, just errormediawiki/coreREL1_43+1 -1
BotPasswordTest: Add a few more test cases provideCanonicalizeLoginDatamediawiki/coremaster+4 -0
ApiLogin: Don't break BotPasswords if password or user is blank, just errormediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
ResolvedPRODUCTION ERRORJdforrester-WMFT388255 PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated
· · ·

Event Timeline

Reedy created this task.Mar 7 2025, 4:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2025, 4:20 PM
Reedy added a project: MediaWiki-Action-API.Mar 7 2025, 4:20 PM

The password seems to be null... Isn't the password supposed to be a required parameter?

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.Mar 7 2025, 4:22 PM
Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.
Reedy updated the task description. (Show Details)Mar 7 2025, 4:34 PM
Reedy moved this task from Untriaged to Mar 2025 on the Wikimedia-production-error board.Mar 7 2025, 4:57 PM
Jdforrester-WMF subscribed.Mar 12 2025, 8:25 PM
In T388255#10613891, @Reedy wrote:

The password seems to be null... Isn't the password supposed to be a required parameter?

We requirePostedParameters to make sure that they're not GET'ed, but no, getAllowedParams doesn't specify it as required (presumably for some odd edge case where the password is injected by an extension?).

gerritbot added a comment.Mar 12 2025, 8:28 PM

Change #1127140 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127140

gerritbot added a project: Patch-For-Review.Mar 12 2025, 8:28 PM
Jdforrester-WMF changed the task status from Open to In Progress.Mar 12 2025, 8:28 PM
gerritbot added a comment.Mar 13 2025, 5:59 PM

Change #1127583 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] BotPasswordTest: Add a few more test cases provideCanonicalizeLoginData

https://gerrit.wikimedia.org/r/1127583

gerritbot added a comment.Mar 13 2025, 6:39 PM

Change #1127140 merged by jenkins-bot:

[mediawiki/core@master] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127140

gerritbot added a comment.Mar 13 2025, 6:39 PM

Change #1127591 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@wmf/1.44.0-wmf.20] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127591

gerritbot added a comment.Mar 13 2025, 6:43 PM

Change #1127583 merged by jenkins-bot:

[mediawiki/core@master] BotPasswordTest: Add a few more test cases provideCanonicalizeLoginData

https://gerrit.wikimedia.org/r/1127583

gerritbot added a comment.Mar 13 2025, 6:44 PM

Change #1127593 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_43] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127593

gerritbot added a comment.Mar 13 2025, 6:44 PM

Change #1127594 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_42] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127594

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 13 2025, 7:00 PM
gerritbot added a comment.Mar 13 2025, 8:57 PM

Change #1127633 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/core@REL1_39] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127633

gerritbot added a comment.Mar 13 2025, 8:58 PM

Change #1127634 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_43] BotPasswordTest: Add a few more test cases provideCanonicalizeLoginData

https://gerrit.wikimedia.org/r/1127634

gerritbot added a comment.Mar 13 2025, 8:58 PM

Change #1127635 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_42] BotPasswordTest: Add a few more test cases provideCanonicalizeLoginData

https://gerrit.wikimedia.org/r/1127635

gerritbot added a comment.Mar 13 2025, 8:58 PM

Change #1127636 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] BotPasswordTest: Add a few more test cases provideCanonicalizeLoginData

https://gerrit.wikimedia.org/r/1127636

gerritbot added a comment.Mar 13 2025, 9:12 PM

Change #1127593 merged by jenkins-bot:

[mediawiki/core@REL1_43] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127593

gerritbot added a comment.Mar 13 2025, 9:24 PM

Change #1127591 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.20] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127591

gerritbot added a comment.Mar 13 2025, 9:27 PM

Change #1127633 merged by jenkins-bot:

[mediawiki/core@REL1_39] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127633

gerritbot added a comment.Mar 13 2025, 9:28 PM

Change #1127636 merged by jenkins-bot:

[mediawiki/core@REL1_39] BotPasswordTest: Add a few more test cases provideCanonicalizeLoginData

https://gerrit.wikimedia.org/r/1127636

gerritbot added a comment.Mar 13 2025, 9:34 PM

Change #1127634 merged by jenkins-bot:

[mediawiki/core@REL1_43] BotPasswordTest: Add a few more test cases provideCanonicalizeLoginData

https://gerrit.wikimedia.org/r/1127634

gerritbot added a comment.Mar 13 2025, 9:44 PM

Change #1127594 merged by jenkins-bot:

[mediawiki/core@REL1_42] ApiLogin: Don't break BotPasswords if password or user is blank, just error

https://gerrit.wikimedia.org/r/1127594

gerritbot added a comment.Mar 13 2025, 9:45 PM

Change #1127635 merged by jenkins-bot:

[mediawiki/core@REL1_42] BotPasswordTest: Add a few more test cases provideCanonicalizeLoginData

https://gerrit.wikimedia.org/r/1127635

Reedy closed this task as Resolved.Mar 13 2025, 9:49 PM
Reedy assigned this task to Jdforrester-WMF.
ReleaseTaggerBot edited projects, added MW-1.43-notes, MW-1.39-notes, MW-1.42-notes, MW-1.44-notes (1.44.0-wmf.20; 2025-03-11); removed MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 13 2025, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 13 2025, 10:30 PM
Krinkle moved this task from Mar 2025 to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits