importImages.php does not exit with a non-zero return code if a file fails to import
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	BlankEclair
	Mar 8 2025, 4:53 AM

Description

Steps to replicate the issue (include links if applicable):
In the installation directory:

> sudo mkdir --mode=0777 importtest
> sudo touch importtest/cutie.png
> sudo chmod 0000 importtest/cutie.png
> sudo -u http php maintenance/run.php importImages importtest
PHP Warning:  PHP Startup: ast: Unable to initialize module
Module compiled with module API=20230831
PHP    compiled with module API=20240924
These options need to match
 in Unknown on line 0
Importing Files

Importing cutie.png...failed. (Could not store file "importtest/cutie.png" at "mwstore&#58;//local-backend/local-public/c/ce/Cutie.png".)

Found: 1
Failed: 1
> echo $?
0

What happens?:
importImages.php exits with return code 0 even though a file failed to import

What should have happened instead?:
It should've returned a non-zero exit code (such as 1)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

MediaWiki: 1.43.0 (aebca8e) 06:24, 11 February 2025
PHP: 8.4.4 (fpm-fcgi)
MariaDB: 11.6.2-MariaDB

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
ImportImages: Exit with non-zero code if import fails	mediawiki/core	REL1_43	+5 -1
ImportImages: Exit with non-zero code if import fails	mediawiki/core	REL1_42	+5 -1
ImportImages: Exit with non-zero code if import fails	mediawiki/core	REL1_39	+5 -1
ImportImages: Exit with non-zero code if import fails	mediawiki/core	master	+5 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMWaebca8ecc83b: Update git submodules

Event Timeline

BlankEclair created this task.Mar 8 2025, 4:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2025, 4:53 AM

BlankEclair claimed this task.Mar 8 2025, 6:10 AM

Change #1125580 had a related patch set uploaded (by BlankEclair; author: BlankEclair):

[mediawiki/core@master] ImportImages: Exit with non-zero code if a file fails to import

https://gerrit.wikimedia.org/r/1125580

gerritbot added a project: Patch-For-Review.Mar 8 2025, 6:12 AM

taavi edited projects, added MediaWiki-File-management; removed MediaWiki-Core-Snapshots.Mar 8 2025, 8:48 AM

Change #1125580 merged by jenkins-bot:

[mediawiki/core@master] ImportImages: Exit with non-zero code if import fails

https://gerrit.wikimedia.org/r/1125580

Maintenance_bot added a project: Commons.Mar 8 2025, 9:31 AM

Maintenance_bot removed a project: Patch-For-Review.

taavi closed this task as Resolved.Mar 8 2025, 9:57 AM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 8 2025, 10:00 AM

Change #1125585 had a related patch set uploaded (by BlankEclair; author: BlankEclair):

[mediawiki/core@REL1_43] ImportImages: Exit with non-zero code if import fails

https://gerrit.wikimedia.org/r/1125585

Change #1125586 had a related patch set uploaded (by BlankEclair; author: BlankEclair):

[mediawiki/core@REL1_42] ImportImages: Exit with non-zero code if import fails

https://gerrit.wikimedia.org/r/1125586

Change #1125587 had a related patch set uploaded (by BlankEclair; author: BlankEclair):

[mediawiki/core@REL1_39] ImportImages: Exit with non-zero code if import fails

https://gerrit.wikimedia.org/r/1125587

Change #1125587 merged by jenkins-bot:

[mediawiki/core@REL1_39] ImportImages: Exit with non-zero code if import fails

https://gerrit.wikimedia.org/r/1125587

Change #1125586 merged by jenkins-bot:

[mediawiki/core@REL1_42] ImportImages: Exit with non-zero code if import fails

https://gerrit.wikimedia.org/r/1125586

Change #1125585 merged by jenkins-bot: