What/Why:
While debugging the ZWrapper class on large zobjects, there were spotted some cases when both the scope property of the current instance and parent were undefined || null; ATM I'm guessing whenever at the top of the chain. We need to gracefully handle this edge case.
Ultimately, my aim is to figure out why the the size_ doesn't increment properly.
How:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| wikifunctions: Update orchestrator from 2025-03-05-140247 to 2025-03-11-234105 | operations/deployment-charts | master | +1 -1 |
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| handle null when Scope top of chain | repos/abstract-wiki/wikifunctions/function-orchestrator!305 | ecarg | grace/T388298/scope-null-handling | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ecarg | T383157 [25Q3] Improve performance and drive down tech debt & developer inhibitors | |||
| Resolved | ecarg | T388298 handle null cases for Scope |
Should we be worried about circular references?
I.e.
root = { scope_: undefined };
child = { scope_: undefined, parent_: root };
root.parent_ = child;is there a base case? if not, this stack would crash?
ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/305
Draft: handle null when Scope top of chain
apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/305
handle null when Scope top of chain
Change #1126996 had a related patch set uploaded (by Jforrester; author: Jforrester):
[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-05-140247 to 2025-03-11-234105
Change #1126996 merged by jenkins-bot:
[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-05-140247 to 2025-03-11-234105