Why
- if I'm reading the code right, the vue toolbar is the default experience, and the old toolbar can be turned on by adding ?pagetriage_ui=old to the URL
- I think we should go all in on using the vue toolbar. trying to simultaneously keep the old toolbar around causes problems such as code duplication (and it diverging over time), confusion about which file(s) are best to modify when making a patch, dead code, etc.
- it also causes confusion around whether ?pagetriage_ui= and ?pagetriage_tb= are in use, when to use them, etc. I had to read through code for several minutes to figure out the current state of things
What
- remove 5 instances of pagetriage_ui (CodeSearch), making the vue toolbar the default
- check for and make sure we've deleted old toolbar files that are no longer in use. as of March 2025, we've rewritten the following toolbar features / buttons / flyouts in vue, so their old toolbar equivalents can be deleted: