Page MenuHomePhabricator
Create Task
Maniphest T388393

CodeMirror Icon not compatible with dark mode
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • In RTL wiki (ex. ar.wikipedia.org) using activate Code Mirror from beta features
  • Activate Dark mode in Vector-2022
  • Open source editor in any wikitext page

What happens?:
CodeMirror icon still black

What should have happened instead?:
White CodeMirror icon as all other toolbar icons

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
codemirror.wikieditor.less: make Syntax button dark mode friendlymediawiki/extensions/CodeMirrormaster+1 -1
Customize query in gerrit

Event Timeline

hubaishan created this task.Mar 10 2025, 11:51 AM
Restricted Application added subscribers: alaa, Aklapper. · View Herald TranscriptMar 10 2025, 11:51 AM
• MusikAnimal subscribed.Mar 11 2025, 9:32 AM
This comment was removed by • MusikAnimal.
gerritbot added a comment.Mar 11 2025, 9:42 AM

Change #1126507 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] codemirror.wikieditor.less: make Syntax button dark mode friendly

https://gerrit.wikimedia.org/r/1126507

gerritbot added a project: Patch-For-Review.Mar 11 2025, 9:42 AM
• MusikAnimal changed the task status from Open to In Progress.Mar 11 2025, 9:43 AM
• MusikAnimal claimed this task.
• MusikAnimal moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.
gerritbot added a comment.Mar 13 2025, 5:08 AM

Change #1126507 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] codemirror.wikieditor.less: make Syntax button dark mode friendly

https://gerrit.wikimedia.org/r/1126507

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2025, 5:30 AM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 13 2025, 6:00 AM
• MusikAnimal closed this task as Resolved.Mar 19 2025, 10:42 PM
• MusikAnimal moved this task from Bugs to Done on the MediaWiki-extensions-CodeMirror board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits