Page MenuHomePhabricator
Create Task
Maniphest T388428

Using hidepatrolled on Special:Newfiles is hiding unpatrolled files
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • NO files are displayed

What should have happened instead?:

  • A gallery of unpatrolled new files displays

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
WMF Production

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
NewFilesPager: Fix condition in unpatrolled file querymediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Xaosflux created this task.Mar 10 2025, 3:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2025, 3:59 PM
matmarex subscribed.Mar 10 2025, 4:29 PM
1AmNobody24 subscribed.Mar 11 2025, 7:27 AM

Is "Hide patrolled uploads" an admin-only option?

Xaosflux added a comment.Mar 11 2025, 9:15 AM

Apparently that option is only available if the user has (patrol) permissions (so on enwiki that is sysop, patroller)

Xaosflux added a comment.Mar 11 2025, 9:17 AM

image.png (280×331 px, 12 KB)

1AmNobody24 added a comment.Mar 11 2025, 10:26 AM

Looks like it was made that way in T11501, don't think there was a discussion about it, but I think that the option should be available for everyone. (Might be something for a new ticket.)

Pppery moved this task from To triage to Multimedia-related on the MediaWiki-Special-pages board.Mar 11 2025, 4:26 PM
matmarex claimed this task.Mar 11 2025, 5:15 PM
matmarex added a subscriber: Ladsgroup.
gerritbot added a comment.Mar 11 2025, 5:15 PM

Change #1126606 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] NewFilesPager: Fix condition in unpatrolled file query

https://gerrit.wikimedia.org/r/1126606

gerritbot added a project: Patch-For-Review.Mar 11 2025, 5:15 PM
gerritbot added a comment.Mar 11 2025, 7:29 PM

Change #1126606 merged by jenkins-bot:

[mediawiki/core@master] NewFilesPager: Fix condition in unpatrolled file query

https://gerrit.wikimedia.org/r/1126606

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 7:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 11 2025, 8:00 PM
matmarex closed this task as Resolved.Mar 11 2025, 9:27 PM

The fix will be deployed to Wikimedia wikis next week, on the usual schedule.

1AmNobody24 added a comment.Mar 12 2025, 6:46 AM

@matmarex Do you have a opinion on the option should be available for everyone. (Might be something for a new ticket.)?

matmarex added a comment.Mar 12 2025, 11:49 AM

Not really, but I agree that it should be discussed in a new ticket.

For what it's worth, this behavior seems consistent with other patrolling features – you don't get the options to show/hide unpatrolled items on Special:RecentChanges and Special:NewPages either, if you're not a patroller. I don't know why it is implemented this way, but it seems to have been so since ancient times.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits