Page MenuHomePhabricator

Using hidepatrolled on Special:Newfiles is hiding unpatrolled files
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • NO files are displayed

What should have happened instead?:

  • A gallery of unpatrolled new files displays

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
WMF Production

Other information (browser name/version, screenshots, etc.):

Related Objects

Event Timeline

Is "Hide patrolled uploads" an admin-only option?

Apparently that option is only available if the user has (patrol) permissions (so on enwiki that is sysop, patroller)

Looks like it was made that way in T11501, don't think there was a discussion about it, but I think that the option should be available for everyone. (Might be something for a new ticket.)

Change #1126606 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] NewFilesPager: Fix condition in unpatrolled file query

https://gerrit.wikimedia.org/r/1126606

Change #1126606 merged by jenkins-bot:

[mediawiki/core@master] NewFilesPager: Fix condition in unpatrolled file query

https://gerrit.wikimedia.org/r/1126606

The fix will be deployed to Wikimedia wikis next week, on the usual schedule.

@matmarex Do you have a opinion on the option should be available for everyone. (Might be something for a new ticket.)?

Not really, but I agree that it should be discussed in a new ticket.

For what it's worth, this behavior seems consistent with other patrolling features – you don't get the options to show/hide unpatrolled items on Special:RecentChanges and Special:NewPages either, if you're not a patroller. I don't know why it is implemented this way, but it seems to have been so since ancient times.