Page MenuHomePhabricator

Donate Button: Fix animation spacing for GIF
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

This task address fixing visual spacing issues with the new donate button on MinervaNeue.

User story

As a Wikimedia reader, I expect the sidebar menu items on mobile Wikipedia to have consistent alignment and spacing .

Requirements

  • Adjust the animation spacing so that the space between the animation and the right edge of the menu remains consistent across different resolutions. The space between the text and the illustration should increase at higher resolutions.

BDD

Scenario 1: Animation spacing adjusts correctly at different resolutions

Given I am viewing the page at a smaller resolution
When I observe the animation placement
Then The space between the animation and the right edge of the menu should remain consistent

Test Steps

Test Case 1: Verify Donation banner animation spacing

  1. AC1: Verify that, in an incognito window, the spacing behaves correctly at various resolutions.

Design

image (1).png (1×1 px, 211 KB)

Acceptance criteria

  • The animation maintains consistent spacing at different resolutions.

QA Results - Beta

ACStatusDetails
1T388443#10629360

QA Results -Prod

ACStatusDetails
1T388443#10644954

This task was created by Version 1.2.0 of the Web team task template using phabulous

Details

Related Changes in Gerrit:

Event Timeline

Jdrewniak set the point value for this task to 1.
Jdrewniak added a subscriber: KSarabia-WMF.

Change #1126153 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/MinervaNeue@master] Fix spacing for donate btn

https://gerrit.wikimedia.org/r/1126153

Change #1126153 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix spacing for donate btn

https://gerrit.wikimedia.org/r/1126153

Test Steps

Status: ✅ PASS
Environment: cawiki
OS: macOS
Browser: Chrome
Device: MS

Test Case 1: Verify Donation banner animation spacing

  1. ✅ AC1: Verify that, in an incognito window, the spacing behaves correctly at various resolutions.

screenshot 25.mov.gif (894×1 px, 2 MB)

screenshot 24.mov.gif (894×1 px, 2 MB)