TextWithIconWidget is currently built as an OOUI widget. It should be rewritten using CSS-only Codex (likely a thin wrapper around the Icon component), which would help us with:
Description
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MHorsey-WMF | T385347 [EPIC] Create embeddable version of the Collaboration List | |||
| Resolved | Daimona | T388427 Make sure there are no transclusion bugs due to global state access when transcluding Special:AllEvents | |||
| Open | None | T386102 Make sure CampaignEvents special pages look reasonably OK on Monobook and Timeless | |||
| Resolved | Daimona | T388451 Convert TextWithIconWidget to Codex | |||
| Resolved | BUG REPORT | MHorsey-WMF | T391296 Wiki logo for event is not displaying on event page dialog and SpecialEventDetails | ||
| Resolved | BUG REPORT | None | T391381 Online/In-person, location, wikis, and organizers icons are missing on Special:AllEvents |
Event Timeline
From my initial look, this seems much harder than I thought due to how icon works in the CSS-only version... Maybe not, but for the time being this is blocked on the subtask.
Yup, we use this component in a few places to present unlabeled information (i.e., the icon, or its accessibility text, are the label). Some example links are:
- https://meta.wikimedia.org/wiki/Special:AllEvents: the information about each event, like location and organizers
- Event pages like https://meta.wikimedia.org/wiki/Event:Central_Notice_Requester_Training, for the same event information shown in the header
Change #1130127 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] TextWithIconWidget: return string instead of widget instance
Change #1130127 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] TextWithIconWidget: return string instead of widget instance
Change #1131847 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Convert TextWithIconWidget to Codex
Change #1131847 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Convert TextWithIconWidget to Codex
On second thought, I think it would make sense to have this go through QA. @vaughnwalters There isn't much to test here: we've updated the widgets used in Special:AllEvents and in the event page registration header to use Codex. They should look exactly the same as before, except for minor spacing and colour differences that are expected. Everything else should be the same (content, icons, accessibility text).
To clarify: the widgets in question are the ones I circled in red in this hi-tech, AI-powered, quantum-computing-assisted image:
Change #1133930 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Stop loading OOUI icons previously used with TextWithIconWidget
Change #1133930 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Stop loading OOUI icons previously used with TextWithIconWidget
Change #1136759 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Re-apply "Convert TextWithIconWidget to Codex"
Change #1136759 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Re-apply "Convert TextWithIconWidget to Codex"
This is working as expected now. Also, I appreciate your quantum computing / MS-Paint mashup @Daimona . Quick check, I didn't see cdx-icon as a class for any of these, is that expected? If so, this is good to go to design sign off
| Special:EventDetails | Special:AllEvents | Event page |
I think so. According to the docs, there are no standard classes for icons. Is there some documentation page suggesting otherwise?
I'm not sure if that's standard, at least for the CSS-only version. None of the examples linked above have it, and I'd be leaning towards following those examples.



