Page MenuHomePhabricator

[regression, subtask] Table of contents dropdown icons overlapping with text
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT

Assigned To
Authored By
SToyofuku-WMF
Mar 11 2025, 12:02 AM
Referenced Files
F58822144: screenshot 113.png
Mar 14 2025, 12:19 AM
F58822143: screenshot 112.png
Mar 14 2025, 12:19 AM
F58822142: screenshot 114.png
Mar 14 2025, 12:19 AM
F58822141: screenshot 111.png
Mar 14 2025, 12:19 AM
F58766898: capture.png
Mar 11 2025, 2:38 AM
F58764474: image.png
Mar 11 2025, 12:02 AM

Description

Steps to replicate the issue (include links if applicable):

What happens?:

icons overlap the text, due to an invalid property value left: -22px/2;

What should have happened instead?:

Division should be parenthesized: https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/cd8a65ed977b11d3765d7208e7cccec007070a94/resources/skins.vector.styles/components/TableOfContents.less#19

Icons should appear to the left of the text

Requirement

Ensure that Table of Contents (ToC) dropdown icons in Vector are properly positioned and do not overlap with text by correcting the invalid property value in the beta cluster.

BDD

Feature: Fix Table of Contents dropdown icons overlapping with text  

  Scenario: ToC icons do not overlap with text  
    Given I visit the Polar Bear article on the beta cluster  
    When I observe the Table of Contents  
    Then the icons should be correctly positioned  
    And they should appear to the left of the text

Test Steps

Test Case 1: Verify ToC dropdown icons are correctly positioned

  1. Visit Polar Bear article on beta.
  2. Locate the Table of Contents (ToC).
  3. AC1: Confirm that the dropdown icons do not overlap with the text.
  4. AC2: Confirm that the icons appear correctly to the left of the text.

Other information (browser name/version, screenshots, etc.):

image.png (490×560 px, 45 KB)

QA Results - Beta

ACStatusDetails
1T388475#10635232
2T388475#10635232

Event Timeline

Change #1126194 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Revert "ResourceLoader: Enable Less.php math=parens-division"

https://gerrit.wikimedia.org/r/1126194

Change #1126200 had a related patch set uploaded (by Hokwelum; author: Hokwelum):

[mediawiki/skins/Vector@master] Prepare Less styles for math=parens-division

https://gerrit.wikimedia.org/r/1126200

Change #1126200 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix missing parens in TableOfContents.less

https://gerrit.wikimedia.org/r/1126200

Krinkle claimed this task.
Krinkle subscribed.

Fixed and verified https://en.wikipedia.beta.wmflabs.org/wiki/Polar_bear?useskin=vector-2022

capture.png (1,310×916 px, 142 KB)

The 1.44.0-wmf.20 branch cut is ~1 hour from now, so no backport/deploy needed.

The 1.44.0-wmf.20 branch cut is ~1 hour from now, so no backport/deploy needed.

When I click on Included in on https://gerrit.wikimedia.org/r/1126200, I don’t see 1.44.0-wmf.20. Are you sure it doesn’t need a backport?

The 1.44.0-wmf.20 branch cut is ~1 hour from now, so no backport/deploy needed.

When I click on Included in on https://gerrit.wikimedia.org/r/1126200, I don’t see 1.44.0-wmf.20. Are you sure it doesn’t need a backport?

Indeed, it didn't make it: https://www.mediawiki.org/wiki/MediaWiki_1.44/wmf.20#Vector

Change #1126550 had a related patch set uploaded (by Jforrester; author: Hokwelum):

[mediawiki/skins/Vector@wmf/1.44.0-wmf.20] Fix missing parens in TableOfContents.less

https://gerrit.wikimedia.org/r/1126550

Change #1126567 had a related patch set uploaded (by Gergő Tisza; author: Jdlrobson):

[mediawiki/core@wmf/1.44.0-wmf.20] Revert "ResourceLoader: Enable Less.php math=parens-division"

https://gerrit.wikimedia.org/r/1126567

Change #1126194 abandoned by Jdlrobson:

[mediawiki/core@master] Revert "ResourceLoader: Enable Less.php math=parens-division"

Reason:

being addressed elsewhere. thank you!

https://gerrit.wikimedia.org/r/1126194

Change #1126567 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.20] Revert "ResourceLoader: Enable Less.php math=parens-division"

https://gerrit.wikimedia.org/r/1126567

Mentioned in SAL (#wikimedia-operations) [2025-03-11T15:07:30Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1126567|Revert "ResourceLoader: Enable Less.php math=parens-division" (T388475 T388526)]], [[gerrit:1126546|Enable SUL3 signup for 10% of group 2 users (T384218)]], [[gerrit:1126555|Disable CX unified dashboard on idwiki (T387820)]]

Mentioned in SAL (#wikimedia-operations) [2025-03-11T15:10:31Z] <lucaswerkmeister-wmde@deploy2002> sbisson, tgr, lucaswerkmeister-wmde: Backport for [[gerrit:1126567|Revert "ResourceLoader: Enable Less.php math=parens-division" (T388475 T388526)]], [[gerrit:1126546|Enable SUL3 signup for 10% of group 2 users (T384218)]], [[gerrit:1126555|Disable CX unified dashboard on idwiki (T387820)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-03-11T15:24:52Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1126567|Revert "ResourceLoader: Enable Less.php math=parens-division" (T388475 T388526)]], [[gerrit:1126546|Enable SUL3 signup for 10% of group 2 users (T384218)]], [[gerrit:1126555|Disable CX unified dashboard on idwiki (T387820)]] (duration: 17m 22s)

Jdlrobson-WMF lowered the priority of this task from Unbreak Now! to Medium.

This train blocker has been resolved, correct?

Jdlrobson-WMF set the point value for this task to 0.Mar 13 2025, 4:51 PM

Web team doesn't point subtasks/regressions related to committed work so adding 0 points to make that clearer.

Edtadros subscribed.

Test Steps

Status: ✅ PASS
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS

Test Case 1: Verify ToC dropdown icons are correctly positioned

  1. Visit Polar Bear article on beta.
  2. Locate the Table of Contents (ToC).
  3. AC1: Confirm that the dropdown icons do not overlap with the text.
  4. AC2: Confirm that the icons appear correctly to the left of the text.
screenshot 111.png (254×654 px, 39 KB)
screenshot 114.png (298×608 px, 50 KB)
screenshot 112.png (308×706 px, 63 KB)
screenshot 113.png (367×740 px, 99 KB)

Change #1126550 abandoned by Jforrester:

[mediawiki/skins/Vector@wmf/1.44.0-wmf.20] Fix missing parens in TableOfContents.less

https://gerrit.wikimedia.org/r/1126550