Page MenuHomePhabricator

Make "rejection reason" a required field for vanish requests
Closed, ResolvedPublic

Description

The current implementation of the Account Vanishing flow, has the "rejection reason" field set as optional.

After discussion with the team and approval from the Steward, we would like to make this change and ensure that the field is "required".

AC:

  • Make the field required for the manual flow
  • Make sure that the automated flow (that is run when someone has a block) already has a reason and does not break with the above change
  • Ensure the field is not affecting the normal "approved" flow (both manual and automatic)

Details

Other Assignee
Amdrel
Related Changes in Gerrit:

Event Timeline

Change #1126672 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/CentralAuth@master] Require a rejection reason for vanish requests

https://gerrit.wikimedia.org/r/1126672

I uploaded a patch that makes the reason required only for vanish rejections while retaining the old behavior for renames.

Make sure that the automated flow (that is run when someone has a block) already has a reason and does not break with the above change

Special:GlobalVanishRequest doesn't render the form needed to create the rename request when the user is blocked, so there's no request to add a rejection reason to.

Amdrel changed the task status from Open to In Progress.Mar 11 2025, 10:09 PM
matmarex subscribed.

I guess this should have been on the Trust and Safety Product Team workboard, and it was forgotten because it wasn't tagged with anything.

I guess this should have been on the Trust and Safety Product Team workboard, and it was forgotten because it wasn't tagged with anything.

Thanks. Not sure how this was dropped.

I did a minor update in the existing patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1126672/4 and verified locally the request fails if the reason is not provided.

Change #1126672 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Require a rejection reason for vanish requests

https://gerrit.wikimedia.org/r/1126672

Djackson-ctr subscribed.

New Code Changes have been implemented and verified (Special:GlobalRenameQueue/request: If user leaves Notes/reasoning field blank, then select Reject Vanishing, the user will be presented with an error message A reason must be provided for rejected vanish requests)...

QA was completed for this ticket using LocalHost: Mediawiki 1.45.0-alpha (0713c73)...

Testing was performed on various: Skins, Desktop View/MobileView, Chrome/Edge/Firefox/Safari, Windows/Mac/Android/iOS, RTL languages.