Page MenuHomePhabricator
Create Task
Maniphest T388588

Rename classes and methods on page related events to match the design document
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Per discussion on the design document, we agreed to:

  • Rename methods and classes, while keeping the old names functional
    • rename PageEvent to PageStateEvent (with the idea to introduce another parent class, PageAggregateEvent, that would also cover the revision history)
    • rename PageUpdatedEvent to PageRevisionUpdatedEvent event
    • on PageRevisionUpdatedEvent, rename getNewRevision and getOldRevision to getLatestRevisionAfter and getLatestRevisionBefore
    • replace getPage with getPageId and getPageRecordBefore and getPageRecordAfter
  • Rename methods and classes in extensions:
    • CommunityConfiguration
    • GrowthExperiments
    • ContentTranslation
    • Linter
    • Wikistories
    • Gadgets
  • Remove aliases for methods and classes

Details

Other Assignee
daniel
Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Mar 11 2025, 6:18 PM
gerritbot added a comment.Mar 11 2025, 6:31 PM

Change #1126624 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] DomainEvents: Rename PageEvent and PageUpdatedEvent

https://gerrit.wikimedia.org/r/1126624

gerritbot added a project: Patch-For-Review.Mar 11 2025, 6:31 PM
gerritbot added a comment.Mar 12 2025, 12:01 PM

Change #1126970 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] DomainEvents: Rename getOldRevision and getNewRevision

https://gerrit.wikimedia.org/r/1126970

gerritbot added a comment.Mar 14 2025, 1:02 AM

Change #1126624 merged by jenkins-bot:

[mediawiki/core@master] DomainEvents: Rename PageEvent and PageUpdatedEvent

https://gerrit.wikimedia.org/r/1126624

gerritbot added a comment.Mar 17 2025, 1:09 PM

Change #1127105 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] DomainEvents: Model page state before/after

https://gerrit.wikimedia.org/r/1127105

daniel updated the task description. (Show Details)Mar 17 2025, 1:12 PM
daniel moved this task from Committed to In Progress on the MW-Interfaces-Team (MWI-Sprint-5 (2025-03-11 to 2025-03-25)) board.Mar 17 2025, 1:14 PM
gerritbot added a comment.Mar 17 2025, 10:42 PM

Change #1126970 merged by jenkins-bot:

[mediawiki/core@master] DomainEvents: Rename getOldRevision and getNewRevision

https://gerrit.wikimedia.org/r/1126970

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 17 2025, 11:00 PM
daniel added a comment.Mar 19 2025, 9:40 AM

Decided to change PageStateBefore/After to PageRecordBefore/After, because the page record does not cover all of the page state. Events representing changes to visibility or protection would not be reflected in the page record, so calling it "the page state" would be confusing.

daniel updated the task description. (Show Details)Mar 19 2025, 9:41 AM
daniel updated the task description. (Show Details)Mar 21 2025, 7:53 AM
HCoplin-WMF edited projects, added MW-Interfaces-Team (MWI-Sprint-6 (2025-03-25 to 2025-04-08)); removed MW-Interfaces-Team (MWI-Sprint-5 (2025-03-11 to 2025-03-25)).Mar 25 2025, 2:34 PM
HCoplin-WMF moved this task from Committed to In Progress on the MW-Interfaces-Team (MWI-Sprint-6 (2025-03-25 to 2025-04-08)) board.
gerritbot added a comment.Mar 25 2025, 10:32 PM

Change #1127105 merged by jenkins-bot:

[mediawiki/core@master] DomainEvents: Model page state before/after

https://gerrit.wikimedia.org/r/1127105

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 25 2025, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 25 2025, 11:30 PM
daniel updated the task description. (Show Details)Mar 26 2025, 8:01 AM
aaron claimed this task.Mar 26 2025, 5:56 PM
aaron updated Other Assignee, added: daniel.
gerritbot added a comment.Apr 4 2025, 6:16 AM

Change #1134114 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/extensions/Wikistories@master] EventIngress: use getDeletedPage instead of getPageStateBefore

https://gerrit.wikimedia.org/r/1134114

gerritbot added a project: Patch-For-Review.Apr 4 2025, 6:16 AM
daniel triaged this task as High priority.Apr 4 2025, 7:27 AM
daniel lowered the priority of this task from High to Medium.
gerritbot added a comment.Apr 4 2025, 6:03 PM

Change #1134114 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] EventIngress: use getDeletedPage instead of getPageStateBefore

https://gerrit.wikimedia.org/r/1134114

Maintenance_bot removed a project: Patch-For-Review.Apr 4 2025, 6:31 PM
gerritbot added a comment.Apr 7 2025, 6:21 AM

Change #1134400 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/extensions/Wikistories@wmf/1.44.0-wmf.23] EventIngress: use getDeletedPage instead of getPageStateBefore

https://gerrit.wikimedia.org/r/1134400

gerritbot added a project: Patch-For-Review.Apr 7 2025, 6:21 AM
gerritbot added a comment.Apr 7 2025, 6:39 AM

Change #1134400 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@wmf/1.44.0-wmf.23] EventIngress: use getDeletedPage instead of getPageStateBefore

https://gerrit.wikimedia.org/r/1134400

Stashbot added a comment.Apr 7 2025, 6:40 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-07T06:40:16Z] <daniel@deploy1003> Started scap sync-world: Backport for [[gerrit:1134400|EventIngress: use getDeletedPage instead of getPageStateBefore (T388588 T391051)]]

Stashbot mentioned this in T391051: Error: Call to undefined method MediaWiki\Page\Event\PageDeletedEvent::getPageStateBefore().Apr 7 2025, 6:40 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 7 2025, 7:30 AM
Stashbot added a comment.Apr 7 2025, 8:12 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-07T08:12:33Z] <daniel@deploy1003> Started scap sync-world: Backport for [[gerrit:1134400|EventIngress: use getDeletedPage instead of getPageStateBefore (T388588 T391051)]]

Stashbot added a comment.Apr 7 2025, 8:53 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-07T08:53:20Z] <daniel@deploy1003> Started scap sync-world: Backport for [[gerrit:1134400|EventIngress: use getDeletedPage instead of getPageStateBefore (T388588 T391051)]]

Stashbot added a comment.Apr 7 2025, 8:58 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-07T08:58:48Z] <daniel@deploy1003> daniel: Backport for [[gerrit:1134400|EventIngress: use getDeletedPage instead of getPageStateBefore (T388588 T391051)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Apr 7 2025, 9:13 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-07T09:13:03Z] <daniel@deploy1003> Finished scap sync-world: Backport for [[gerrit:1134400|EventIngress: use getDeletedPage instead of getPageStateBefore (T388588 T391051)]] (duration: 19m 43s)

gerritbot added a comment.Apr 7 2025, 6:37 PM

Change #1134745 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/extensions/CommunityConfiguration@master] Rename classes and methods on page related events to match the design document

https://gerrit.wikimedia.org/r/1134745

gerritbot added a project: Patch-For-Review.Apr 7 2025, 6:37 PM
gerritbot added a comment.Apr 7 2025, 6:41 PM

Change #1134749 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/extensions/Wikistories@master] Rename classes and methods on page related events to match the design document

https://gerrit.wikimedia.org/r/1134749

gerritbot added a comment.Apr 7 2025, 7:15 PM

Change #1134743 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/extensions/ContentTranslation@master] Rename classes and methods on page related events to match the design document

https://gerrit.wikimedia.org/r/1134743

gerritbot added a comment.Apr 7 2025, 7:24 PM

Change #1134747 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/extensions/Linter@master] Rename classes and methods on page related events to match core

https://gerrit.wikimedia.org/r/1134747

gerritbot added a comment.Apr 7 2025, 7:26 PM

Change #1134744 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/extensions/GrowthExperiments@master] Rename classes and methods on page related events to match core

https://gerrit.wikimedia.org/r/1134744

gerritbot added a comment.Apr 7 2025, 7:29 PM

Change #1134750 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/extensions/Gadgets@master] Rename classes and methods on page related events to match the design document

https://gerrit.wikimedia.org/r/1134750

aaron set the point value for this task to 2.Apr 8 2025, 2:30 PM
aaron moved this task from In Progress to Code Review on the MW-Interfaces-Team (MWI-Sprint-6 (2025-03-25 to 2025-04-08)) board.Apr 8 2025, 2:36 PM
HCoplin-WMF edited projects, added MW-Interfaces-Team (MWI-Sprint-7 (2025-04-08 to 2025-04-22)); removed MW-Interfaces-Team (MWI-Sprint-6 (2025-03-25 to 2025-04-08)).Apr 8 2025, 2:56 PM
HCoplin-WMF moved this task from Committed to Code Review on the MW-Interfaces-Team (MWI-Sprint-7 (2025-04-08 to 2025-04-22)) board.
gerritbot added a comment.Apr 9 2025, 10:24 PM

Change #1135512 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] [WIP] Remove deprecated DomainEvent-related alias classes and methods

https://gerrit.wikimedia.org/r/1135512

gerritbot added a comment.Apr 10 2025, 8:29 AM

Change #1134747 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Rename classes and methods on page related events to match core

https://gerrit.wikimedia.org/r/1134747

gerritbot added a comment.Apr 10 2025, 8:35 AM

Change #1134750 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Rename classes and methods on page related events to match core

https://gerrit.wikimedia.org/r/1134750

gerritbot added a comment.Apr 11 2025, 3:08 PM

Change #1134749 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Update classes and methods on page related events to match core

https://gerrit.wikimedia.org/r/1134749

gerritbot added a comment.Apr 14 2025, 11:37 AM

Change #1134743 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Rename classes and methods on page related events to match core

https://gerrit.wikimedia.org/r/1134743

gerritbot added a comment.Apr 14 2025, 12:45 PM

Change #1134745 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Rename classes and methods on page related events to match core

https://gerrit.wikimedia.org/r/1134745

aaron mentioned this in rECOMb6aa4f2acc2f: Rename classes and methods on page related events to match core.Apr 14 2025, 12:53 PM
daniel updated the task description. (Show Details)Apr 15 2025, 3:29 PM
daniel updated the task description. (Show Details)
gerritbot added a comment.Apr 15 2025, 4:21 PM

Change #1134744 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Rename classes and methods on page related events to match core

https://gerrit.wikimedia.org/r/1134744

daniel updated the task description. (Show Details)Apr 15 2025, 4:37 PM
HCoplin-WMF edited projects, added MW-Interfaces-Team (MW-Sprint-8 (2025-04-23 to 2025-05-06)); removed MW-Interfaces-Team (MWI-Sprint-7 (2025-04-08 to 2025-04-22)).Apr 23 2025, 4:29 PM
HCoplin-WMF moved this task from Committed to Code Review on the MW-Interfaces-Team (MW-Sprint-8 (2025-04-23 to 2025-05-06)) board.
daniel mentioned this in T393006: Revisit page event names.Apr 30 2025, 1:14 PM
gerritbot added a comment.May 1 2025, 2:30 PM

Change #1135512 merged by jenkins-bot:

[mediawiki/core@master] DomainEvents: Remove deprecated DomainEvent-related alias classes and methods

https://gerrit.wikimedia.org/r/1135512

Maintenance_bot removed a project: Patch-For-Review.May 1 2025, 3:30 PM
aaron moved this task from Code Review to Demo Ready! on the MW-Interfaces-Team (MW-Sprint-8 (2025-04-23 to 2025-05-06)) board.May 1 2025, 3:45 PM
daniel added a comment.May 2 2025, 7:39 AM

@aaron This is complete now, right?

daniel removed a subtask: T393867: Events: rename PageState and PageRevisionUpdated.May 12 2025, 7:57 AM
HCoplin-WMF edited projects, added MW-Interfaces-Team (MW-Sprint-9 (2025-05-07 to 2025-05-20)); removed MW-Interfaces-Team (MW-Sprint-8 (2025-04-23 to 2025-05-06)).May 12 2025, 11:51 AM
HCoplin-WMF moved this task from Committed to Demo Ready! on the MW-Interfaces-Team (MW-Sprint-9 (2025-05-07 to 2025-05-20)) board.
HCoplin-WMF closed this task as Resolved.May 20 2025, 4:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits