Error: No class registered by that key: null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	SToyofuku-WMF
	Mar 12 2025, 9:15 PM

Description

Huge spike in errors on group 1 wikis after rolling out:

https://logstash.wikimedia.org/goto/b733980618255f0fe911bc347faa5109

Not sure of a reproduction case yet, or the source of the error, but this lines up closely with the train rollout out to group 1 and they're all on 1.44.0-wmf.20

sample stack trace:

at OO.Factory.create  https://it.m.wikipedia.org/w/load.php?lang=it&modules=oojs&skin=minerva&version=rwdvu:16:53
at mw.editcheck.hasAddedContentNeedingReference  https://it.m.wikipedia.org/w/load.php?lang=it&modules=ext.visualEditor.editCheck&skin=minerva&version=1m1na:1:887
at ve.init.mw.ArticleTarget.save  https://it.m.wikipedia.org/w/load.php?lang=it&modules=ext.visualEditor.articleTarget&skin=minerva&version=16t1q:27:811
at ve.init.mw.MobileArticleTarget.save  https://it.m.wikipedia.org/w/load.php?lang=it&modules=ext.visualEditor.mobileArticleTarget&skin=minerva&version=f9nsh:7:281
at ve.init.mw.ArticleTarget.startSave  https://it.m.wikipedia.org/w/load.php?lang=it&modules=ext.visualEditor.articleTarget&skin=minerva&version=16t1q:25:703
at ve.init.mw.ArticleTarget.onSaveDialogSave  https://it.m.wikipedia.org/w/load.php?lang=it&modules=ext.visualEditor.articleTarget&skin=minerva&version=16t1q:25:574
at OO.EventEmitter.emit  https://it.m.wikipedia.org/w/load.php?lang=it&modules=oojs&skin=minerva&version=rwdvu:8:344
at eval  https://it.m.wikipedia.org/w/load.php?lang=it&modules=ext.visualEditor.mwsave&skin=minerva&version=1jis1:18:141
at eval  https://it.m.wikipedia.org/w/load.php?lang=it&modules=oojs-ui-windows&skin=minerva&version=srz3a:6:943
at OO.ui.Process.execute  https://it.m.wikipedia.org/w/load.php?lang=it&modules=oojs-ui-windows&skin=minerva&version=srz3a:7:619

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Follow-up Ia4b9f65b6: Fix argument order passed to EditCheckFactory#create	mediawiki/extensions/VisualEditor	wmf/1.44.0-wmf.20	+1 -1
	Follow-up Ia4b9f65b6: Fix argument order passed to EditCheckFactory#create	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T388772: Visual editor doesn't save on ca.wikipedia.org

Event Timeline

SToyofuku-WMF created this task.Mar 12 2025, 9:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2025, 9:15 PM

woo

SToyofuku-WMF added a parent task: T386215: 1.44.0-wmf.20 deployment blockers.Mar 12 2025, 9:16 PM

Pppery added a project: VisualEditor.Mar 12 2025, 9:22 PM

Pppery added a project: EditCheck.

Pppery added a project: Wikimedia-production-error.

Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald TranscriptMar 12 2025, 9:22 PM

ppelberg added a project: Editing-team (Kanban Board).Mar 12 2025, 9:23 PM

ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.

ppelberg subscribed.

Possibly relates to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1125406 but haven't been able to confirm.

Change #1127157 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Follow-up Ia4b9f65b6: Fix argument order passed to EditCheckFactory#create

https://gerrit.wikimedia.org/r/1127157

gerritbot added a project: Patch-For-Review.Mar 12 2025, 9:32 PM

ppelberg moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Mar 12 2025, 9:39 PM

Reedy moved this task from Untriaged to Mar 2025 on the Wikimedia-production-error board.Mar 12 2025, 9:51 PM

Change #1127157 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Follow-up Ia4b9f65b6: Fix argument order passed to EditCheckFactory#create

https://gerrit.wikimedia.org/r/1127157

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 12 2025, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2025, 10:30 PM

• Agusbou2015 subscribed.Mar 13 2025, 1:51 AM

Change #1127208 had a related patch set uploaded (by DLynch; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.44.0-wmf.20] Follow-up Ia4b9f65b6: Fix argument order passed to EditCheckFactory#create

https://gerrit.wikimedia.org/r/1127208

gerritbot added a project: Patch-For-Review.Mar 13 2025, 3:20 AM

ppelberg assigned this task to Esanders.Mar 13 2025, 4:58 AM

Aklapper mentioned this in T388772: Visual editor doesn't save on ca.wikipedia.org.Mar 13 2025, 11:15 AM

Aklapper merged a task: T388772: Visual editor doesn't save on ca.wikipedia.org.

Aklapper added subscribers: Lluis_tgn, Superpes15, TheresNoTime.

Titore subscribed.Mar 13 2025, 11:17 AM

Johannnes89 subscribed.Mar 13 2025, 11:34 AM

zdev merged a task: T388774: VE doesn't save my edit on it.wikipedia.org.Mar 13 2025, 11:48 AM

zdev subscribed.

There is no way to save any edit on Visual Editor in the main namespace. When pressing on Publish, there is an infinity loop. There are a lot of complains in our wiki.

IKhitron awarded a token.Mar 13 2025, 1:47 PM

IKhitron added a project: Regression.

MBH subscribed.Mar 13 2025, 1:54 PM

Surprisingly, there is no problem in group0, just tried on mediawiki.org.

Status update on deploying the fix: there’s a separate outage incident that SRE is looking at, which is blocking all deployments. One that’s done, it’s next in the queue to go out.

Change #1127208 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.44.0-wmf.20] Follow-up Ia4b9f65b6: Fix argument order passed to EditCheckFactory#create

https://gerrit.wikimedia.org/r/1127208

Mentioned in SAL (#wikimedia-operations) [2025-03-13T14:32:45Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1127208|Follow-up Ia4b9f65b6: Fix argument order passed to EditCheckFactory#create (T388722)]]

Mentioned in SAL (#wikimedia-operations) [2025-03-13T14:35:56Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde, kemayo: Backport for [[gerrit:1127208|Follow-up Ia4b9f65b6: Fix argument order passed to EditCheckFactory#create (T388722)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

In T388722#10632945, @IKhitron wrote:

Surprisingly, there is no problem in group0, just tried on mediawiki.org.

Just to explain: this would only have affected wikipedias, because the broken call only happened when edit check related tagging occurs, and we have that turned off everywhere else:

'wgVisualEditorEditCheckTagging' => [
	'default' => false,
	'wikipedia' => true,
],

Mentioned in SAL (#wikimedia-operations) [2025-03-13T14:44:16Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1127208|Follow-up Ia4b9f65b6: Fix argument order passed to EditCheckFactory#create (T388722)]] (duration: 11m 31s)

DLynch lowered the priority of this task from Unbreak Now! to High.Mar 13 2025, 2:50 PM

DLynch removed a parent task: T386215: 1.44.0-wmf.20 deployment blockers.

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

DLynch added a project: Editing QA.

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.20; 2025-03-11); removed MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 13 2025, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2025, 3:31 PM

Lluis_tgn awarded a token.Mar 15 2025, 3:14 PM

Krinkle moved this task from Mar 2025 to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:09 AM

Error ceased since Mar 18th(following deployment)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 4 2025, 9:26 PM

VPuffetMichel closed this task as Resolved.Apr 26 2025, 3:46 PM

VPuffetMichel added a project: OKR-Work.

	F58982754: image.png
	Apr 4 2025, 9:26 PM

Error: No class registered by that key: nullClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

Error: No class registered by that key: null
Closed, ResolvedPublicPRODUCTION ERROR
Actions