PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Reedy
	Mar 12 2025, 9:30 PM

Description

Error

mwversion: 1.44.0-wmf.19
reqId: a4b01599-2f4c-4cdc-9735-1f2daa4ab803
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated

Frame	Location	Call
from	/srv/mediawiki/php-1.44.0-wmf.19/includes/parser/Sanitizer.php(1149)
#0	[internal function]	MWExceptionHandler::handleError(int, string, string, int)
#1	/srv/mediawiki/php-1.44.0-wmf.19/includes/parser/Sanitizer.php(1149)	trim(null)
#2	/srv/mediawiki/php-1.44.0-wmf.19/includes/parser/Sanitizer.php(1625)	MediaWiki\Parser\Sanitizer::normalizeWhitespace(string)
#3	/srv/mediawiki/php-1.44.0-wmf.19/includes/content/WikiTextStructure.php(178)	MediaWiki\Parser\Sanitizer::stripAllTags(string)
#4	/srv/mediawiki/php-1.44.0-wmf.19/includes/content/WikiTextStructure.php(225)	MediaWiki\Content\WikiTextStructure->extractWikitextParts()
#5	/srv/mediawiki/php-1.44.0-wmf.19/includes/content/WikitextContentHandler.php(216)	MediaWiki\Content\WikiTextStructure->getOpeningText()
#6	/srv/mediawiki/php-1.44.0-wmf.19/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(106)	MediaWiki\Content\WikitextContentHandler->getDataForSearchIndex(WikiPage, MediaWiki\Parser\ParserOutput, CirrusSearch\CirrusSearch, MediaWiki\Revision\RevisionStoreRecord)
#7	/srv/mediawiki/php-1.44.0-wmf.19/includes/libs/objectcache/WANObjectCache.php(1834)	CirrusSearch\BuildDocument\ParserOutputPageProperties->CirrusSearch\BuildDocument\{closure}(bool, int, array, null, array)
#8	/srv/mediawiki/php-1.44.0-wmf.19/includes/libs/objectcache/WANObjectCache.php(1639)	Wikimedia\ObjectCache\WANObjectCache->fetchOrRegenerate(string, int, Closure, array, array)
#9	/srv/mediawiki/php-1.44.0-wmf.19/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(109)	Wikimedia\ObjectCache\WANObjectCache->getWithSetCallback(string, int, Closure)
#10	/srv/mediawiki/php-1.44.0-wmf.19/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(51)	CirrusSearch\BuildDocument\ParserOutputPageProperties->finalizeReal(Elastica\Document, WikiPage, CirrusSearch\CirrusSearch, MediaWiki\Revision\RevisionStoreRecord)
#11	/srv/mediawiki/php-1.44.0-wmf.19/extensions/CirrusSearch/includes/BuildDocument/BuildDocument.php(200)	CirrusSearch\BuildDocument\ParserOutputPageProperties->finalize(Elastica\Document, MediaWiki\Title\Title, MediaWiki\Revision\RevisionStoreRecord)
#12	/srv/mediawiki/php-1.44.0-wmf.19/extensions/CirrusSearch/includes/Api/QueryBuildDocument.php(115)	CirrusSearch\BuildDocument\BuildDocument->finalize(Elastica\Document, bool, MediaWiki\Revision\RevisionStoreRecord)
#13	/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiQuery.php(728)	CirrusSearch\Api\QueryBuildDocument->execute()
#14	/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiMain.php(2005)	MediaWiki\Api\ApiQuery->execute()
#15	/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiMain.php(947)	MediaWiki\Api\ApiMain->executeAction()
#16	/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiMain.php(918)	MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#17	/srv/mediawiki/php-1.44.0-wmf.19/includes/api/ApiEntryPoint.php(152)	MediaWiki\Api\ApiMain->execute()
#18	/srv/mediawiki/php-1.44.0-wmf.19/includes/MediaWikiEntryPoint.php(202)	MediaWiki\Api\ApiEntryPoint->execute()
#19	/srv/mediawiki/php-1.44.0-wmf.19/api.php(44)	MediaWiki\MediaWikiEntryPoint->run()
#20	/srv/mediawiki/w/api.php(3)	require(string)
#21	{main}

Impact

Notes

Details

Request URL: https://en.wikipedia.org/w/api.php?action=query&format=*&cbbuilders=*&prop=*&formatversion=*&pageids=*

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b	mediawiki/core	REL1_43	+7 -2
Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b	mediawiki/core	REL1_42	+7 -2
Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b	mediawiki/core	REL1_39	+7 -2
Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b	mediawiki/core	master	+7 -2

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Resolved		None	T379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T388728 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
			· · ·

Event Timeline

Reedy created this task.Mar 12 2025, 9:30 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptMar 12 2025, 9:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy added a project: PHP 8.1 support.Mar 12 2025, 9:39 PM

Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.

Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.

Reedy moved this task from Untriaged to Mar 2025 on the Wikimedia-production-error board.Mar 12 2025, 9:51 PM

Change #1128048 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Sanitizer::normalize*Whitespace: Don't let preg_replace's potential null return trigger PHP 8.1 deprecations

https://gerrit.wikimedia.org/r/1128048

gerritbot added a project: Patch-For-Review.Mar 16 2025, 10:51 PM

Jdforrester-WMF changed the task status from Open to In Progress.Mar 16 2025, 10:52 PM

Jdforrester-WMF claimed this task.

Gehel moved this task from needs triage to 2025.03.01 - 2025.03.21 on the Discovery-Search board.Mar 17 2025, 3:11 PM

Gehel edited projects, added Discovery-Search (2025.03.01 - 2025.03.21); removed Discovery-Search.

Change #1128048 merged by jenkins-bot:

[mediawiki/core@master] Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b

https://gerrit.wikimedia.org/r/1128048

Change #1128457 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_43] Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b

https://gerrit.wikimedia.org/r/1128457

Change #1128459 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_42] Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b

https://gerrit.wikimedia.org/r/1128459

Change #1128464 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_39] Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b

https://gerrit.wikimedia.org/r/1128464

Change #1128464 merged by jenkins-bot:

[mediawiki/core@REL1_39] Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b

https://gerrit.wikimedia.org/r/1128464

Change #1128459 merged by jenkins-bot:

[mediawiki/core@REL1_42] Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b

https://gerrit.wikimedia.org/r/1128459

Gehel moved this task from Incoming to Blocked / Waiting on the Discovery-Search (2025.03.01 - 2025.03.21) board.Mar 17 2025, 4:39 PM

Change #1128457 merged by jenkins-bot:

[mediawiki/core@REL1_43] Sanitizer::normalizeSectionNameWhitespace: Apply same anti-null fix as 270499b

https://gerrit.wikimedia.org/r/1128457

Provisionally calling this Resolved.

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2025, 5:30 PM

Gehel moved this task from Blocked / Waiting to Done on the Discovery-Search (2025.03.01 - 2025.03.21) board.Mar 21 2025, 1:56 PM

Gehel moved this task from Done to Reported on the Discovery-Search (2025.03.01 - 2025.03.21) board.Mar 21 2025, 2:59 PM

Krinkle moved this task from Mar 2025 to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:13 AM

PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecatedClosed, ResolvedPublicPRODUCTION ERRORActions