Page MenuHomePhabricator

Echo notification icons disappear in dark mode on hover
Closed, DuplicatePublic3 Estimated Story PointsBUG REPORT

Description

This relates to longstanding technical debt that Echo rewrites Codex icons in Vector 2022 to OOUI icons on click.

Steps to replicate the issue (include links if applicable):

  • On desktop enable dark mode
  • click the bell icon
  • Hover over the bell icon

What happens?:
Bell disappears

Screenshot 2025-03-12 at 2.51.49 PM.png (159×379 px, 14 KB)

What should have happened instead?:
As in light theme it shouldn't disappear, I presume?

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson-WMF changed the task status from Open to In Progress.Mar 12 2025, 10:10 PM
JScherer-WMF moved this task from Incoming to Q3 on the Web-Team board.

This is an issue in the Echo extension relating to a recent Codex update. Looks like this relates to Codex which provides background-color and mix-blend-mode.

It seems like when Echo enhances these buttons to be OOUI it should also drop cdx-button cdx-button--weight-quiet cdx-button--icon-only cdx-button--fake-button cdx-button--fake-button--enabled

CCiufo-WMF subscribed.

This is an issue in the Echo extension relating to a recent Codex update. Looks like this relates to Codex which provides background-color and mix-blend-mode.

It seems like when Echo enhances these buttons to be OOUI it should also drop cdx-button cdx-button--weight-quiet cdx-button--icon-only cdx-button--fake-button cdx-button--fake-button--enabled

It looks like just removing those classes in my browser console doesn't quite fix the issue:

image.png (314×1 px, 36 KB)

Also removing .vector-icon helps, but then the hover state is gone:

image.png (314×1 px, 35 KB)

Also, to clarify, @Jdlrobson-WMF, you're suggesting the fix should be entirely within Echo? If this was caused by a change in Codex, I'd be worried about other places this might have affected.

The longstanding issue here is: T343838: Echo should progressively enhance existing notification icon rather than creating its own - basically Echo has code which swaps out the Codex button for an OOUI button 😭. It then has a bunch of CSS in place that makes the OOUI button look like a Codex. button. Clearly having a button that mixes OOUI and Codex classes is not supported so I don't think this would be impacting other places.

Strategically T142981: Provide a single entry point for notification that anticipates the urgency of the notifications received is where we want to get to on the long run.

Jdlrobson changed the task status from In Progress to Open.Mar 14 2025, 7:42 PM
Jdlrobson set the point value for this task to 3.

The longstanding issue here is: T343838: Echo should progressively enhance existing notification icon rather than creating its own - basically Echo has code which swaps out the Codex button for an OOUI button 😭. It then has a bunch of CSS in place that makes the OOUI button look like a Codex. button. Clearly having a button that mixes OOUI and Codex classes is not supported so I don't think this would be impacting other places.

Strategically T142981: Provide a single entry point for notification that anticipates the urgency of the notifications received is where we want to get to on the long run.

I see...I guess I'll move this to following then.