Update code that prevents moving event pages outside the event namespace
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Mar 12 2025, 10:34 PM

Description

Context: currently, when trying to move an event page (with registration enabled) to a target outside the Event: namespace, we disallow the page move with the following message: This event page cannot be moved outside the {{ns:event}} namespace because it has, or had, event registration enabled.. This was implemented as part of T358704. Now we need to generalize this restriction so that pages with registration enabled cannot be moved to a namespace where event registration is not allowed.

Acceptance criteria

When I try to move a page with event registration enabled
AND the target namespace allows event registration
Then the page should be moved.

When I try to move a page with event registration enabled
AND the target namespace does not allow event registration
Then the page should not be moved
AND I should receive the following error: Event registration is not permitted in this namespace.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Allow page moves in permitted namespaces	mediawiki/extensions/CampaignEvents	master	+37 -16

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Daimona	T385341 [EPIC] Allow Event Registration in Alternative Namespaces
Resolved	MHorsey-WMF	T388742 Update code that prevents moving event pages outside the event namespace
Resolved	None	T388699 Figure out what to do with events in namespaces where registration is no longer allowed

Event Timeline

Daimona created this task.Mar 12 2025, 10:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2025, 10:34 PM

Daimona added a subtask: T388699: Figure out what to do with events in namespaces where registration is no longer allowed.Mar 12 2025, 10:35 PM

Daimona added a parent task: T385341: [EPIC] Allow Event Registration in Alternative Namespaces.

ifried closed subtask T388699: Figure out what to do with events in namespaces where registration is no longer allowed as Resolved.Mar 14 2025, 8:08 PM

Daimona renamed this task from [placeholder] Update code that prevents moving event pages outside the event namespace to Update code that prevents moving event pages outside the event namespace.Mar 14 2025, 9:29 PM

Daimona updated the task description. (Show Details)

Daimona mentioned this in T387974: Validate event namespace for retrieval and display.Mar 14 2025, 10:20 PM

MHorsey-WMF claimed this task.Mar 18 2025, 1:33 PM

MHorsey-WMF moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.Mar 20 2025, 1:09 PM

ifried updated the task description. (Show Details)Mar 20 2025, 5:11 PM

Change #1131788 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Allow page moves in permitted namespaces

https://gerrit.wikimedia.org/r/1131788

gerritbot added a project: Patch-For-Review.Mar 27 2025, 5:16 PM

MHorsey-WMF moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Mar 28 2025, 3:54 PM

Change #1131788 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Allow page moves in permitted namespaces

https://gerrit.wikimedia.org/r/1131788

Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Apr 1 2025, 6:13 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2025, 6:30 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 1 2025, 7:00 PM

When I try to move a page with event registration enabled
AND the target namespace allows event registration
✅ Then the page should be moved.

Screen Recording 2025-04-03 at 4.57.52 PM.gif (1×1 px, 1 MB)

When I try to move a page with event registration enabled
AND the target namespace does not allow event registration
✅ Then the page should not be moved
❌ AND I should receive the following error: Event registration is not permitted in this namespace.

Screen Recording 2025-04-03 at 4.59.37 PM.gif (1×1 px, 1 MB)

This is functioning correctly, but the error message is The event page must be in one of the permitted namespaces. Does this just need changed in the AC @MHorsey-WMF

@vaughnwalters, I just updated the AC. In that case, can it be moved to product sign-off?

In T388742#10710898, @vaughnwalters wrote:

This is functioning correctly, but the error message is The event page must be in one of the permitted namespaces. Does this just need changed in the AC @MHorsey-WMF

The gif shows changing the event page associated with event registration, but this task is about moving the event page. The error message sould be correct; the one you saw is from T387967.

In T388742#10714447, @Daimona wrote:

In T388742#10710898, @vaughnwalters wrote:

This is functioning correctly, but the error message is The event page must be in one of the permitted namespaces. Does this just need changed in the AC @MHorsey-WMF

The gif shows changing the event page associated with event registration, but this task is about moving the event page. The error message sould be correct; the one you saw is from T387967.

Ah, thx @Daimona. I was testing the entirely wrong thing. This is working as expected with the error message Event registration is not permitted in this namespace. I'll revert the AC to this @ifried and move this to product sign off.

Acceptance criteria
When I try to move a page with event registration enabled
AND the target namespace allows event registration
✅ Then the page should be moved.

Screen Recording 2025-04-08 at 11.23.23 AM.gif (1×1 px, 637 KB)

When I try to move a page with event registration enabled
AND the target namespace does not allow event registration
✅ Then the page should not be moved
✅ AND I should receive the following error: Event registration is not permitted in this namespace.

Screenshot 2025-04-08 at 11.10.58 AM.png (1×1 px, 294 KB)

vaughnwalters updated the task description. (Show Details)Apr 8 2025, 4:27 PM

VPuffetMichel added a project: OKR-Work.Apr 17 2025, 1:37 PM

This feature is on the beta cluster and working as expected, so I am marking this work as done.

	F59015367: Screenshot 2025-04-08 at 11.10.58 AM.png
	Apr 8 2025, 4:27 PM

	F59015469: Screen Recording 2025-04-08 at 11.23.23 AM.gif
	Apr 8 2025, 4:27 PM

	F58975357: Screenshot 2025-04-03 at 5.09.17 PM.png
	Apr 3 2025, 10:10 PM

	F58975320: Screen Recording 2025-04-03 at 4.59.37 PM.gif
	Apr 3 2025, 10:10 PM

	F58975317: Screen Recording 2025-04-03 at 4.57.52 PM.gif
	Apr 3 2025, 10:10 PM

Update code that prevents moving event pages outside the event namespaceClosed, ResolvedPublicActions