Page MenuHomePhabricator

php-wmerrors rsyslog rule selects on php7 only
Open, In Progress, LowPublic

Description

While looking into T384335: Move rsyslog-generated mediawiki logs within k8s to their own kafka topics I noticed the following in charts/mediawiki/templates/rsyslog/configmap.yaml.tpl:

input(type="imudp" port="10514" address="{{ .Values.mw.logging.allowed_address }}" ruleset="udp_localhost_to_kafka")
# For messages generated by php-wmerrors, also ship them to udp2log
# Emulate MediaWiki's wfDebugLog / wfErrorLog format
template(name="MediaWiki" type="string" string="%programname% %timegenerated% %HOSTNAME%: %msg%\n")
if ($programname startswith 'php7.')  then {
    action(type="omfwd"
            Target={{ (splitList ":" .Values.mw.logging.udp2log_hostport) | first | quote }}
            Port={{ (splitList ":" .Values.mw.logging.udp2log_hostport) | last | quote }}
            Protocol="udp"
            Name="MediaWiki"
            {{- if .Values.mw.logging.udp2log_ratelimit_interval }}
            RateLimit.Interval={{ .Values.mw.logging.udp2log_ratelimit_interval | default 1 | quote }}
            RateLimit.Burst={{ .Values.mw.logging.udp2log_ratelimit_burst | default 100 | quote }}
            {{- end }}
    )
}

Which I'm assuming will need adaptation for php8

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedReedy
StalledNone
OpenNone
OpenNone
OpenNone
ResolvedReedy
ResolvedKrinkle
ResolvedKrinkle
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedLucas_Werkmeister_WMDE
ResolvedNone
ResolvedJdforrester-WMF
ResolvedDaimona
ResolvedJdforrester-WMF
DeclinedNone
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
Resolvedcscott
ResolvedScott_French
DuplicatePRODUCTION ERRORNone
ResolvedPRODUCTION ERRORMichael
ResolvedPRODUCTION ERRORMichael
ResolvedMichael
DuplicatePRODUCTION ERRORNone
ResolvedTgr
ResolvedNone
ResolvedDAlangi_WMF
ResolvedTgr
ResolvedDAlangi_WMF
ResolvedTgr
ResolvedTgr
ResolvedAtieno
OpenNone
Resolvedbrouberol
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedKrinkle
ResolvedKrinkle
ResolvedScott_French
ResolvedKrinkle
ResolvedTgr
ResolvedScott_French
Resolvedjnuche
ResolvedJdforrester-WMF
ResolvedBUG REPORTbd808
ResolvedReedy
ResolvedReedy
Resolvedseanleong-WMDE
StalledNone
OpenNone
ResolvedLucas_Werkmeister_WMDE
ResolvedDaimona
ResolvedDaimona
ResolvedDaimona
OpenNone
ResolvedUmherirrender
OpenNone
ResolvedUmherirrender
ResolvedUmherirrender
Resolved mszabo
Resolvedtstarling
ResolvedUmherirrender
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedPhysikerwelt
ResolvedTgr
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedNone
ResolvedUmherirrender
ResolvedNone
ResolvedNone
ResolvedkarapayneWMDE
ResolvedAudreyPenven_WMDE
ResolvedAudreyPenven_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedLucas_Werkmeister_WMDE
ResolvedUmherirrender
Resolvedthiemowmde
ResolvedLucas_Werkmeister_WMDE
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
Resolved mszabo
ResolvedxSavitar
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
OpenNone
OpenNone
OpenNone
OpenDannyS712
ResolvedUmherirrender
Resolved larissagaulia
ResolvedUmherirrender
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedKrinkle
ResolvedScott_French
In ProgressScott_French

Event Timeline

Change #1127556 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/deployment-charts@master] mediawiki: enable udp2log forwarding on 8.1

https://gerrit.wikimedia.org/r/1127556

Thanks for catching that, @fgiunchedi! Yes, that was, alas, an oversight.

Change #1127556 merged by jenkins-bot:

[operations/deployment-charts@master] mediawiki: enable udp2log forwarding on 8.1

https://gerrit.wikimedia.org/r/1127556

Mentioned in SAL (#wikimedia-operations) [2025-03-13T19:47:45Z] <swfrench@deploy2002> Started scap sync-world: apply rsyslog config changes - T388799

Mentioned in SAL (#wikimedia-operations) [2025-03-13T19:54:36Z] <swfrench@deploy2002> Finished scap sync-world: apply rsyslog config changes - T388799 (duration: 08m 09s)

Scott_French changed the task status from Open to In Progress.Mar 13 2025, 7:57 PM
Scott_French triaged this task as Low priority.

Alright, the rsyslog config will how match on both the 'php7.' and 'php8.' prefix, and I've added a TODO to consider whether that can be simplified to just 'php'. I'll hold onto this until I can resolve that.