- Trigger a mid-edit check.
- Select a link close to the right hand of the page
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
Event Timeline
Comment Actions
Change #1127550 had a related patch set uploaded (by Esanders; author: Esanders):
[VisualEditor/VisualEditor@master] DesktopContext: Clip to the surface view
Comment Actions
Change #1127550 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] DesktopContext: Clip to the surface view
Comment Actions
Change #1129363 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cf81e3d3f)
Comment Actions
Change #1129363 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cf81e3d3f)
Comment Actions
I am still seeing this on this patchdemo: https://4073746e42.catalyst.wmcloud.org/w/index.php?title=Douglas_Adams&veaction=edit
Should I check this on a different version?
Comment Actions
PatchDemo's don't update automatically and that one is from Feb. There are no mid edit checks enabled on beta, so we'll need a new patchdemo. Having tested locally it also appears some more things need fixing.
Comment Actions
Change #1131953 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix overlay and padding for desktop context
Comment Actions
Change #1131953 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix overlay and padding for desktop context
Comment Actions
I re-tested this on this patchdemo: https://patchdemo.wmcloud.org/wikis/fc66659377/wiki/Douglas%20Adams?veaction=edit&ecenable=1
Seems to be still happening there in many ways:
Comment Actions
Per today's offline team meeting, this is ready for QA again and can be tested on any wiki by appending &ecenable=2 to a visual editor editing session URL.
E.g. https://en.wikipedia.org/w/index.php?title=Lemon&veaction=edit&ecenable=2 .
Comment Actions
All good:
Confirm expected experience:
There sidebar is right beside the link, with no padding
For consistent experience, do we want to extend this experience to this experience as well?
Comment Actions
Yes - that looks fine to me - we don't want an overlap in case the user needs to see both the context and the sidebar. The lack of padding should be ok for now - adding padding could lead to the callout triangle being placed close to the edge of the context popup.