PHP Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Reedy
	Mar 13 2025, 4:17 PM

Description

Error

mwversion: 1.44.0-wmf.19
reqId: 6eccc316-9722-4f58-a355-f2369ff0f20b
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated

Frame	Location	Call
from	/srv/mediawiki/php-1.44.0-wmf.19/extensions/WikimediaEvents/includes/PrefUpdateInstrumentation.php(222)
#0	[internal function]	MWExceptionHandler::handleError(int, string, string, int)
#1	/srv/mediawiki/php-1.44.0-wmf.19/extensions/WikimediaEvents/includes/PrefUpdateInstrumentation.php(222)	preg_split(string, null, int, int)
#2	/srv/mediawiki/php-1.44.0-wmf.19/extensions/WikimediaEvents/includes/PrefUpdateInstrumentation.php(179)	WikimediaEvents\PrefUpdateInstrumentation::createPrefUpdateEvent(MediaWiki\User\User, string, null, string)
#3	/srv/mediawiki/php-1.44.0-wmf.19/includes/HookContainer/HookContainer.php(155)	WikimediaEvents\PrefUpdateInstrumentation->onSaveUserOptions(MediaWiki\User\User, array, array)
#4	/srv/mediawiki/php-1.44.0-wmf.19/includes/HookContainer/HookRunner.php(4510)	MediaWiki\HookContainer\HookContainer->run(string, array)
#5	/srv/mediawiki/php-1.44.0-wmf.19/includes/user/Options/UserOptionsManager.php(350)	MediaWiki\HookContainer\HookRunner->onSaveUserOptions(MediaWiki\User\User, array, array)
#6	/srv/mediawiki/php-1.44.0-wmf.19/includes/user/User.php(2451)	MediaWiki\User\Options\UserOptionsManager->saveOptionsInternal(MediaWiki\User\User)
#7	/srv/mediawiki/php-1.44.0-wmf.19/includes/preferences/DefaultPreferencesFactory.php(2041)	MediaWiki\User\User->saveSettings()
#8	/srv/mediawiki/php-1.44.0-wmf.19/extensions/GlobalPreferences/includes/GlobalPreferencesFactory.php(360)	MediaWiki\Preferences\DefaultPreferencesFactory->saveFormData(array, PreferencesFormOOUI, array)
#9	/srv/mediawiki/php-1.44.0-wmf.19/includes/preferences/DefaultPreferencesFactory.php(2088)	GlobalPreferences\GlobalPreferencesFactory->saveFormData(array, PreferencesFormOOUI, array)
#10	/srv/mediawiki/php-1.44.0-wmf.19/includes/preferences/DefaultPreferencesFactory.php(1962)	MediaWiki\Preferences\DefaultPreferencesFactory->submitForm(array, PreferencesFormOOUI, array)
#11	/srv/mediawiki/php-1.44.0-wmf.19/includes/htmlform/HTMLForm.php(824)	MediaWiki\Preferences\DefaultPreferencesFactory->MediaWiki\Preferences\{closure}(array, PreferencesFormOOUI)
#12	/srv/mediawiki/php-1.44.0-wmf.19/includes/htmlform/HTMLForm.php(705)	MediaWiki\HTMLForm\HTMLForm->trySubmit()
#13	/srv/mediawiki/php-1.44.0-wmf.19/includes/htmlform/HTMLForm.php(721)	MediaWiki\HTMLForm\HTMLForm->tryAuthorizedSubmit()
#14	/srv/mediawiki/php-1.44.0-wmf.19/includes/specials/SpecialPreferences.php(132)	MediaWiki\HTMLForm\HTMLForm->show()
#15	/srv/mediawiki/php-1.44.0-wmf.19/includes/specialpage/SpecialPage.php(729)	MediaWiki\Specials\SpecialPreferences->execute(null)
#16	/srv/mediawiki/php-1.44.0-wmf.19/includes/specialpage/SpecialPageFactory.php(1737)	MediaWiki\SpecialPage\SpecialPage->run(null)
#17	/srv/mediawiki/php-1.44.0-wmf.19/includes/actions/ActionEntryPoint.php(503)	MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#18	/srv/mediawiki/php-1.44.0-wmf.19/includes/actions/ActionEntryPoint.php(145)	MediaWiki\Actions\ActionEntryPoint->performRequest()
#19	/srv/mediawiki/php-1.44.0-wmf.19/includes/MediaWikiEntryPoint.php(202)	MediaWiki\Actions\ActionEntryPoint->execute()
#20	/srv/mediawiki/php-1.44.0-wmf.19/index.php(58)	MediaWiki\MediaWikiEntryPoint->run()
#21	/srv/mediawiki/w/index.php(3)	require(string)
#22	{main}

Impact

Notes

Details

Request URL: https://en.wikipedia.org/wiki/Special:Preferences

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	PrefUpdateInstrumentation: Don't error on null pref value	mediawiki/extensions/WikimediaEvents	master	+12 -5

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Resolved		None	T379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T388812 PHP Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated
			· · ·

Event Timeline

Reedy created this task.Mar 13 2025, 4:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2025, 4:17 PM

Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.Mar 13 2025, 4:17 PM

Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.

Reedy moved this task from Untriaged to Mar 2025 on the Wikimedia-production-error board.Mar 13 2025, 4:53 PM

Change #1127581 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikimediaEvents@master] [WIP] PrefUpdateInstrumentation: Error on null/non-string VALUE_NEWLINE_COUNT pref value (?)

https://gerrit.wikimedia.org/r/1127581

gerritbot added a project: Patch-For-Review.Mar 13 2025, 5:54 PM

Jdforrester-WMF changed the task status from Open to In Progress.Mar 16 2025, 10:55 PM

Jdforrester-WMF claimed this task.

Krinkle moved this task from Mar 2025 to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:09 AM

Still seen in 1.45.0-wmf.6 logs and there is a patch awaiting review, thus adding Data-Engineering as I vaguely assume that they might be stewards - no idea how to interpret "Data Products" listed on https://www.mediawiki.org/wiki/Developers/Maintainers (please correct that if you are the stewards - thanks!).

Ahoelzl edited projects, added Test Kitchen; removed Data-Engineering.Jun 25 2025, 5:23 PM

Milimetric triaged this task as High priority.Jun 25 2025, 5:26 PM

Milimetric moved this task from Incoming to Backlog on the Test Kitchen board.

Milimetric moved this task from Backlog to Radar on the Test Kitchen board.Jul 1 2025, 3:09 PM

A_smart_kitten mentioned this in T400068: Clean up WikimediaEvents setting on ex-wikipedia special wikis.Jul 25 2025, 6:41 AM

Change #1127581 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] PrefUpdateInstrumentation: Don't error on null pref value

https://gerrit.wikimedia.org/r/1127581

Umherirrender closed this task as Resolved.Jul 28 2025, 3:44 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.12; 2025-07-29).Jul 28 2025, 4:03 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2025, 4:31 PM