Page MenuHomePhabricator

adjust execution duration metric
Closed, ResolvedPublic

Description

What/Why:
I just noticed that the startTime to record the duration of the execute() function has an error in that this is an async function.
I also think this metric function_duration_milliseconds can have a better name, as in more explicit about it being about a single function in one service.

Also, I need to reinstall my MW local env bc it's due for an update but I'm running into weird behavior with bypass-cache? Not the new toggle itself per se (?) but I usually set it to true (disabling it) in my local env for testing purposes. However, it seems to cache results regardless so I can't see fresh data from new triggers from the UI, even if I restart my docker...

How:

  • use try/finally block inside async function execute()

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
fix metric creation logic and adjust type+repos/abstract-wiki/wikifunctions/function-orchestrator!312ecarggrace/T388859/adjust-duration-metricsmain
Customize query in GitLab

Event Timeline

ecarg changed the task status from Open to In Progress.Mar 14 2025, 9:25 AM
ecarg triaged this task as Medium priority.
ecarg moved this task from To Triage to 25Q3 (Jan–Mar) on the Abstract Wikipedia team board.

Change #1129368 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-11-234105 to 2025-03-19-203723

https://gerrit.wikimedia.org/r/1129368

Change #1129368 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-11-234105 to 2025-03-19-203723

https://gerrit.wikimedia.org/r/1129368