Page MenuHomePhabricator

[wmf.20] RecentChanges - Tagged edit filters icon "More information about..." doesn't redirect to target page [4H]
Closed, ResolvedPublicSpike

Description

Steps to replicate the issue:

  • On enwiki wmf.20 (or any other wiki) go to Special:RecentChanges page
  • Click on Tags filter option or type # to see Tagged edit filter options.
  • When the drop-down menu displays different tags, click on the question mark icon

Screen Shot 2025-03-14 at 5.19.01 PM.png (1×1 px, 310 KB)

What happens?:

tag_filter_button.gif (866×1 px, 504 KB)

What should have happened instead?:

  • the "More information about..." question mark button should open a related info page in a different tab, just as "Learn more bout tagged edits" button does.

Other information:

  • the issue is not reproducible 100% of the time. I tried Chrome and Firefox, the cases when default filters are present and where there were no filters selected, but I was not able to reproduce the correct behavior consistently, i.e when the question mark is clicked, a target page is open in a tab.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Scardenasmolinar renamed this task from [wmf.20] RecentChanges - Tagged edit filters icon "More information about..." doesn't redirect to target page to [wmf.20] RecentChanges - Tagged edit filters icon "More information about..." doesn't redirect to target page [4H].Mar 18 2025, 4:05 PM
Scardenasmolinar added a project: Spike.
Restricted Application changed the subtype of this task from "Bug Report" to "Spike". · View Herald TranscriptMar 18 2025, 4:05 PM

Change #1130185 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/core@master] [wmf.20] RecentChanges - Tagged edit filters icon "More information about..." doesn't redirect to target page [4H]

https://gerrit.wikimedia.org/r/1130185

I created an example PR that fixes this issue, however I can't get it to stop going back to the default menu after clicking into a help link (it looks like it's intentionally clearing the search).
This may be the intended behavior since we didn't actually click or select any tags... though it feels quite awkward.

I'll move to engineering review to see what others think.

Test wiki created on Patch demo by Samwalton9 (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/590008180c/w/

I created an example PR that fixes this issue, however I can't get it to stop going back to the default menu after clicking into a help link (it looks like it's intentionally clearing the search).
This may be the intended behavior since we didn't actually click or select any tags... though it feels quite awkward.

I'll move to engineering review to see what others think.

Hmm, I agree this is awkward. If I'm clicking the ? it's probably because I want to understand if this tag is useful to me, returning to the page to find a different menu is open is unexpected.

I was unable to stop the OOUI input from clearing the "#" when clicking to open a help link in a new tab.
This function is firing when it shouldn't be but it's unclear to me from where?

Moving to engineering review to get some more engineer eyes ( @jsn.sherman , @Scardenasmolinar ) otherwise I can file a follow up patch for addressing the strange input/menu behavior.

Thanks! Just to write down what I said earlier - I think it's totally fine for us to merge this fix and then file a followup ticket to address the other issue, if there's no immediately obvious fix :)

Change #1130185 merged by jenkins-bot:

[mediawiki/core@master] [wmf.20] RecentChanges - Tagged edit filters icon "More information about..." doesn't redirect to target page [4H]

https://gerrit.wikimedia.org/r/1130185

Thank you for finding and fixing this! For reference, these help icons are a new feature I added alongside T372175. Sorry I overlooked this.

the issue is not reproducible 100% of the time. I tried Chrome and Firefox, the cases when default filters are present and where there were no filters selected, but I was not able to reproduce the correct behavior consistently, i.e when the question mark is clicked, a target page is open in a tab.

Testing it now, it seems that before the help buttons worked correctly only when their tag was selected in the dropdown.

This looks good on test wiki.

Test wiki on Patch demo by Samwalton9 (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/590008180c/w/