Page MenuHomePhabricator

Drop views of module_deps tables
Closed, ResolvedPublicBUG REPORT

Description

When I run the statement 'SHOW TABLE STATUS' on Database dewiki_p I see two tables with problems:

  • global_block_whitelist

Field "comment' shows
"View 'dewiki_p.global_block_whitelist' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them"

similar

  • module_deps

"View 'dewiki_p.module_deps' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them"

Details

Event Timeline

global_block_whitelist was recently adjusted (T387663/T378747), and WMCS needs the views updating, which is T387663: Update views on global_block_whitelist tables.

module_deps was recently deleted from production (T379661/T385997); I suppose this task can be for the WMCS drop?

Jdforrester-WMF renamed this task from Errors in 'show table status' in dewiki_p to Drop views of module_deps tables.Mar 15 2025, 8:24 PM

Change #1128014 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] P:wmcs: wikireplicas: Drop module_deps view

https://gerrit.wikimedia.org/r/1128014

Change #1128014 merged by Ladsgroup:

[operations/puppet@production] P:wmcs: wikireplicas: Drop module_deps view

https://gerrit.wikimedia.org/r/1128014

Cookbook cookbooks.sre.wikireplicas.update-views run by ladsgroup: Started updating wiki replica views

Cookbook cookbooks.sre.wikireplicas.update-views started by ladsgroup completed:

  • an-redacteddb1001.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace-all --auto-depool --all-databases --table module_deps'
  • clouddb1017.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace-all --auto-depool --all-databases --table module_deps'
  • clouddb1018.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace-all --auto-depool --all-databases --table module_deps'
  • clouddb1019.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace-all --auto-depool --all-databases --table module_deps'
  • clouddb1020.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace-all --auto-depool --all-databases --table module_deps'
  • clouddb1013.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace-all --auto-depool --all-databases --table module_deps'
  • clouddb1014.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace-all --auto-depool --all-databases --table module_deps'
  • clouddb1015.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace-all --auto-depool --all-databases --table module_deps'
  • clouddb1016.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --replace-all --auto-depool --all-databases --table module_deps'

Is this done? I see update-views was run by @Ladsgroup

Ladsgroup claimed this task.

Yup!

The views were not dropped, because the maintain-views script was run without the --clean option:

--clean               Clean out views from _p db that are no longer specified.

We should probably make that option enabled by default.

I noticed because I'm now running the script with --clean in T390767: Remove the compatibility layer of block schema in wikireplicas, and it's also dropping the module_deps views.