Page MenuHomePhabricator

Core permission error shouldn't display group names the user is already in
Open, Needs TriagePublic

Description

I just saw

image.png (182×976 px, 25 KB)

despite being logged into an admin account while reporting T388988.

This doesn't make sense. If the user is in one of the groups it says you need to be in, core should detect that and display a better error message. Even just badaccess-group0 ("You are not allowed to execute the action you have requested.") would be better.

Event Timeline

Pppery renamed this task from Core permission error shouldn't display nonsense. to Core permission error shouldn't display group names the user is already in.Mar 15 2025, 10:15 PM

This should be straightforward to fix, but looking at the code it isn't because the user information is lost by the time the status message is being generated.

Change #1222683 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/core@master] Don't display list of groups if it includes one you are already in

https://gerrit.wikimedia.org/r/1222683