Page MenuHomePhabricator

Fix validation for currency-prefixed amounts in the "other" donation field
Closed, ResolvedPublic

Description

Some donors are entering currency prefixes inside the Other Amount field on the recurring upgrade form, which is preventing the form from being submitted. However, the form suggests the input is valid, resulting in donors reaching out to donor relations to see what's wrong.

We can fix this a couple of ways, such as stripping non-numeric data on submit or even adding a symbol prefix to the input field if that's enough.

This came to light in
T388912: Checksums and contact ids missing from recurring upgrade links and can be replicated locally

image.png (1,211×658 px, 51 KB)

Event Timeline

Change #1128475 had a related patch set uploaded (by Cstone; author: Cstone):

[mediawiki/extensions/DonationInterface@master] Switch back to number input type

https://gerrit.wikimedia.org/r/1128475

Change #1128475 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Switch back to number input type

https://gerrit.wikimedia.org/r/1128475

AKanji-WMF moved this task from Triage to Chaos Crew Backlog on the Fundraising-Backlog board.

Change #1128593 had a related patch set uploaded (by Cstone; author: Cstone):

[mediawiki/extensions/DonationInterface@master] Handle non numbers (and .,) in Firefox and Safari

https://gerrit.wikimedia.org/r/1128593

Firefox and Safari doing their own number thing, the above patch is matching what donate wiki does to handle the other amount field

https://donate.wikimedia.org/wiki/MediaWiki:DonationForm.js#L-1183

Change #1128593 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Handle non numbers (and .,) in Firefox and Safari

https://gerrit.wikimedia.org/r/1128593

XenoRyet set Final Story Points to 4.