Page MenuHomePhabricator
Create Task
Maniphest T389118

[jobs-api] refactor models
Closed, ResolvedPublic
Actions

Description

  • split Newjob into OneOffJob, ScheduledJob and ContinuousJob
  • move all remaining custom validations to internal jobs model
  • any other changes that'll simplify the models in jobs-api

The goal of this change is to simplify the api models in jobs-api and get rid of as much custom validations as we can, since these models are now being used in places like components-api (kind of) and eventually we will want to generate a 'library' out of them for others to reuse.

Related Objects
Search...

Event Timeline

Raymond_Ndibe created this task.Mar 17 2025, 8:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2025, 8:12 PM
CodeReviewBot added a project: Patch-For-Review.Mar 17 2025, 8:14 PM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/149

[jobs-api] refactor imagename field in models

CodeReviewBot added a comment.Mar 17 2025, 10:26 PM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/90

[jobs-cli] use imagename in definedjob

dcaro triaged this task as High priority.Mar 18 2025, 10:00 AM
dcaro updated the task description. (Show Details)
dcaro edited projects, added Toolforge (Toolforge iteration 19); removed Toolforge (Toolforge iteration 18).Mar 18 2025, 3:56 PM
CodeReviewBot added a comment.Mar 19 2025, 4:13 AM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/150

Draft: [jobs-api] move custom validations out of api models

dcaro changed the task status from Open to In Progress.Mar 19 2025, 12:52 PM
dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 19) board.
CodeReviewBot added a comment.Apr 7 2025, 6:52 AM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/149

[jobs-api] refactor imagename field in models

CodeReviewBot added a comment.Apr 7 2025, 6:55 AM

group_203_bot_4866fc124f4b41659f667468a6115cf3 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/738

jobs-api: bump to 0.0.363-20250407065250-1453d60e

CodeReviewBot added a comment.Apr 7 2025, 8:05 AM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/738

jobs-api: bump to 0.0.363-20250407065250-1453d60e

CodeReviewBot added a comment.Apr 7 2025, 8:05 AM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/90

[jobs-cli] use imagename in definedjob

CodeReviewBot added a comment.Apr 7 2025, 8:17 AM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/95

d/changelog: bump to 16.1.10

CodeReviewBot added a comment.Apr 7 2025, 8:44 AM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/95

d/changelog: bump to 16.1.10

CodeReviewBot added a comment.Apr 8 2025, 2:41 AM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/96

[jobs-cli] schedule timeout default None

CodeReviewBot added a comment.Apr 8 2025, 3:22 AM

raymond-ndibe updated https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/139

[jobs-api] use pydantic for all models

CodeReviewBot added a comment.Apr 9 2025, 3:44 PM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/97

[jobs-cli] health_check and quota refactor

CodeReviewBot added a comment.Apr 11 2025, 4:20 AM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/154

[jobs-api] split job models to oneoff, scheduled and continuous

Raymond_Ndibe moved this task from In Progress to In Review on the Toolforge (Toolforge iteration 19) board.Apr 11 2025, 5:34 AM
CodeReviewBot added a comment.Apr 11 2025, 8:32 PM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/98

[jobs-cli] refactor job payload

Raymond_Ndibe added a subtask: T390136: [jobs-api] Split the `*Job` API models into three.Apr 13 2025, 12:44 AM
Raymond_Ndibe changed the status of subtask T390136: [jobs-api] Split the `*Job` API models into three from Open to In Progress.Apr 13 2025, 12:48 AM
CodeReviewBot added a comment.May 7 2025, 8:15 AM

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/96

[jobs-cli] only send timeout if it's set by the user

CodeReviewBot added a comment.May 7 2025, 8:18 AM

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/102

d/changelog: bump to 16.1.12

CodeReviewBot added a comment.May 7 2025, 9:12 AM

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-cli/-/merge_requests/102

d/changelog: bump to 16.1.12

CodeReviewBot added a comment.May 12 2025, 6:48 PM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/150

[jobs-api] move custom validations out of api models

CodeReviewBot added a comment.May 12 2025, 6:50 PM

group_203_bot_f4d95069bb2675e4ce1fff090c1c1620 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/778

jobs-api: bump to 0.0.373-20250512184826-3b202d92

CodeReviewBot added a comment.May 12 2025, 9:13 PM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/164

[jobs-api] refactor quota models

CodeReviewBot added a comment.May 12 2025, 9:49 PM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/778

jobs-api: bump to 0.0.373-20250512184826-3b202d92

dcaro edited projects, added Toolforge (Toolforge iteration 20); removed Toolforge (Toolforge iteration 19).May 14 2025, 2:29 PM
dcaro moved this task from Next Up to In Review on the Toolforge (Toolforge iteration 20) board.
dcaro moved this task from In Review to In Progress on the Toolforge (Toolforge iteration 20) board.May 19 2025, 12:08 PM
CodeReviewBot added a comment.May 22 2025, 7:45 PM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/139

[jobs-api] use pydantic for all models

CodeReviewBot added a comment.May 22 2025, 7:47 PM

group_203_bot_f4d95069bb2675e4ce1fff090c1c1620 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/794

jobs-api: bump to 0.0.378-20250522194547-6776b4db

CodeReviewBot added a comment.May 22 2025, 10:04 PM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/794

jobs-api: bump to 0.0.378-20250522194547-6776b4db

taavi added a subtask: T396210: `toolforge jobs dump` fails for tools.stewardsbot.Jun 6 2025, 11:46 AM
Raymond_Ndibe changed the status of subtask T396210: `toolforge jobs dump` fails for tools.stewardsbot from Open to In Progress.Jun 6 2025, 6:46 PM
Raymond_Ndibe closed subtask T396210: `toolforge jobs dump` fails for tools.stewardsbot as Resolved.
dcaro reopened subtask T396210: `toolforge jobs dump` fails for tools.stewardsbot as Open.Jun 11 2025, 8:55 AM
dcaro edited projects, added Toolforge (Toolforge iteration 21); removed Toolforge (Toolforge iteration 20).Jun 11 2025, 10:38 AM
dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 21) board.
dcaro changed the status of subtask T396210: `toolforge jobs dump` fails for tools.stewardsbot from Open to In Progress.
CodeReviewBot added a comment.Jul 7 2025, 8:44 PM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/181

[quota] inc deprecated counter for quota requests

dcaro closed subtask T396210: `toolforge jobs dump` fails for tools.stewardsbot as Resolved.Jul 8 2025, 3:01 PM
CodeReviewBot added a comment.Jul 8 2025, 5:43 PM

raymond-ndibe closed https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/181

[quota] inc deprecated counter for quota requests

Raymond_Ndibe moved this task from In Progress to In Review on the Toolforge (Toolforge iteration 21) board.Jul 8 2025, 6:21 PM
dcaro edited projects, added Toolforge (Toolforge iteration 22); removed Toolforge (Toolforge iteration 21).Jul 14 2025, 9:47 AM
dcaro moved this task from Next Up to In Review on the Toolforge (Toolforge iteration 22) board.
dcaro edited projects, added Toolforge (Toolforge iteration 23); removed Toolforge (Toolforge iteration 22).Aug 5 2025, 3:44 PM
dcaro moved this task from Next Up to In Review on the Toolforge (Toolforge iteration 23) board.
dcaro edited projects, added Toolforge (Toolforge iteration 24); removed Toolforge (Toolforge iteration 23).Aug 27 2025, 9:42 AM
dcaro moved this task from Next Up to In Review on the Toolforge (Toolforge iteration 24) board.
CodeReviewBot added a comment.Sep 25 2025, 10:20 AM

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/154

[jobs-api] split job models to oneoff, scheduled and continuous

CodeReviewBot added a comment.Sep 25 2025, 10:23 AM

group_203_bot_f4d95069bb2675e4ce1fff090c1c1620 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/980

jobs-api: bump to 0.0.418-20250925102045-75109675

CodeReviewBot added a comment.Sep 25 2025, 5:49 PM

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/980

jobs-api: bump to 0.0.420-20250925165253-31f66be8

dcaro closed subtask T390136: [jobs-api] Split the `*Job` API models into three as Resolved.Oct 8 2025, 12:28 PM
Raymond_Ndibe closed this task as Resolved.Oct 14 2025, 7:46 PM
Raymond_Ndibe moved this task from In Review to Done on the Toolforge (Toolforge iteration 24) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits