Possible to break a page with invalid data
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson-WMF
	Mar 17 2025, 8:54 PM

Description

Steps to replicate the issue (include links if applicable):

Create invalid data e.g. https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=Data:1993_Canadian_federal_election_localized.tab by bypassing validation (create page in article namespace and move ot data namespace)
Make a chart that references the invalid data e.g. https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=Data:Break.chart

NOTE: if an article page already references the chart, this will break the article page too

What happens?:
Entire page breaks.

What should have happened instead?:
An error message box displays

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Fix localization for validation errors checking tabular data	mediawiki/extensions/Chart	wmf/1.44.0-wmf.27	+8 -2
Fix localization for validation errors checking tabular data	mediawiki/extensions/Chart	master	+8 -2
Fix localization for validation errors checking tabular data	mediawiki/extensions/Chart	master	+8 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		aude	T389857 Run validation on charts before render
Resolved		None	T383079 Epic: Deploy Charts to other wikis
Resolved	BUG REPORT	CCiufo-WMF	T389126 Possible to break a page with invalid data

Event Timeline

Jdlrobson-WMF created this task.Mar 17 2025, 8:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2025, 8:54 PM

Jdlrobson-WMF updated the task description. (Show Details)Mar 17 2025, 8:56 PM

Ayush_khati1 merged a task: T389125: Possible to break a page by passing in a chart that is not a JSON.Mar 17 2025, 9:27 PM

Ayush_khati1 closed this task as a duplicate of T389125: Possible to break a page by passing in a chart that is not a JSON.

Not a duplicate of that task.

Jdlrobson-WMF triaged this task as High priority.Mar 17 2025, 9:36 PM

Jdlrobson-WMF moved this task from Backlog to Up Next on the Charts board.

CCiufo-WMF updated the task description. (Show Details)Mar 17 2025, 9:50 PM

CCiufo-WMF mentioned this in T389857: Run validation on charts before render.Mar 24 2025, 6:44 PM

CCiufo-WMF added a subtask: T389857: Run validation on charts before render.

Jdlrobson-WMF removed a subtask: T389857: Run validation on charts before render.Mar 24 2025, 6:57 PM

Jdlrobson-WMF added a parent task: T389857: Run validation on charts before render.

CCiufo-WMF added a parent task: T383079: Epic: Deploy Charts to other wikis.Mar 26 2025, 8:14 PM

Seddon moved this task from Up Next to Current Sprint on the Charts board.Apr 29 2025, 6:36 PM

Seddon edited projects, added Charts (Current Sprint); removed Charts.

Seddon moved this task from Incoming to Blocked on the Charts (Current Sprint) board.

Current behavior looks like this, with an add double error message but a functional wiki skin:

It doesn't break the ability to go in and edit the page, but the incorrect message seems wrong and should be corrected.

Change #1139934 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/Chart@master] Fix localization for validation errors checking tabular data

https://gerrit.wikimedia.org/r/1139934

Change #1139935 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/Chart@HEAD] Fix localization for validation errors checking tabular data

https://gerrit.wikimedia.org/r/1139935

Change #1139934 abandoned by Bvibber:

[mediawiki/extensions/Chart@master] Fix localization for validation errors checking tabular data

Reason:

wrong base rev

https://gerrit.wikimedia.org/r/1139934

Change #1139937 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/Chart@master] Fix localization for validation errors checking tabular data

https://gerrit.wikimedia.org/r/1139937

Change #1139937 merged by jenkins-bot:

[mediawiki/extensions/Chart@master] Fix localization for validation errors checking tabular data

https://gerrit.wikimedia.org/r/1139937

• brooke mentioned this in rECRT6f4817786377: Fix localization for validation errors checking tabular data.Apr 29 2025, 10:56 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).Apr 29 2025, 11:00 PM

bvibber moved this task from Blocked to Merged and Awaiting Deployment on the Charts (Current Sprint) board.Apr 30 2025, 5:34 PM

Change #1140228 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/Chart@wmf/1.44.0-wmf.27] Fix localization for validation errors checking tabular data

https://gerrit.wikimedia.org/r/1140228

Change #1140228 merged by jenkins-bot:

[mediawiki/extensions/Chart@wmf/1.44.0-wmf.27] Fix localization for validation errors checking tabular data

https://gerrit.wikimedia.org/r/1140228

Mentioned in SAL (#wikimedia-operations) [2025-05-01T20:14:48Z] <jhuneidi@deploy1003> Started scap sync-world: Backport for [[gerrit:1140229|Check for content validity before extracting license (T389125)]], [[gerrit:1140228|Fix localization for validation errors checking tabular data (T389126)]]

• brooke mentioned this in rECRT74d76b93c7f1: Fix localization for validation errors checking tabular data.May 1 2025, 8:15 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-01T20:33:48Z] <jhuneidi@deploy1003> bvibber, jhuneidi: Backport for [[gerrit:1140229|Check for content validity before extracting license (T389125)]], [[gerrit:1140228|Fix localization for validation errors checking tabular data (T389126)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-05-01T20:45:23Z] <jhuneidi@deploy1003> Finished scap sync-world: Backport for [[gerrit:1140229|Check for content validity before extracting license (T389125)]], [[gerrit:1140228|Fix localization for validation errors checking tabular data (T389126)]] (duration: 30m 35s)