Page MenuHomePhabricator
Create Task
Maniphest T389147

[Compose] Convert WatchlistExpiryDialog to use Compose
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
WRai-WMF
Authored By
cooltey
Mar 17 2025, 10:52 PM
Tags
Referenced Files
F65689632: Screenshot_20250729-121509.png
Jul 29 2025, 7:17 PM
F65689631: Screenshot_20250729-121543.png
Jul 29 2025, 7:17 PM
F63360534: compose_1.png
Jul 7 2025, 3:24 PM
F63360526: non_compose.png
Jul 7 2025, 3:24 PM
Subscribers
ABorbaWMF
Aklapper
cooltey
SChekfa-WMF

Description

Requirements
  1. Convert the WatchlistExpiryDialog to use Compose.
  2. Make sure the ExtendedBottomSheetDialogFragment is able to be used by a non-Compose method.
  3. Make sure the Compose layout can work properly and correctly with the existing ViewModel.
  4. Share screenshots for the before vs after the conversion.

Related Objects
Search...

Event Timeline

cooltey created this task.Mar 17 2025, 10:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2025, 10:52 PM
cooltey triaged this task as Low priority.Mar 17 2025, 10:53 PM
cooltey moved this task from Epics in Progress to Needs Engineering Sync on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.
cooltey set the point value for this task to 5.Mar 20 2025, 5:37 PM
cooltey moved this task from Needs Engineering Sync to Ready for future sprints on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Mar 20 2025, 8:34 PM
cooltey moved this task from Ready for future sprints to Needs Engineering Sync on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.
Seddon moved this task from Needs Engineering Sync to Ready for future sprints on the Wikipedia-Android-App-Backlog (Android Release - FY2024-25) board.Jun 17 2025, 4:52 PM
Seddon added a project: Android Sprint 2025: Lunar.Jul 1 2025, 12:09 PM
Seddon edited projects, added Wikipedia-Android-App-Backlog (Android Release - FY2025-26); removed Wikipedia-Android-App-Backlog (Android Release - FY2024-25).Jul 1 2025, 12:25 PM
Seddon moved this task from Epics in Progress to Ready for future sprints (P1) on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.
WRai-WMF claimed this task.Jul 1 2025, 2:35 PM
WRai-WMF moved this task from Ready for future sprints (P1) to Doing on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.
Seddon added a project: Android Sprint 2025: MilkyWay.Jul 1 2025, 4:28 PM
WRai-WMF added a subscriber: SChekfa-WMF.Jul 7 2025, 3:24 PM

Hi @SChekfa-WMF
This is ready for design review.

non_compose.png (1×1 px, 820 KB)
compose_1.png (1×1 px, 820 KB)
Non Compose VersionCompose Version
WRai-WMF moved this task from Doing to Design signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.Jul 7 2025, 3:24 PM
GitHubPRBot added a comment.Jul 8 2025, 10:47 PM

cooltey closed https://github.com/wikimedia/apps-android-wikipedia/pull/5743

SChekfa-WMF added a comment.Jul 22 2025, 3:15 PM

apologies for missing this, it looks good to me! thank you @WRai-WMF.

WRai-WMF added a comment.Jul 22 2025, 3:19 PM

@SChekfa-WMF no worries.

WRai-WMF moved this task from Design signoff to Merged and Waiting on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.Jul 22 2025, 3:19 PM
WRai-WMF moved this task from Merged and Waiting to QA signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.Jul 28 2025, 10:07 PM
ABorbaWMF moved this task from QA signoff to Did not pass QA on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.Jul 29 2025, 7:17 PM
ABorbaWMF subscribed.

Failed on 2.7.50542-r-2025-07-28

Tested on Pixel 6 on Android 15 and OnePlus 8 on Android 13. In the dark modes, the watch expiration dialog remains in light theme.

Screenshot_20250729-121543.png (1×2 px, 122 KB)

Screenshot_20250729-121509.png (2×1 px, 881 KB)

WRai-WMF moved this task from Did not pass QA to Code Review on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.Jul 30 2025, 6:49 PM
WRai-WMF moved this task from Code Review to Merged and Waiting on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.Jul 30 2025, 6:55 PM
WRai-WMF moved this task from Merged and Waiting to QA signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.Jul 31 2025, 8:21 PM
ABorbaWMF moved this task from QA signoff to Ready for PM signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.Aug 1 2025, 4:38 PM

Looks good on 2.7.50543-r-2025-07-31

Tested on Pixel 6 on Android 15 and OnePlus 8 on Android 13. Tested watch and unwatch

JTannerWMF moved this task from Ready for PM signoff to Ready for release on the Wikipedia-Android-App-Backlog (Android Release - FY2025-26) board.Aug 6 2025, 4:20 PM
WRai-WMF closed this task as Resolved.Aug 6 2025, 7:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits